Alfred Kamanda Alfred-mk
0 Followers · 0 Following
  • Nairobi, Kenya
  • Joined on 2024-08-12
Repositories Projects Packages Public Activity Starred Repositories
Alfred-mk commented on issue urdt/ussd#73 2024-09-21 01:04:38 +02:00
AT sometimes asks for things twice

Noted that this now occurs on the menu, mostly related to PIN checks/authorize

urdt/ussd#47 (comment)

Alfred-mk commented on issue urdt/ussd#47 2024-09-21 01:00:45 +02:00
PIN confirmation problem in send

I have done several tests on the "Send" node and "Change language". On the CLI, the menu flows without breaking. The rest either stall or return an error.

Running cmd/main.go <img width="584"…

Alfred-mk reopened issue urdt/ussd#47 2024-09-21 01:00:45 +02:00
PIN confirmation problem in send
Alfred-mk commented on pull request urdt/ussd#71 2024-09-20 21:24:44 +02:00
go-vise-0.2.0

@lash kindly confirm if all changes have been implemented

Alfred-mk pushed to go-vise-0.2.0 at urdt/ussd 2024-09-20 21:17:04 +02:00
e754773bce remove need for initial Exec before loop
63c7c65a00 rename all WriteResult to Flush
9925b3a2e5 use updated latest commit from go-vise 0.2.0
Compare 3 commits »
Alfred-mk pushed to go-vise-0.2.0 at urdt/ussd 2024-09-20 12:54:49 +02:00
a1056cf287 removed unused code
Alfred-mk closed issue urdt/ussd#35 2024-09-20 12:52:39 +02:00
remove dead fs data code
Alfred-mk created pull request urdt/ussd#71 2024-09-20 12:34:01 +02:00
go-vise-0.2.0
Alfred-mk pushed to go-vise-0.2.0 at urdt/ussd 2024-09-20 12:32:17 +02:00
e6e701a609 remove init and use Exec
b66891a646 use latest commit from go-vise 0.2.0
Compare 2 commits »
Alfred-mk created branch go-vise-0.2.0 in urdt/ussd 2024-09-20 11:17:30 +02:00
Alfred-mk pushed to go-vise-0.2.0 at urdt/ussd 2024-09-20 11:17:30 +02:00
Alfred-mk deleted branch wip-http-server from urdt/ussd 2024-09-20 11:14:06 +02:00
Alfred-mk deleted branch africas-talking from urdt/ussd 2024-09-20 11:11:09 +02:00
Alfred-mk commented on pull request urdt/ussd#63 2024-09-19 17:57:24 +02:00
at-return-output

Add a test please?

This has been done

I have also moved the mocks package for easier usage

Alfred-mk pushed to at-return-output at urdt/ussd 2024-09-19 17:52:41 +02:00
3fe66466c5 renamed test file and added server.go tests
Alfred-mk pushed to at-return-output at urdt/ussd 2024-09-19 16:24:41 +02:00
f6979868e5 added at_session_handler tests
e8be64ae28 added http related mocks
e4d8bfad7b moved the mocks package
Compare 3 commits »
Alfred-mk pushed to at-return-output at urdt/ussd 2024-09-18 14:43:58 +02:00
10de039da0 remove obsolete code
Alfred-mk created pull request urdt/ussd#63 2024-09-18 14:32:58 +02:00
at-return-output
Alfred-mk commented on issue urdt/ussd#54 2024-09-18 14:25:45 +02:00
AT should not return CON on status != 200

This was occurring since an error in the GetSessionId was not being returned, and the code was being executed till the end.

I have added a return statement to resolve this.

Also set the…

Alfred-mk pushed to at-return-output at urdt/ussd 2024-09-18 14:12:12 +02:00
27aa71e0ee only set the code to 200 if no error exists