Support pbkdf2 keyfile #1

Closed
opened 2022-01-04 20:44:36 +01:00 by lash · 1 comment
Owner

A reported atteempt at using a keyfile generated by the openethereum node fails as funga-eth keyfile module still doesn't speak pbkdf:

WALLET_KEY_FILE=$(pwd)/private_key WALLET_PASSPHRASE=test RPC_PROVIDER=https://rpc.grassecon.net erc20-transfer -e 3FF776B6f888980DEf9d4220858803f9dC5e341e -a de68731a41af9282ae5a48c1001e3b97201956b6 50

Traceback (most recent call last):
  File "/home/kamikaze/.local/bin/erc20-transfer", line 5, in <module>
    from eth_erc20.runnable.transfer import main
  File "/home/kamikaze/.local/lib/python3.9/site-packages/eth_erc20/runnable/transfer.py", line 49, in <module>
    wallet.from_config(config)
  File "/home/kamikaze/.local/lib/python3.9/site-packages/chainlib/cli/wallet.py", line 51, in from_config
    self.from_keyfile(wallet_keyfile, passphrase=config.get('WALLET_PASSPHRASE', ''))
  File "/home/kamikaze/.local/lib/python3.9/site-packages/chainlib/cli/wallet.py", line 67, in from_keyfile
    self.signer_address = self.keystore.import_keystore_file(key_file, password=passphrase)
  File "/home/kamikaze/.local/lib/python3.9/site-packages/funga/eth/keystore/interface.py", line 49, in import_keystore_file
    private_key = keyfile.from_file(keystore_file, password)
  File "/home/kamikaze/.local/lib/python3.9/site-packages/funga/eth/keystore/keyfile.py", line 157, in from_file
    return from_dict(o, passphrase)
  File "/home/kamikaze/.local/lib/python3.9/site-packages/funga/eth/keystore/keyfile.py", line 122, in from_dict
    raise NotImplementedError('kdf "{}" not implemented'.format(kdf))
NotImplementedError: kdf "pbkdf2" not implemented
A reported atteempt at using a keyfile generated by the openethereum node fails as funga-eth keyfile module still doesn't speak pbkdf: ``` WALLET_KEY_FILE=$(pwd)/private_key WALLET_PASSPHRASE=test RPC_PROVIDER=https://rpc.grassecon.net erc20-transfer -e 3FF776B6f888980DEf9d4220858803f9dC5e341e -a de68731a41af9282ae5a48c1001e3b97201956b6 50 Traceback (most recent call last): File "/home/kamikaze/.local/bin/erc20-transfer", line 5, in <module> from eth_erc20.runnable.transfer import main File "/home/kamikaze/.local/lib/python3.9/site-packages/eth_erc20/runnable/transfer.py", line 49, in <module> wallet.from_config(config) File "/home/kamikaze/.local/lib/python3.9/site-packages/chainlib/cli/wallet.py", line 51, in from_config self.from_keyfile(wallet_keyfile, passphrase=config.get('WALLET_PASSPHRASE', '')) File "/home/kamikaze/.local/lib/python3.9/site-packages/chainlib/cli/wallet.py", line 67, in from_keyfile self.signer_address = self.keystore.import_keystore_file(key_file, password=passphrase) File "/home/kamikaze/.local/lib/python3.9/site-packages/funga/eth/keystore/interface.py", line 49, in import_keystore_file private_key = keyfile.from_file(keystore_file, password) File "/home/kamikaze/.local/lib/python3.9/site-packages/funga/eth/keystore/keyfile.py", line 157, in from_file return from_dict(o, passphrase) File "/home/kamikaze/.local/lib/python3.9/site-packages/funga/eth/keystore/keyfile.py", line 122, in from_dict raise NotImplementedError('kdf "{}" not implemented'.format(kdf)) NotImplementedError: kdf "pbkdf2" not implemented ```
lash added the
enhancement
good first issue
labels 2022-01-05 16:17:59 +01:00
Author
Owner

closed by e5cd1cad58

closed by https://git.grassecon.net/chaintool/funga-eth/commit/e5cd1cad58fb2d9e39f37817843ad7f2fc5004d3
lash closed this issue 2022-01-24 18:58:00 +01:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: chaintool/funga-eth#1
No description provided.