From 4b2eb7b0188e1842930ea93bba4ca29b0ab939f8 Mon Sep 17 00:00:00 2001
From: Mohammed Sohail <sohailsameja@gmail.com>
Date: Fri, 24 Feb 2023 07:48:47 +0000
Subject: [PATCH] refactor: pass struct through pipeline fllters

---
 internal/filter/address_filter.go       | 2 +-
 internal/filter/address_filter_test.go  | 2 +-
 internal/filter/filter.go               | 2 +-
 internal/filter/gas_filter.go           | 2 +-
 internal/filter/transfer_filter.go      | 2 +-
 internal/filter/transfer_filter_test.go | 2 +-
 internal/pipeline/pipeline.go           | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/internal/filter/address_filter.go b/internal/filter/address_filter.go
index 6705826..12efe72 100644
--- a/internal/filter/address_filter.go
+++ b/internal/filter/address_filter.go
@@ -25,7 +25,7 @@ func NewAddressFilter(o AddressFilterOpts) Filter {
 	}
 }
 
-func (f *AddressFilter) Execute(_ context.Context, transaction *fetch.Transaction) (bool, error) {
+func (f *AddressFilter) Execute(_ context.Context, transaction fetch.Transaction) (bool, error) {
 	if _, found := f.cache.Load(transaction.To.Address); found {
 		return true, nil
 	}
diff --git a/internal/filter/address_filter_test.go b/internal/filter/address_filter_test.go
index 45461fb..772ce98 100644
--- a/internal/filter/address_filter_test.go
+++ b/internal/filter/address_filter_test.go
@@ -66,7 +66,7 @@ func (s *AddressFilterSuite) TestAddresses() {
 	}
 
 	for _, test := range tests {
-		next, err := s.filter.Execute(context.Background(), &test.transactionData)
+		next, err := s.filter.Execute(context.Background(), test.transactionData)
 		s.NoError(err)
 		s.Equal(test.want, next)
 	}
diff --git a/internal/filter/filter.go b/internal/filter/filter.go
index 77d340c..4006a94 100644
--- a/internal/filter/filter.go
+++ b/internal/filter/filter.go
@@ -8,5 +8,5 @@ import (
 
 // Filter defines a read only filter which must return next as true/false or an error
 type Filter interface {
-	Execute(ctx context.Context, inputTransaction *fetch.Transaction) (next bool, err error)
+	Execute(ctx context.Context, inputTransaction fetch.Transaction) (next bool, err error)
 }
diff --git a/internal/filter/gas_filter.go b/internal/filter/gas_filter.go
index bf841b0..30f0bfe 100644
--- a/internal/filter/gas_filter.go
+++ b/internal/filter/gas_filter.go
@@ -40,7 +40,7 @@ func NewGasFilter(o GasFilterOpts) Filter {
 	}
 }
 
-func (f *GasFilter) Execute(_ context.Context, transaction *fetch.Transaction) (bool, error) {
+func (f *GasFilter) Execute(_ context.Context, transaction fetch.Transaction) (bool, error) {
 	switch transaction.InputData[:10] {
 	case "0x63e4bff4":
 		var (
diff --git a/internal/filter/transfer_filter.go b/internal/filter/transfer_filter.go
index cadc2ab..d67608c 100644
--- a/internal/filter/transfer_filter.go
+++ b/internal/filter/transfer_filter.go
@@ -46,7 +46,7 @@ func NewTransferFilter(o TransferFilterOpts) Filter {
 	}
 }
 
-func (f *TransferFilter) Execute(_ context.Context, transaction *fetch.Transaction) (bool, error) {
+func (f *TransferFilter) Execute(_ context.Context, transaction fetch.Transaction) (bool, error) {
 	switch transaction.InputData[:10] {
 	case "0xa9059cbb":
 		var (
diff --git a/internal/filter/transfer_filter_test.go b/internal/filter/transfer_filter_test.go
index 1642f92..092c65f 100644
--- a/internal/filter/transfer_filter_test.go
+++ b/internal/filter/transfer_filter_test.go
@@ -66,7 +66,7 @@ func (s *TransferFilterSuite) TestTranfserInputs() {
 	}
 
 	for _, test := range tests {
-		next, err := s.filter.Execute(context.Background(), &test.transactionData)
+		next, err := s.filter.Execute(context.Background(), test.transactionData)
 		s.NoError(err)
 		s.Equal(test.want, next)
 	}
diff --git a/internal/pipeline/pipeline.go b/internal/pipeline/pipeline.go
index a64edbc..78872ff 100644
--- a/internal/pipeline/pipeline.go
+++ b/internal/pipeline/pipeline.go
@@ -49,7 +49,7 @@ func (md *Pipeline) Run(ctx context.Context, blockNumber uint64) error {
 
 	for _, tx := range fetchResp.Data.Block.Transactions {
 		for _, filter := range md.filters {
-			next, err := filter.Execute(ctx, &tx)
+			next, err := filter.Execute(ctx, tx)
 			if err != nil {
 				return err
 			}