From f2d9154da0f3c38f668b38633fd6062e7cba4850 Mon Sep 17 00:00:00 2001 From: Mohammed Sohail Date: Mon, 16 Jan 2023 08:31:46 +0000 Subject: [PATCH] refactor: decode JSON io.Reader stream --- pkg/fetch/graphql.go | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/pkg/fetch/graphql.go b/pkg/fetch/graphql.go index 29d28e8..7440494 100644 --- a/pkg/fetch/graphql.go +++ b/pkg/fetch/graphql.go @@ -4,7 +4,6 @@ import ( "bytes" "context" "fmt" - "io" "net/http" "time" @@ -52,14 +51,9 @@ func (f *Graphql) Block(ctx context.Context, blockNumber uint64) (FetchResponse, if resp.StatusCode >= http.StatusBadRequest { return FetchResponse{}, fmt.Errorf("error fetching block %s", resp.Status) } + defer resp.Body.Close() - out, err := io.ReadAll(resp.Body) - _ = resp.Body.Close() - if err != nil { - return FetchResponse{}, nil - } - - if err := json.Unmarshal(out, &fetchResponse); err != nil { + if err := json.NewDecoder(resp.Body).Decode(&fetchResponse); err != nil { return FetchResponse{}, err }