From e597be41d5bf93daf607b87c2d566afec51315e3 Mon Sep 17 00:00:00 2001 From: Mohammed Sohail Date: Tue, 14 Dec 2021 17:55:50 +0300 Subject: [PATCH] docs: inline docs for batch call handler --- internal/server/handlers.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/internal/server/handlers.go b/internal/server/handlers.go index 7193618..514ed47 100644 --- a/internal/server/handlers.go +++ b/internal/server/handlers.go @@ -19,6 +19,7 @@ func batchCall() (bool, BatchResponse) { var batchResponse BatchResponse rpcResponses, err := RpcClient.EthBatchRpcCall(jsonrpc.RPCRequests{ + // The rpc call id here is guranteed to be in order of appearance starting from index 0 jsonrpc.NewRequest("eth_syncing"), jsonrpc.NewRequest("parity_chain"), }) @@ -31,11 +32,13 @@ func batchCall() (bool, BatchResponse) { return false, batchResponse } + // Order and format isn't guranteed with batch calls therefore we individually process/transform each result in the map if syncStatus, ok := rpcResponses[0]; ok { val, err := syncStatus.GetBool() if err != nil { return false, batchResponse } + // If sync is complete the rpc result is false, however this call dones't gurantee all blocks have been imported batchResponse.SyncComplete = !val }