From 076c8b9de761560b53793c8d562881d044a965c2 Mon Sep 17 00:00:00 2001
From: Jaco Greeff <jacogr@gmail.com>
Date: Fri, 27 Jan 2017 14:42:22 +0100
Subject: [PATCH] parity.js api.parity.chainStatus should handle { blockGap:
 null } (#4327)

* Add tests for null blockGap values

* Handle null blockGap values
---
 js/src/api/format/output.js         | 4 +++-
 js/src/api/format/output.spec.js    | 8 ++++++++
 js/src/api/rpc/parity/parity.e2e.js | 8 ++++++++
 3 files changed, 19 insertions(+), 1 deletion(-)

diff --git a/js/src/api/format/output.js b/js/src/api/format/output.js
index 9121dd612..35ec67ebf 100644
--- a/js/src/api/format/output.js
+++ b/js/src/api/format/output.js
@@ -79,7 +79,9 @@ export function outChainStatus (status) {
     Object.keys(status).forEach((key) => {
       switch (key) {
         case 'blockGap':
-          status[key] = status[key].map(outNumber);
+          status[key] = status[key]
+            ? status[key].map(outNumber)
+            : status[key];
           break;
       }
     });
diff --git a/js/src/api/format/output.spec.js b/js/src/api/format/output.spec.js
index b3dda1ff8..d744a642c 100644
--- a/js/src/api/format/output.spec.js
+++ b/js/src/api/format/output.spec.js
@@ -135,6 +135,14 @@ describe('api/format/output', () => {
         blockGap: [new BigNumber(0x1234), new BigNumber(0x5678)]
       });
     });
+
+    it('handles null blockGap values', () => {
+      const status = {
+        blockGap: null
+      };
+
+      expect(outChainStatus(status)).to.deep.equal(status);
+    });
   });
 
   describe('outDate', () => {
diff --git a/js/src/api/rpc/parity/parity.e2e.js b/js/src/api/rpc/parity/parity.e2e.js
index 1b274a004..8820d570a 100644
--- a/js/src/api/rpc/parity/parity.e2e.js
+++ b/js/src/api/rpc/parity/parity.e2e.js
@@ -19,6 +19,14 @@ import { createHttpApi } from '../../../../test/e2e/ethapi';
 describe('ethapi.parity', () => {
   const ethapi = createHttpApi();
 
+  describe('chainStatus', () => {
+    it('returns and translates the status', () => {
+      return ethapi.parity.chainStatus().then((value) => {
+        expect(value).to.be.ok;
+      });
+    });
+  });
+
   describe('gasFloorTarget', () => {
     it('returns and translates the target', () => {
       return ethapi.parity.gasFloorTarget().then((value) => {