grassrootseconomics/openethereum
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[EngineSigner]: don't sign message with only zeroes (#11524)

Browse Source 
* [EngineSigner]: don't sign message only zeroes

Fixes #11521, caused by switching to `upstream rust-secp256k1`

* address grumbles

* forgot formatting change
This commit is contained in:
Niklas Adolfsson
2020-02-27 12:22:11 +01:00
committed by GitHub
parent ec8dbb36e6
commit 11abf3ea2e
2 changed files with 25 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
rpc/src/v1/helpers/engine_signer.rs
View File

@@ -36,16 +36,14 @@ impl EngineSigner {
impl engine::signer::EngineSigner for EngineSigner {
fn sign(&self, message: Message) -> Result<Signature, Error> {
match self.accounts.sign(self.address, Some(self.password.clone()), message) {
Ok(ok) => Ok(ok),
Err(_) => Err(Error::InvalidSecretKey),
}
self.accounts.sign(self.address, Some(self.password.clone()), message).map_err(|e| {
Error::Custom(e.to_string())
})
}
fn decrypt(&self, auth_data: &[u8], cipher: &[u8]) -> Result<Vec<u8>, Error> {
self.accounts.decrypt(self.address, None, auth_data, cipher).map_err(|e| {
warn!("Unable to decrypt message: {:?}", e);
Error::InvalidMessage
Error::Custom(e.to_string())
})
}