diff --git a/rpc/src/v1/impls/personal.rs b/rpc/src/v1/impls/personal.rs
index 0cd3f0040..2822059d6 100644
--- a/rpc/src/v1/impls/personal.rs
+++ b/rpc/src/v1/impls/personal.rs
@@ -49,7 +49,7 @@ impl Personal for PersonalClient where A: AccountProvider + 'static {
|(pass, )| {
let store = take_weak!(self.accounts);
match store.new_account(&pass) {
- Ok(address) => Ok(Value::String(format!("{:?}", address))),
+ Ok(address) => Ok(Value::String(format!("0x{:?}", address))),
Err(_) => Err(Error::internal_error())
}
}
diff --git a/rpc/src/v1/tests/helpers/account_provider.rs b/rpc/src/v1/tests/helpers/account_provider.rs
index 66f085f74..ce5b76b44 100644
--- a/rpc/src/v1/tests/helpers/account_provider.rs
+++ b/rpc/src/v1/tests/helpers/account_provider.rs
@@ -42,6 +42,7 @@ impl TestAccount {
/// Test account provider.
pub struct TestAccountProvider {
accounts: RwLock>,
+ pub adds: RwLock>,
}
impl TestAccountProvider {
@@ -49,6 +50,7 @@ impl TestAccountProvider {
pub fn new(accounts: HashMap) -> Self {
TestAccountProvider {
accounts: RwLock::new(accounts),
+ adds: RwLock::new(vec![]),
}
}
}
@@ -69,9 +71,13 @@ impl AccountProvider for TestAccountProvider {
}
}
- fn new_account(&self, _pass: &str) -> Result {
- unimplemented!()
+ fn new_account(&self, pass: &str) -> Result {
+ let mut adds = self.adds.write().unwrap();
+ let address = Address::from(adds.len() as u64 + 2);
+ adds.push(pass.to_owned());
+ Ok(address)
}
+
fn account_secret(&self, _account: &Address) -> Result {
unimplemented!()
}
diff --git a/rpc/src/v1/tests/personal.rs b/rpc/src/v1/tests/personal.rs
index 440a95a6f..261527c47 100644
--- a/rpc/src/v1/tests/personal.rs
+++ b/rpc/src/v1/tests/personal.rs
@@ -45,3 +45,15 @@ fn accounts() {
assert_eq!(io.handle_request(request), Some(response.to_owned()));
}
+
+
+#[test]
+fn new_account() {
+ let (_test_provider, io) = setup();
+
+ let request = r#"{"jsonrpc": "2.0", "method": "personal_newAccount", "params": ["pass"], "id": 1}"#;
+ let response = r#"{"jsonrpc":"2.0","result":"0x0000000000000000000000000000000000000002","id":1}"#;
+
+ assert_eq!(io.handle_request(request), Some(response.to_owned()));
+}
+