Added checking tx-type using transactions permission contract for miners
This commit is contained in:
parent
25a3c001ad
commit
24378f3c44
@ -1840,6 +1840,8 @@ impl BlockChainClient for Client {
|
||||
}
|
||||
|
||||
impl MiningBlockChainClient for Client {
|
||||
fn as_block_chain_client(&self) -> &BlockChainClient { self }
|
||||
|
||||
fn latest_schedule(&self) -> Schedule {
|
||||
self.engine.schedule(self.latest_env_info().number)
|
||||
}
|
||||
|
@ -365,6 +365,8 @@ pub fn get_temp_state_db() -> GuardedTempResult<StateDB> {
|
||||
}
|
||||
|
||||
impl MiningBlockChainClient for TestBlockChainClient {
|
||||
fn as_block_chain_client(&self) -> &BlockChainClient { self }
|
||||
|
||||
fn latest_schedule(&self) -> Schedule {
|
||||
Schedule::new_post_eip150(24576, true, true, true)
|
||||
}
|
||||
|
@ -308,6 +308,9 @@ pub trait MiningBlockChainClient: BlockChainClient {
|
||||
|
||||
/// Returns latest schedule.
|
||||
fn latest_schedule(&self) -> Schedule;
|
||||
|
||||
/// Returns base of this trait
|
||||
fn as_block_chain_client(&self) -> &BlockChainClient;
|
||||
}
|
||||
|
||||
/// Client facilities used by internally sealing Engines.
|
||||
|
@ -411,6 +411,7 @@ impl Miner {
|
||||
};
|
||||
|
||||
let mut invalid_transactions = HashSet::new();
|
||||
let mut non_allowed_transactions = HashSet::new();
|
||||
let mut transactions_to_penalize = HashSet::new();
|
||||
let block_number = open_block.block().fields().header.number();
|
||||
|
||||
@ -419,7 +420,15 @@ impl Miner {
|
||||
for tx in transactions {
|
||||
let hash = tx.hash();
|
||||
let start = Instant::now();
|
||||
let result = open_block.push_transaction(tx, None);
|
||||
// Check whether transaction type is allowed for sender
|
||||
let result = match self.engine.machine().verify_transaction(&tx, open_block.header(), chain.as_block_chain_client()) {
|
||||
Err(Error::Transaction(TransactionError::NotAllowed)) => {
|
||||
Err(From::from(TransactionError::NotAllowed))
|
||||
}
|
||||
_ => {
|
||||
open_block.push_transaction(tx, None)
|
||||
}
|
||||
};
|
||||
let took = start.elapsed();
|
||||
|
||||
// Check for heavy transactions
|
||||
@ -460,6 +469,12 @@ impl Miner {
|
||||
},
|
||||
// already have transaction - ignore
|
||||
Err(Error::Transaction(TransactionError::AlreadyImported)) => {},
|
||||
Err(Error::Transaction(TransactionError::NotAllowed)) => {
|
||||
non_allowed_transactions.insert(hash);
|
||||
debug!(target: "miner",
|
||||
"Skipping non-allowed transaction for sender {:?}",
|
||||
hash);
|
||||
},
|
||||
Err(e) => {
|
||||
invalid_transactions.insert(hash);
|
||||
debug!(target: "miner",
|
||||
@ -482,6 +497,9 @@ impl Miner {
|
||||
for hash in invalid_transactions {
|
||||
queue.remove(&hash, &fetch_nonce, RemovalReason::Invalid);
|
||||
}
|
||||
for hash in non_allowed_transactions {
|
||||
queue.remove(&hash, &fetch_nonce, RemovalReason::NotAllowed);
|
||||
}
|
||||
for hash in transactions_to_penalize {
|
||||
queue.penalize(&hash);
|
||||
}
|
||||
|
@ -545,6 +545,8 @@ pub enum RemovalReason {
|
||||
Invalid,
|
||||
/// Transaction was canceled
|
||||
Canceled,
|
||||
/// Transaction is not allowed,
|
||||
NotAllowed,
|
||||
}
|
||||
|
||||
/// Point in time when transaction was inserted.
|
||||
@ -1014,6 +1016,9 @@ impl TransactionQueue {
|
||||
RemovalReason::Invalid => self.local_transactions.mark_invalid(
|
||||
transaction.transaction.into()
|
||||
),
|
||||
RemovalReason::NotAllowed => self.local_transactions.mark_invalid(
|
||||
transaction.transaction.into()
|
||||
),
|
||||
RemovalReason::Canceled => self.local_transactions.mark_canceled(
|
||||
PendingTransaction::new(transaction.transaction, transaction.condition)
|
||||
),
|
||||
|
Loading…
Reference in New Issue
Block a user