From 1fdb1de218e006995c6501b6bab12c929e64df0a Mon Sep 17 00:00:00 2001 From: Gav Wood Date: Tue, 31 May 2016 12:58:10 +0200 Subject: [PATCH 1/2] Don't implement the trait with unimplemented. --- rpc/src/v1/traits/ethcore.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rpc/src/v1/traits/ethcore.rs b/rpc/src/v1/traits/ethcore.rs index 00820db0a..abc87bbb8 100644 --- a/rpc/src/v1/traits/ethcore.rs +++ b/rpc/src/v1/traits/ethcore.rs @@ -73,7 +73,7 @@ pub trait Ethcore: Sized + Send + Sync + 'static { fn default_extra_data(&self, _: Params) -> Result; /// Executes the given call and returns the VM trace for it. - fn vm_trace_call(&self, _: Params) -> Result { rpc_unimplemented!() } + fn vm_trace_call(&self, _: Params) -> Result; /// Should be used to convert object to io delegate. fn to_delegate(self) -> IoDelegate { From 12547ecd37a0e5b159f12c5ad78f85c34ace196b Mon Sep 17 00:00:00 2001 From: Gav Wood Date: Tue, 31 May 2016 12:58:47 +0200 Subject: [PATCH 2/2] Remove invlaid comment. --- rpc/src/v1/types/transaction.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/rpc/src/v1/types/transaction.rs b/rpc/src/v1/types/transaction.rs index e9d4e4cb9..6a9f0e590 100644 --- a/rpc/src/v1/types/transaction.rs +++ b/rpc/src/v1/types/transaction.rs @@ -111,7 +111,6 @@ mod tests { fn test_transaction_serialize() { let t = Transaction::default(); let serialized = serde_json::to_string(&t).unwrap(); - // TODO: fix create. assert_eq!(serialized, r#"{"hash":"0x0000000000000000000000000000000000000000000000000000000000000000","nonce":"0x00","blockHash":null,"blockNumber":null,"transactionIndex":null,"from":"0x0000000000000000000000000000000000000000","to":null,"value":"0x00","gasPrice":"0x00","gas":"0x00","input":"0x","creates":null}"#); } }