grassrootseconomics/openethereum
5
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

removed some TODOs

Browse Source
This commit is contained in:
Svyatoslav Nikolsky 2017-11-20 18:53:08 +03:00
parent 01d6532875
commit 32edb33608
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
secret_store/src/listener/service_contract_listener.rs
View File

@ -152,8 +152,6 @@ impl ServiceContractListener {
fn process_service_contract_events(&self, client: &Client, service_contract: Address, blocks: Vec<H256>) { fn process_service_contract_events(&self, client: &Client, service_contract: Address, blocks: Vec<H256>) {
debug_assert!(!blocks.is_empty()); debug_assert!(!blocks.is_empty());
// TODO: is blocks guaranteed to be ordered here?
// TODO: logs() is called from notify() thread - is it ok (doesn't 'logs')?
// read server key generation requests // read server key generation requests
let request_logs = client.logs(Filter { let request_logs = client.logs(Filter {
from_block: BlockId::Hash(blocks.first().expect("!block.is_empty(); qed").clone()), from_block: BlockId::Hash(blocks.first().expect("!block.is_empty(); qed").clone()),
@ -296,14 +294,13 @@ impl ServiceContractListener {
return Err(format!("invalid threshold {:?}", threshold)); return Err(format!("invalid threshold {:?}", threshold));
} }
// TODO: check if key is already generated // key server expects signed server_key_id in server_key_generation procedure
// TODO: if this server key is going to be used for document key generation later, author must // only signer could store document key for this server key later
// be specified from outside // => this API (server key generation) is not suitable for usage in encryption via contract endpoint
let author_key = Random.generate().map_err(|e| format!("{}", e))?; let author_key = Random.generate().map_err(|e| format!("{}", e))?;
let server_key_id_signature = sign(author_key.secret(), server_key_id).map_err(|e| format!("{}", e))?; let server_key_id_signature = sign(author_key.secret(), server_key_id).map_err(|e| format!("{}", e))?;
data.key_server.generate_key(server_key_id, &server_key_id_signature, threshold_num as usize) data.key_server.generate_key(server_key_id, &server_key_id_signature, threshold_num as usize)
.map_err(Into::into) .map_err(Into::into)
} }
fn publish_server_key(data: &Arc<ServiceContractListenerData>, server_key_id: &ServerKeyId, server_key: &Public) -> Result<(), String> { fn publish_server_key(data: &Arc<ServiceContractListenerData>, server_key_id: &ServerKeyId, server_key: &Public) -> Result<(), String> {