Extract blockchain from ethcore (#10114)

* Split blockchain & db from ethcore.

* Clean up blockchain deps.

* Missing docs.

* Fix blockchain tests.

* Make other crates compile.

* Remove some re-exports.

* Remove types re-export from ethcore.

* Remove EVM dependency from transaction.

* Merge ethcore-transaction with common-types.

* Clean-up ethcore deps a bit.

* remove ethcore from cargo.toml

* Update ethcore/blockchain/src/lib.rs

Co-Authored-By: tomusdrw <tomusdrw@users.noreply.github.com>

* Address review comments.

* Update DB comment.

* Add tracking issue to the TODO and fix typo.

* Common naming for common types.

* Update ethcore/db/src/keys.rs

Co-Authored-By: tomusdrw <tomusdrw@users.noreply.github.com>

* Update ethcore/blockchain/src/generator.rs

Co-Authored-By: tomusdrw <tomusdrw@users.noreply.github.com>

* Try to fix beta tests.

ethcore/src/tests/blockchain.rs

@@ -0,0 +1,61 @@
+// Copyright 2015-2018 Parity Technologies (UK) Ltd.
+// This file is part of Parity.
+
+// Parity is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// Parity is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with Parity.  If not, see <http://www.gnu.org/licenses/>.
+
+use blockchain::BlockProvider;
+
+use test_helpers::{
+	generate_dummy_blockchain,
+	generate_dummy_blockchain_with_extra,
+	generate_dummy_empty_blockchain,
+};
+
+#[test]
+fn can_contain_arbitrary_block_sequence() {
+	let bc = generate_dummy_blockchain(50);
+	assert_eq!(bc.best_block_number(), 49);
+}
+
+#[test]
+fn can_collect_garbage() {
+	let bc = generate_dummy_blockchain(3000);
+
+	assert_eq!(bc.best_block_number(), 2999);
+	let best_hash = bc.best_block_hash();
+	let mut block_header = bc.block_header_data(&best_hash);
+
+	while !block_header.is_none() {
+		block_header = bc.block_header_data(&block_header.unwrap().parent_hash());
+	}
+	assert!(bc.cache_size().blocks > 1024 * 1024);
+
+	for _ in 0..2 {
+		bc.collect_garbage();
+	}
+	assert!(bc.cache_size().blocks < 1024 * 1024);
+}
+
+#[test]
+fn can_contain_arbitrary_block_sequence_with_extra() {
+	let bc = generate_dummy_blockchain_with_extra(25);
+	assert_eq!(bc.best_block_number(), 24);
+}
+
+#[test]
+fn can_contain_only_genesis_block() {
+	let bc = generate_dummy_empty_blockchain();
+	assert_eq!(bc.best_block_number(), 0);
+}
+

ethcore/src/tests/client.rs

@@ -16,27 +16,29 @@
 
 use std::str::FromStr;
 use std::sync::Arc;
+
+use ethereum_types::{U256, Address};
+use ethkey::KeyPair;
 use hash::keccak;
 use io::IoChannel;
-use client::{BlockChainClient, Client, ClientConfig, BlockId, ChainInfo, BlockInfo, PrepareOpenBlock, ImportSealedBlock, ImportBlock};
-use state::{self, State, CleanupMode};
-use executive::{Executive, TransactOptions};
-use ethereum;
+use tempdir::TempDir;
+use types::transaction::{PendingTransaction, Transaction, Action, Condition};
+use types::filter::Filter;
+use types::view;
+use types::views::BlockView;
+
 use block::IsBlock;
+use client::{BlockChainClient, Client, ClientConfig, BlockId, ChainInfo, BlockInfo, PrepareOpenBlock, ImportSealedBlock, ImportBlock};
+use ethereum;
+use executive::{Executive, TransactOptions};
+use miner::{Miner, PendingOrdering, MinerService};
+use spec::Spec;
+use state::{self, State, CleanupMode};
 use test_helpers::{
+	self,
 	generate_dummy_client, push_blocks_to_client, get_test_client_with_blocks, get_good_dummy_block_seq,
 	generate_dummy_client_with_data, get_good_dummy_block, get_bad_state_dummy_block
 };
-use types::filter::Filter;
-use ethereum_types::{U256, Address};
-use miner::{Miner, PendingOrdering};
-use spec::Spec;
-use views::BlockView;
-use ethkey::KeyPair;
-use transaction::{PendingTransaction, Transaction, Action, Condition};
-use miner::MinerService;
-use tempdir::TempDir;
-use test_helpers;
 use verification::queue::kind::blocks::Unverified;
 
 #[test]

ethcore/src/tests/evm.rs

@@ -24,7 +24,7 @@ use executive::Executive;
 use state::Substate;
 use test_helpers::get_temp_state_with_factory;
 use trace::{NoopVMTracer, NoopTracer};
-use transaction::SYSTEM_ADDRESS;
+use types::transaction::SYSTEM_ADDRESS;
 
 use rustc_hex::FromHex;
 

ethcore/src/tests/mod.rs

@@ -15,5 +15,6 @@
 // along with Parity.  If not, see <http://www.gnu.org/licenses/>.
 
 mod client;
+mod blockchain;
 mod evm;
 mod trace;

ethcore/src/tests/trace.rs

@@ -26,14 +26,15 @@ use client::*;
 use test_helpers::get_temp_state_db;
 use client::{BlockChainClient, Client, ClientConfig};
 use std::sync::Arc;
-use header::Header;
 use miner::Miner;
-use transaction::{Action, Transaction};
-use views::BlockView;
+use types::transaction::{Action, Transaction};
 use trace::{RewardType, LocalizedTrace};
 use trace::trace::Action::Reward;
 use test_helpers;
 use verification::queue::kind::blocks::Unverified;
+use types::header::Header;
+use types::view;
+use types::views::BlockView;
 
 #[test]
 fn can_trace_block_and_uncle_reward() {