From 66692bc0e2fd2520f8de4cef6cdd632e0464bba0 Mon Sep 17 00:00:00 2001
From: Robert Habermeier <rphmeier@gmail.com>
Date: Mon, 6 Feb 2017 18:28:13 +0100
Subject: [PATCH] fast paths for block and receipts on_demand

---
 ethcore/light/src/on_demand/mod.rs     | 26 +++++++++++++++++++++++---
 ethcore/light/src/on_demand/request.rs |  9 +++++++++
 2 files changed, 32 insertions(+), 3 deletions(-)

diff --git a/ethcore/light/src/on_demand/mod.rs b/ethcore/light/src/on_demand/mod.rs
index 10be00dd7..6d2f02da6 100644
--- a/ethcore/light/src/on_demand/mod.rs
+++ b/ethcore/light/src/on_demand/mod.rs
@@ -27,9 +27,11 @@ use ethcore::receipt::Receipt;
 use futures::{Async, Poll, Future};
 use futures::sync::oneshot;
 use network::PeerId;
+use rlp::{RlpStream, Stream};
+use util::{Bytes, RwLock, U256};
+use util::sha3::{SHA3_NULL_RLP, SHA3_EMPTY_LIST_RLP};
 
 use net::{Handler, Status, Capabilities, Announcement, EventContext, BasicContext, ReqId};
-use util::{Bytes, RwLock, U256};
 use types::les_request::{self as les_request, Request as LesRequest};
 
 pub mod request;
@@ -209,7 +211,18 @@ impl OnDemand {
 	/// -- this just doesn't obscure the network query.
 	pub fn block(&self, ctx: &BasicContext, req: request::Body) -> Response<encoded::Block> {
 		let (sender, receiver) = oneshot::channel();
-		self.dispatch_block(ctx, req, sender);
+
+		// fast path for empty body.
+		if req.header.transactions_root() == SHA3_NULL_RLP && req.header.uncles_hash() == SHA3_EMPTY_LIST_RLP {
+			let mut stream = RlpStream::new_list(3);
+			stream.append_raw(&req.header.into_inner(), 1);
+			stream.begin_list(0);
+			stream.begin_list(0);
+
+			sender.complete(Ok(encoded::Block::new(stream.out())))
+		} else {
+			self.dispatch_block(ctx, req, sender);
+		}
 		Response(receiver)
 	}
 
@@ -246,7 +259,14 @@ impl OnDemand {
 	/// provide the block hash to fetch receipts for, and for verification of the receipts root.
 	pub fn block_receipts(&self, ctx: &BasicContext, req: request::BlockReceipts) -> Response<Vec<Receipt>> {
 		let (sender, receiver) = oneshot::channel();
-		self.dispatch_block_receipts(ctx, req, sender);
+
+		// fast path for empty receipts.
+		if req.0.receipts_root() == SHA3_NULL_RLP {
+			sender.complete(Ok(Vec::new()))
+		} else {
+			self.dispatch_block_receipts(ctx, req, sender);
+		}
+
 		Response(receiver)
 	}
 
diff --git a/ethcore/light/src/on_demand/request.rs b/ethcore/light/src/on_demand/request.rs
index 90d6801c8..23a4946a2 100644
--- a/ethcore/light/src/on_demand/request.rs
+++ b/ethcore/light/src/on_demand/request.rs
@@ -106,6 +106,15 @@ pub struct Body {
 }
 
 impl Body {
+	/// Create a request for a block body from a given header.
+	pub fn new(header: encoded::Header) -> Self {
+		let hash = header.hash();
+		Body {
+			header: header,
+			hash: hash,
+		}
+	}
+
 	/// Check a response for this block body.
 	pub fn check_response(&self, body: &[u8]) -> Result<encoded::Block, Error> {
 		let body_view = UntrustedRlp::new(&body);