diff --git a/parity/main.rs b/parity/main.rs index 8ee9c6f63..287392d4e 100644 --- a/parity/main.rs +++ b/parity/main.rs @@ -104,7 +104,8 @@ Protocol Options: --identity NAME Specify your node's name. Account Options: - --unlock ACCOUNT Unlock ACCOUNT for the duration of the execution. + --unlock ACCOUNTS Unlock ACCOUNTS for the duration of the execution. + ACCOUNTS is a comma-delimited list of addresses. --password FILE Provide a file containing a password for unlocking an account. @@ -213,7 +214,7 @@ struct Args { flag_chain: String, flag_db_path: String, flag_identity: String, - flag_unlock: Vec, + flag_unlock: Option, flag_password: Vec, flag_cache: Option, flag_keys_path: String, @@ -617,14 +618,15 @@ impl Configuration { .collect::>() .into_iter() }).collect::>(); - let account_service = AccountService::new_in(Path::new(&self.keys_path())); - for d in &self.args.flag_unlock { - let a = Address::from_str(clean_0x(&d)).unwrap_or_else(|_| { - die!("{}: Invalid address for --unlock. Must be 40 hex characters, without the 0x at the beginning.", d) - }); - if passwords.iter().find(|p| account_service.unlock_account_no_expire(&a, p).is_ok()).is_none() { - die!("No password given to unlock account {}. Pass the password using `--password`.", a); + if let Some(ref unlocks) = self.args.flag_unlock { + for d in unlocks.split(',') { + let a = Address::from_str(clean_0x(&d)).unwrap_or_else(|_| { + die!("{}: Invalid address for --unlock. Must be 40 hex characters, without the 0x at the beginning.", d) + }); + if passwords.iter().find(|p| account_service.unlock_account_no_expire(&a, p).is_ok()).is_none() { + die!("No password given to unlock account {}. Pass the password using `--password`.", a); + } } } account_service diff --git a/rpc/src/v1/impls/eth.rs b/rpc/src/v1/impls/eth.rs index 861b7c5ac..1d973f933 100644 --- a/rpc/src/v1/impls/eth.rs +++ b/rpc/src/v1/impls/eth.rs @@ -465,7 +465,7 @@ impl Eth for EthClient fn submit_work(&self, params: Params) -> Result { from_params::<(H64, H256, H256)>(params).and_then(|(nonce, pow_hash, mix_hash)| { -// trace!("Decoded: nonce={}, pow_hash={}, mix_hash={}", nonce, pow_hash, mix_hash); + trace!(target: "miner", "submit_work: Decoded: nonce={}, pow_hash={}, mix_hash={}", nonce, pow_hash, mix_hash); let miner = take_weak!(self.miner); let client = take_weak!(self.client); let seal = vec![encode(&mix_hash).to_vec(), encode(&nonce).to_vec()]; @@ -671,9 +671,6 @@ impl EthFilter for EthFilterClient _ => Ok(Value::Array(vec![] as Vec)), } }) - - - } fn uninstall_filter(&self, params: Params) -> Result {