Light clippy(fy) (#9473)

* wasm tests

* `clippyfy` light-client

* Revert inefficient change `collect_ready()`

ethcore/light/src/on_demand/mod.rs

@@ -69,8 +69,8 @@ impl Peer {
 		};
 
 		local_caps.serve_headers >= request.serve_headers &&
-		    can_serve_since(request.serve_chain_since, local_caps.serve_chain_since) &&
-		    can_serve_since(request.serve_state_since, local_caps.serve_state_since)
+			can_serve_since(request.serve_chain_since, local_caps.serve_chain_since) &&
+			can_serve_since(request.serve_state_since, local_caps.serve_state_since)
 	}
 }
 
@@ -111,19 +111,16 @@ impl Pending {
 	// verification.
 	// `idx` is the index of the request the response corresponds to.
 	fn update_header_refs(&mut self, idx: usize, response: &Response) {
-		match *response {
-			Response::HeaderByHash(ref hdr) => {
+		if let Response::HeaderByHash(ref hdr) = *response {
 				// fill the header for all requests waiting on this one.
 				// TODO: could be faster if we stored a map usize => Vec<usize>
 				// but typical use just has one header request that others
 				// depend on.
-				for r in self.requests.iter_mut().skip(idx + 1) {
-					if r.needs_header().map_or(false, |(i, _)| i == idx) {
-						r.provide_header(hdr.clone())
-					}
+			for r in self.requests.iter_mut().skip(idx + 1) {
+				if r.needs_header().map_or(false, |(i, _)| i == idx) {
+					r.provide_header(hdr.clone())
 				}
 			}
-			_ => {}, // no other responses produce headers.
 		}
 	}
 
@@ -265,7 +262,7 @@ impl OnDemand {
 			pending: RwLock::new(Vec::new()),
 			peers: RwLock::new(HashMap::new()),
 			in_transit: RwLock::new(HashMap::new()),
-			cache: cache,
+			cache,
 			no_immediate_dispatch: false,
 		}
 	}
@@ -312,7 +309,7 @@ impl OnDemand {
 				}
 			}
 			if let CheckedRequest::HeaderByHash(ref req, _) = request {
-				header_producers.insert(i, req.0.clone());
+				header_producers.insert(i, req.0);
 			}
 
 			builder.push(request)?;
@@ -323,11 +320,11 @@ impl OnDemand {
 		let capabilities = guess_capabilities(requests.requests());
 
 		self.submit_pending(ctx, Pending {
-			requests: requests,
-			net_requests: net_requests,
+			requests,
+			net_requests,
 			required_capabilities: capabilities,
-			responses: responses,
-			sender: sender,
+			responses,
+			sender,
 		});
 
 		Ok(receiver)