grassrootseconomics/openethereum
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add deprecation warnings (#11682)

Browse Source
This commit is contained in:
Artem Vorotnikov 2020-05-11 14:51:05 +03:00 committed by GitHub
parent fdf5f671cf
commit 7875b786be
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
parity/run.rs
View File

@ -46,7 +46,7 @@ use types::{
use parity_rpc::{ use parity_rpc::{
Origin, Metadata, NetworkSettings, informant, PubSubSession, FutureResult, FutureResponse, FutureOutput Origin, Metadata, NetworkSettings, informant, PubSubSession, FutureResult, FutureResponse, FutureOutput
}; };
use updater::{UpdatePolicy, Updater}; use updater::{UpdateFilter, UpdatePolicy, Updater};
use parity_version::version; use parity_version::version;
use ethcore_private_tx::{ProviderConfig, EncryptorConfig, SecretStoreEncryptor}; use ethcore_private_tx::{ProviderConfig, EncryptorConfig, SecretStoreEncryptor};
use params::{ use params::{
@ -639,10 +639,14 @@ fn execute_impl<Cr, Rr>(
.map_err(|e| format!("Stratum start error: {:?}", e))?; .map_err(|e| format!("Stratum start error: {:?}", e))?;
} }
let (private_tx_sync, private_state) = match cmd.private_tx_enabled { let mut private_tx_sync = None;
true => (Some(private_tx_service.clone() as Arc<dyn PrivateTxHandler>), Some(private_tx_provider.private_state_db())), let mut private_state = None;
false => (None, None),
}; if cmd.private_tx_enabled {
warn!("Private transactions support is deprecated and may be removed in a future release. e. Please see #11695 for details:\nhttps://github.com/openethereum/openethereum/issues/11695");
private_tx_sync = Some(private_tx_service.clone() as Arc<dyn PrivateTxHandler>);
private_state = Some(private_tx_provider.private_state_db());
}
// create sync object // create sync object
let (sync_provider, manage_network, chain_notify, priority_tasks) = modules::sync( let (sync_provider, manage_network, chain_notify, priority_tasks) = modules::sync(
@ -699,6 +703,10 @@ fn execute_impl<Cr, Rr>(
); );
// the updater service // the updater service
if update_policy.filter != UpdateFilter::None {
warn!("Updater is deprecated and may be removed in a future release. e. Please see #11696 for details:\nhttps://github.com/openethereum/openethereum/issues/11696");
}
let updater = Updater::new( let updater = Updater::new(
&Arc::downgrade(&(service.client() as Arc<dyn BlockChainClient>)), &Arc::downgrade(&(service.client() as Arc<dyn BlockChainClient>)),
&Arc::downgrade(&sync_provider), &Arc::downgrade(&sync_provider),
@ -925,6 +933,7 @@ pub fn execute<Cr, Rr>(
Rr: Fn() + 'static + Send Rr: Fn() + 'static + Send
{ {
if cmd.light { if cmd.light {
warn!("Light client is deprecated and may be removed in a future release. Please see #11681 for details:\nhttps://github.com/openethereum/openethereum/issues/11681");
execute_light_impl(cmd, logger, on_client_rq) execute_light_impl(cmd, logger, on_client_rq)
} else { } else {
execute_impl(cmd, logger, on_client_rq, on_updater_rq) execute_impl(cmd, logger, on_client_rq, on_updater_rq)