grassrootseconomics/openethereum
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[beta] Fix ethsign (#5600)

Browse Source 
* Fix ethsign in beta.

* Fix tests.

* Fix compilation.

* CI fix

remove kcov
This commit is contained in:
Tomasz Drwięga
2017-05-18 14:50:17 +02:00
committed by Gav Wood
parent 4d9f13196f
commit 8dfc10ede9
14 changed files with 54 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
rpc/src/v1/helpers/dispatch.rs
View File

@@ -458,13 +458,10 @@ pub fn execute<D: Dispatcher + 'static>(
message_data.append(&mut data);
let res = signature(&accounts, address, message_data.sha3(), pass)
.map(|result| result
.map(|rsv| {
let mut vrs = [0u8; 65];
let rsv = rsv.as_ref();
vrs[0] = rsv[64] + 27;
vrs[1..33].copy_from_slice(&rsv[0..32]);
vrs[33..65].copy_from_slice(&rsv[32..64]);
H520(vrs)
.map(|mut rsv| {
// Convert to electrum notation.
rsv[64] += 27;
H520(rsv.into())
})
.map(RpcH520::from)
.map(ConfirmationResponse::Signature)

2
rpc/src/v1/tests/mocked/eth.rs
View File

@@ -314,7 +314,7 @@ fn rpc_eth_sign() {
],
"id": 1
}"#;
let res = r#"{"jsonrpc":"2.0","result":"0x1ba2870db1d0c26ef93c7b72d2a0830fa6b841e0593f7186bc6c7cc317af8cf3a42fda03bd589a49949aa05db83300cdb553116274518dbe9d90c65d0213f4af49","id":1}"#;
let res = r#"{"jsonrpc":"2.0","result":"0xa2870db1d0c26ef93c7b72d2a0830fa6b841e0593f7186bc6c7cc317af8cf3a42fda03bd589a49949aa05db83300cdb553116274518dbe9d90c65d0213f4af491b","id":1}"#;
assert_eq!(tester.io.handle_request_sync(&req), Some(res.into()));
}

2
rpc/src/v1/tests/mocked/signing.rs
View File

@@ -212,7 +212,7 @@ fn should_sign_if_account_is_unlocked() {
],
"id": 1
}"#;
let response = r#"{"jsonrpc":"2.0","result":"0x1bdb53b32e56cf3e9735377b7664d6de5a03e125b1bf8ec55715d253668b4238503b4ac931fe6af90add73e72a585e952665376b2b9afc5b6b239b7df74c734e12","id":1}"#;
let response = r#"{"jsonrpc":"2.0","result":"0xdb53b32e56cf3e9735377b7664d6de5a03e125b1bf8ec55715d253668b4238503b4ac931fe6af90add73e72a585e952665376b2b9afc5b6b239b7df74c734e121b","id":1}"#;
assert_eq!(tester.io.handle_request_sync(&request), Some(response.to_owned()));
assert_eq!(tester.signer.requests().len(), 0);
}