Visible accounts for dapps (default whitelist) (#3898)

* Add APIs for Dapp management

* Move AddDapps modal

* Add DappsPermissions Modal (basics)

* Allow whitelist editing

* Add select/unselect tests

* Case

* Case

* Modal render/non-render tests

* UI made slightly prettier

* Adjust spacing

* Allow get/set of null for default whitelist (all)

* Allow null = all for selection

* Adjust selected background

* Address valid comment on formatters location

js/src/modals/AddDapps/addDapps.css

@@ -0,0 +1,39 @@
+/* Copyright 2015, 2016 Parity Technologies (UK) Ltd.
+/* This file is part of Parity.
+/*
+/* Parity is free software: you can redistribute it and/or modify
+/* it under the terms of the GNU General Public License as published by
+/* the Free Software Foundation, either version 3 of the License, or
+/* (at your option) any later version.
+/*
+/* Parity is distributed in the hope that it will be useful,
+/* but WITHOUT ANY WARRANTY; without even the implied warranty of
+/* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+/* GNU General Public License for more details.
+/*
+/* You should have received a copy of the GNU General Public License
+/* along with Parity.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+.description {
+  margin-top: .5em !important;
+}
+
+.list {
+  .background {
+    background: rgba(255, 255, 255, 0.2);
+    margin: 0 -1.5em;
+    padding: 0.5em 1.5em;
+  }
+
+  .header {
+    text-transform: uppercase;
+  }
+
+  .byline {
+    font-size: 0.75em;
+    padding-top: 0.5em;
+    line-height: 1.5em;
+    opacity: 0.75;
+  }
+}

js/src/modals/AddDapps/addDapps.js

@@ -0,0 +1,144 @@
+// Copyright 2015, 2016 Parity Technologies (UK) Ltd.
+// This file is part of Parity.
+
+// Parity is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// Parity is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with Parity.  If not, see <http://www.gnu.org/licenses/>.
+
+import { Checkbox } from 'material-ui';
+import { List, ListItem } from 'material-ui/List';
+import { observer } from 'mobx-react';
+import React, { Component, PropTypes } from 'react';
+import { FormattedMessage } from 'react-intl';
+
+import { Modal, Button } from '~/ui';
+import { DoneIcon } from '~/ui/Icons';
+
+import styles from './addDapps.css';
+
+@observer
+export default class AddDapps extends Component {
+  static propTypes = {
+    store: PropTypes.object.isRequired
+  };
+
+  render () {
+    const { store } = this.props;
+
+    if (!store.modalOpen) {
+      return null;
+    }
+
+    return (
+      <Modal
+        actions={ [
+          <Button
+            icon={ <DoneIcon /> }
+            key='done'
+            label={
+              <FormattedMessage
+                id='dapps.add.button.done'
+                defaultMessage='Done' />
+            }
+            onClick={ store.closeModal } />
+        ] }
+        compact
+        title={
+          <FormattedMessage
+            id='dapps.add.label'
+            defaultMessage='visible applications' />
+        }
+        visible>
+        <div className={ styles.warning } />
+        {
+          this.renderList(store.sortedLocal,
+            <FormattedMessage
+              id='dapps.add.local.label'
+              defaultMessage='Applications locally available' />,
+            <FormattedMessage
+              id='dapps.add.local.desc'
+              defaultMessage='All applications installed locally on the machine by the user for access by the Parity client.' />
+          )
+        }
+        {
+          this.renderList(store.sortedBuiltin,
+            <FormattedMessage
+              id='dapps.add.builtin.label'
+              defaultMessage='Applications bundled with Parity' />,
+            <FormattedMessage
+              id='dapps.add.builtin.desc'
+              defaultMessage='Experimental applications developed by the Parity team to show off dapp capabilities, integration, experimental features and to control certain network-wide client behaviour.' />
+          )
+        }
+        {
+          this.renderList(store.sortedNetwork,
+            <FormattedMessage
+              id='dapps.add.network.label'
+              defaultMessage='Applications on the global network' />,
+            <FormattedMessage
+              id='dapps.add.network.desc'
+              defaultMessage='These applications are not affiliated with Parity nor are they published by Parity. Each remain under the control of their respective authors. Please ensure that you understand the goals for each application before interacting.' />
+          )
+        }
+      </Modal>
+    );
+  }
+
+  renderList (items, header, byline) {
+    if (!items || !items.length) {
+      return null;
+    }
+
+    return (
+      <div className={ styles.list }>
+        <div className={ styles.background }>
+          <div className={ styles.header }>{ header }</div>
+          <div className={ styles.byline }>{ byline }</div>
+        </div>
+        <List>
+          { items.map(this.renderApp) }
+        </List>
+      </div>
+    );
+  }
+
+  renderApp = (app) => {
+    const { store } = this.props;
+    const isHidden = !store.displayApps[app.id].visible;
+
+    const onCheck = () => {
+      if (isHidden) {
+        store.showApp(app.id);
+      } else {
+        store.hideApp(app.id);
+      }
+    };
+
+    return (
+      <ListItem
+        key={ app.id }
+        leftCheckbox={
+          <Checkbox
+            checked={ !isHidden }
+            onCheck={ onCheck }
+          />
+        }
+        primaryText={ app.name }
+        secondaryText={
+          <div className={ styles.description }>
+            { app.description }
+          </div>
+        }
+      />
+    );
+  }
+}

js/src/modals/AddDapps/addDapps.spec.js

@@ -0,0 +1,46 @@
+// Copyright 2015, 2016 Parity Technologies (UK) Ltd.
+// This file is part of Parity.
+
+// Parity is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// Parity is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with Parity.  If not, see <http://www.gnu.org/licenses/>.
+
+import { shallow } from 'enzyme';
+import React from 'react';
+
+import AddDapps from './';
+
+function renderShallow (store = {}) {
+  return shallow(
+    <AddDapps store={ store } />
+  );
+}
+
+describe('modals/AddDapps', () => {
+  describe('rendering', () => {
+    it('renders defaults', () => {
+      expect(renderShallow()).to.be.ok;
+    });
+
+    it('does not render the modal with modalOpen = false', () => {
+      expect(
+        renderShallow({ modalOpen: false }).find('Connect(Modal)')
+      ).to.have.length(0);
+    });
+
+    it('does render the modal with modalOpen = true', () => {
+      expect(
+        renderShallow({ modalOpen: true }).find('Connect(Modal)')
+      ).to.have.length(1);
+    });
+  });
+});

js/src/modals/AddDapps/index.js

@@ -0,0 +1,17 @@
+// Copyright 2015, 2016 Parity Technologies (UK) Ltd.
+// This file is part of Parity.
+
+// Parity is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// Parity is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with Parity.  If not, see <http://www.gnu.org/licenses/>.
+
+export default from './addDapps';

js/src/modals/DappPermissions/dappPermissions.css

@@ -0,0 +1,47 @@
+/* Copyright 2015, 2016 Parity Technologies (UK) Ltd.
+/* This file is part of Parity.
+/*
+/* Parity is free software: you can redistribute it and/or modify
+/* it under the terms of the GNU General Public License as published by
+/* the Free Software Foundation, either version 3 of the License, or
+/* (at your option) any later version.
+/*
+/* Parity is distributed in the hope that it will be useful,
+/* but WITHOUT ANY WARRANTY; without even the implied warranty of
+/* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+/* GNU General Public License for more details.
+/*
+/* You should have received a copy of the GNU General Public License
+/* along with Parity.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+.item {
+  .info {
+    display: inline-block;
+
+    .address {
+      opacity: 0.75;
+    }
+
+    .description {
+      margin-top: 0.5em;
+      opacity: 0.75;
+    }
+
+    .name {
+      margin: 0.5em 0;
+      text-transform: uppercase;
+    }
+  }
+}
+
+.selected, .unselected {
+  margin-bottom: 0.25em;
+}
+
+.selected {
+  background: rgba(255, 255, 255, 0.15);
+}
+
+.unselected {
+}

js/src/modals/DappPermissions/dappPermissions.js

@@ -0,0 +1,112 @@
+// Copyright 2015, 2016 Parity Technologies (UK) Ltd.
+// This file is part of Parity.
+
+// Parity is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// Parity is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with Parity.  If not, see <http://www.gnu.org/licenses/>.
+
+import { Checkbox } from 'material-ui';
+import { List, ListItem } from 'material-ui/List';
+import { observer } from 'mobx-react';
+import React, { Component, PropTypes } from 'react';
+import { FormattedMessage } from 'react-intl';
+
+import { Button, IdentityIcon, Modal } from '~/ui';
+import { DoneIcon } from '~/ui/Icons';
+
+import styles from './dappPermissions.css';
+
+@observer
+export default class DappPermissions extends Component {
+  static propTypes = {
+    store: PropTypes.object.isRequired
+  };
+
+  render () {
+    const { store } = this.props;
+
+    if (!store.modalOpen) {
+      return null;
+    }
+
+    return (
+      <Modal
+        actions={ [
+          <Button
+            icon={ <DoneIcon /> }
+            key='done'
+            label={
+              <FormattedMessage
+                id='dapps.permissions.button.done'
+                defaultMessage='Done' />
+            }
+            onClick={ store.closeModal } />
+        ] }
+        compact
+        title={
+          <FormattedMessage
+            id='dapps.permissions.label'
+            defaultMessage='visible dapp accounts' />
+        }
+        visible>
+        <List>
+          { this.renderListItems() }
+        </List>
+      </Modal>
+    );
+  }
+
+  renderListItems () {
+    const { store } = this.props;
+
+    return store.accounts.map((account) => {
+      const onCheck = () => {
+        store.selectAccount(account.address);
+      };
+
+      // TODO: Once new modal & account selection is in, this should be updated
+      // to conform to the new (as of this code WIP) look & feel for selection.
+      // For now in the current/old style, not as pretty but consistent.
+      return (
+        <ListItem
+          className={
+            account.checked
+              ? styles.selected
+              : styles.unselected
+          }
+          key={ account.address }
+          leftCheckbox={
+            <Checkbox
+              checked={ account.checked }
+              onCheck={ onCheck }
+            />
+          }
+          primaryText={
+            <div className={ styles.item }>
+              <IdentityIcon address={ account.address } />
+              <div className={ styles.info }>
+                <h3 className={ styles.name }>
+                  { account.name }
+                </h3>
+                <div className={ styles.address }>
+                  { account.address }
+                </div>
+                <div className={ styles.description }>
+                  { account.description }
+                </div>
+              </div>
+            </div>
+          } />
+      );
+    });
+  }
+}

js/src/modals/DappPermissions/dappPermissions.spec.js

@@ -0,0 +1,46 @@
+// Copyright 2015, 2016 Parity Technologies (UK) Ltd.
+// This file is part of Parity.
+
+// Parity is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// Parity is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with Parity.  If not, see <http://www.gnu.org/licenses/>.
+
+import { shallow } from 'enzyme';
+import React from 'react';
+
+import DappPermissions from './';
+
+function renderShallow (store = {}) {
+  return shallow(
+    <DappPermissions store={ store } />
+  );
+}
+
+describe('modals/DappPermissions', () => {
+  describe('rendering', () => {
+    it('renders defaults', () => {
+      expect(renderShallow()).to.be.ok;
+    });
+
+    it('does not render the modal with modalOpen = false', () => {
+      expect(
+        renderShallow({ modalOpen: false }).find('Connect(Modal)')
+      ).to.have.length(0);
+    });
+
+    it('does render the modal with modalOpen = true', () => {
+      expect(
+        renderShallow({ modalOpen: true, accounts: [] }).find('Connect(Modal)')
+      ).to.have.length(1);
+    });
+  });
+});

js/src/modals/DappPermissions/index.js

@@ -0,0 +1,17 @@
+// Copyright 2015, 2016 Parity Technologies (UK) Ltd.
+// This file is part of Parity.
+
+// Parity is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// Parity is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with Parity.  If not, see <http://www.gnu.org/licenses/>.
+
+export default from './dappPermissions';

js/src/modals/DappPermissions/store.js

@@ -0,0 +1,94 @@
+// Copyright 2015, 2016 Parity Technologies (UK) Ltd.
+// This file is part of Parity.
+
+// Parity is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// Parity is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with Parity.  If not, see <http://www.gnu.org/licenses/>.
+
+import { action, observable, transaction } from 'mobx';
+
+export default class Store {
+  @observable accounts = [];
+  @observable modalOpen = false;
+  @observable whitelist = [];
+
+  constructor (api) {
+    this._api = api;
+
+    this.loadWhitelist();
+  }
+
+  @action closeModal = () => {
+    transaction(() => {
+      const accounts = this.accounts
+        .filter((account) => account.checked)
+        .map((account) => account.address);
+
+      this.modalOpen = false;
+      this.updateWhitelist(accounts.length === this.accounts.length ? null : accounts);
+    });
+  }
+
+  @action openModal = (accounts) => {
+    transaction(() => {
+      this.accounts = Object
+        .values(accounts)
+        .map((account) => {
+          return {
+            address: account.address,
+            checked: this.whitelist
+              ? this.whitelist.includes(account.address)
+              : true,
+            description: account.meta.description,
+            name: account.name
+          };
+        });
+      this.modalOpen = true;
+    });
+  }
+
+  @action selectAccount = (address) => {
+    this.accounts = this.accounts.map((account) => {
+      if (account.address === address) {
+        account.checked = !account.checked;
+      }
+
+      return account;
+    });
+  }
+
+  @action setWhitelist = (whitelist) => {
+    this.whitelist = whitelist;
+  }
+
+  loadWhitelist () {
+    return this._api.parity
+      .getNewDappsWhitelist()
+      .then((whitelist) => {
+        this.setWhitelist(whitelist);
+      })
+      .catch((error) => {
+        console.warn('loadWhitelist', error);
+      });
+  }
+
+  updateWhitelist (whitelist) {
+    return this._api.parity
+      .setNewDappsWhitelist(whitelist)
+      .then(() => {
+        this.setWhitelist(whitelist);
+      })
+      .catch((error) => {
+        console.warn('updateWhitelist', error);
+      });
+  }
+}

js/src/modals/DappPermissions/store.spec.js

@@ -0,0 +1,100 @@
+// Copyright 2015, 2016 Parity Technologies (UK) Ltd.
+// This file is part of Parity.
+
+// Parity is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// Parity is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with Parity.  If not, see <http://www.gnu.org/licenses/>.
+
+import sinon from 'sinon';
+
+import Store from './store';
+
+const ACCOUNTS = {
+  '123': { address: '123', name: '123', meta: { description: '123' } },
+  '456': { address: '456', name: '456', meta: { description: '456' } },
+  '789': { address: '789', name: '789', meta: { description: '789' } }
+};
+const WHITELIST = ['123', '456'];
+
+describe('modals/DappPermissions/store', () => {
+  let api;
+  let store;
+
+  beforeEach(() => {
+    api = {
+      parity: {
+        getNewDappsWhitelist: sinon.stub().resolves(WHITELIST),
+        setNewDappsWhitelist: sinon.stub().resolves(true)
+      }
+    };
+
+    store = new Store(api);
+  });
+
+  describe('constructor', () => {
+    it('retrieves the whitelist via api', () => {
+      expect(api.parity.getNewDappsWhitelist).to.be.calledOnce;
+    });
+
+    it('sets the retrieved whitelist', () => {
+      expect(store.whitelist.peek()).to.deep.equal(WHITELIST);
+    });
+  });
+
+  describe('@actions', () => {
+    describe('openModal', () => {
+      beforeEach(() => {
+        store.openModal(ACCOUNTS);
+      });
+
+      it('sets the modalOpen status', () => {
+        expect(store.modalOpen).to.be.true;
+      });
+
+      it('sets accounts with checked interfaces', () => {
+        expect(store.accounts.peek()).to.deep.equal([
+          { address: '123', name: '123', description: '123', checked: true },
+          { address: '456', name: '456', description: '456', checked: true },
+          { address: '789', name: '789', description: '789', checked: false }
+        ]);
+      });
+    });
+
+    describe('closeModal', () => {
+      beforeEach(() => {
+        store.openModal(ACCOUNTS);
+        store.selectAccount('789');
+        store.closeModal();
+      });
+
+      it('calls setNewDappsWhitelist', () => {
+        expect(api.parity.setNewDappsWhitelist).to.have.been.calledOnce;
+      });
+    });
+
+    describe('selectAccount', () => {
+      beforeEach(() => {
+        store.openModal(ACCOUNTS);
+        store.selectAccount('123');
+        store.selectAccount('789');
+      });
+
+      it('unselects previous selected accounts', () => {
+        expect(store.accounts.find((account) => account.address === '123').checked).to.be.false;
+      });
+
+      it('selects previous unselected accounts', () => {
+        expect(store.accounts.find((account) => account.address === '789').checked).to.be.true;
+      });
+    });
+  });
+});

js/src/modals/index.js

@@ -16,8 +16,10 @@
 
 import AddAddress from './AddAddress';
 import AddContract from './AddContract';
+import AddDapps from './AddDapps';
 import CreateAccount from './CreateAccount';
 import CreateWallet from './CreateWallet';
+import DappPermissions from './DappPermissions';
 import DeleteAccount from './DeleteAccount';
 import DeployContract from './DeployContract';
 import EditMeta from './EditMeta';
@@ -35,8 +37,10 @@ import WalletSettings from './WalletSettings';
 export {
   AddAddress,
   AddContract,
+  AddDapps,
   CreateAccount,
   CreateWallet,
+  DappPermissions,
   DeleteAccount,
   DeployContract,
   EditMeta,