block cleanup (#9117)

* blockchain insert expects owned block instead of block reference

* reduce a number of times a block is deserialized

* removed cached uncle_bytes from block

* removed is_finalized from OpenBlock

* removed unused parity_machine::WithMetadata trait

* removed commented out code

* remove unused metadata from block

* remove unused metadata from block

* BlockDetails extras may have at most 5 elements

ethcore/src/blockchain/update.rs

@@ -19,13 +19,14 @@ use ethereum_types::{H256, Bloom};
 use header::BlockNumber;
 use blockchain::block_info::BlockInfo;
 use blockchain::extras::{BlockDetails, BlockReceipts, TransactionAddress};
+use encoded::Block;
 
 /// Block extras update info.
-pub struct ExtrasUpdate<'a> {
+pub struct ExtrasUpdate {
 	/// Block info.
 	pub info: BlockInfo,
 	/// Current block uncompressed rlp bytes
-	pub block: &'a [u8],
+	pub block: Block,
 	/// Modified block hashes.
 	pub block_hashes: HashMap<BlockNumber, H256>,
 	/// Modified block details.
@@ -44,6 +45,4 @@ pub struct ExtrasInsert {
 	pub fork_choice: ::engines::ForkChoice,
 	/// Is the inserted block considered finalized.
 	pub is_finalized: bool,
-	/// New block local metadata.
-	pub metadata: Option<Vec<u8>>,
 }