Fix warnings: unnecessary mut

ethcore/evm/src/interpreter/mod.rs

@@ -1481,7 +1481,7 @@ mod tests {
         ext.tracing = true;
 
         let gas_left = {
-            let mut vm = interpreter(params, &ext);
+            let vm = interpreter(params, &ext);
             test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
         };
 
@@ -1503,7 +1503,7 @@ mod tests {
         ext.tracing = true;
 
         let err = {
-            let mut vm = interpreter(params, &ext);
+            let vm = interpreter(params, &ext);
             test_finalize(vm.exec(&mut ext).ok().unwrap())
                 .err()
                 .unwrap()

ethcore/evm/src/tests.rs

@@ -44,7 +44,7 @@ fn test_add(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -68,7 +68,7 @@ fn test_sha3(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -92,7 +92,7 @@ fn test_address(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -118,7 +118,7 @@ fn test_origin(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -174,7 +174,7 @@ fn test_sender(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -238,7 +238,7 @@ fn test_extcodecopy(factory: super::Factory) {
     ext.codes.insert(sender, Arc::new(sender_code));
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -262,7 +262,7 @@ fn test_log_empty(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -294,7 +294,7 @@ fn test_log_sender(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -328,7 +328,7 @@ fn test_blockhash(factory: super::Factory) {
     ext.blockhashes.insert(U256::zero(), blockhash.clone());
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -352,7 +352,7 @@ fn test_calldataload(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -376,7 +376,7 @@ fn test_author(factory: super::Factory) {
     ext.info.author = author;
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -400,7 +400,7 @@ fn test_timestamp(factory: super::Factory) {
     ext.info.timestamp = timestamp;
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -424,7 +424,7 @@ fn test_number(factory: super::Factory) {
     ext.info.number = number;
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -448,7 +448,7 @@ fn test_difficulty(factory: super::Factory) {
     ext.info.difficulty = difficulty;
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -472,7 +472,7 @@ fn test_gas_limit(factory: super::Factory) {
     ext.info.gas_limit = gas_limit;
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -494,7 +494,7 @@ fn test_mul(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -516,7 +516,7 @@ fn test_sub(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -538,7 +538,7 @@ fn test_div(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -560,7 +560,7 @@ fn test_div_zero(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -584,7 +584,7 @@ fn test_mod(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -613,7 +613,7 @@ fn test_smod(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -642,7 +642,7 @@ fn test_sdiv(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -671,7 +671,7 @@ fn test_exp(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -705,7 +705,7 @@ fn test_comparison(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -744,7 +744,7 @@ fn test_signed_comparison(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -783,7 +783,7 @@ fn test_bitops(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -832,7 +832,7 @@ fn test_addmod_mulmod(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -869,7 +869,7 @@ fn test_byte(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -896,7 +896,7 @@ fn test_signextend(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -924,7 +924,7 @@ fn test_badinstruction_int() {
     let mut ext = FakeExt::new();
 
     let err = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap_err()
     };
 
@@ -944,7 +944,7 @@ fn test_pop(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -970,7 +970,7 @@ fn test_extops(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -1019,7 +1019,7 @@ fn test_jumps(factory: super::Factory) {
     let mut ext = FakeExt::new();
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -1055,7 +1055,7 @@ fn test_calls(factory: super::Factory) {
     };
 
     let gas_left = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };
 
@@ -1102,7 +1102,7 @@ fn test_create_in_staticcall(factory: super::Factory) {
     ext.is_static = true;
 
     let err = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap_err()
     };
 
@@ -1414,7 +1414,7 @@ fn push_two_pop_one_constantinople_test(
     let mut ext = FakeExt::new_constantinople();
 
     let _ = {
-        let mut vm = factory.create(params, ext.schedule(), ext.depth());
+        let vm = factory.create(params, ext.schedule(), ext.depth());
         test_finalize(vm.exec(&mut ext).ok().unwrap()).unwrap()
     };