Web Based Dapps (#3956)

* Dapps web

Conflicts:
	dapps/src/apps/fetcher.rs
	dapps/src/handlers/fetch.rs

* Rewriting fetch

* Parity-wide fetch service

* Obey the limits and support cancellation.

* Removing temporary files.

* Actually use Fetch for dapps

* Re-implementing file fetching to avoid temporary files.

* Serde to 0.8.19

* Fixing content & dapps fetch

* Serving web content and injecting scripts

* Don't wait for old content, start a new download

* Supporting timeouts and query

* Simple GUI for the browser

* Proxy tokens validation

* Recovering from invalid web-based requests

* Remember last visisted URL

* Removing unused variables

* Addressing review comments

* Setting default account in web3

* Adding WebBrowser dapp to the list

* Actually prune old entries when generating new token
This commit is contained in:
Tomasz Drwięga 2016-12-27 11:15:02 +01:00 committed by Gav Wood
parent 6842d43491
commit c7c309d152
34 changed files with 933 additions and 167 deletions

View File

@ -9,7 +9,7 @@ build = "build.rs"
[lib] [lib]
[dependencies] [dependencies]
rand = "0.3.14" rand = "0.3"
log = "0.3" log = "0.3"
env_logger = "0.3" env_logger = "0.3"
futures = "0.1" futures = "0.1"

View File

@ -17,14 +17,13 @@
//! Fetchable Dapps support. //! Fetchable Dapps support.
use std::fs; use std::fs;
use std::sync::{Arc};
use linked_hash_map::LinkedHashMap; use linked_hash_map::LinkedHashMap;
use page::LocalPageEndpoint; use page::LocalPageEndpoint;
use handlers::FetchControl; use handlers::FetchControl;
pub enum ContentStatus { pub enum ContentStatus {
Fetching(Arc<FetchControl>), Fetching(FetchControl),
Ready(LocalPageEndpoint), Ready(LocalPageEndpoint),
} }

View File

@ -23,7 +23,7 @@ use util::H256;
use util::sha3::sha3; use util::sha3::sha3;
use page::{LocalPageEndpoint, PageCache}; use page::{LocalPageEndpoint, PageCache};
use handlers::ContentValidator; use handlers::{ContentValidator, ValidatorResponse};
use apps::manifest::{MANIFEST_FILENAME, deserialize_manifest, serialize_manifest, Manifest}; use apps::manifest::{MANIFEST_FILENAME, deserialize_manifest, serialize_manifest, Manifest};
type OnDone = Box<Fn(Option<LocalPageEndpoint>) + Send>; type OnDone = Box<Fn(Option<LocalPageEndpoint>) + Send>;
@ -90,7 +90,7 @@ impl Content {
impl ContentValidator for Content { impl ContentValidator for Content {
type Error = ValidationError; type Error = ValidationError;
fn validate_and_install(&self, response: fetch::Response) -> Result<LocalPageEndpoint, ValidationError> { fn validate_and_install(&self, response: fetch::Response) -> Result<ValidatorResponse, ValidationError> {
let validate = |content_path: PathBuf| { let validate = |content_path: PathBuf| {
// Create dir // Create dir
let (_, content_path) = try!(write_response_and_check_hash(self.id.as_str(), content_path.clone(), self.id.as_str(), response)); let (_, content_path) = try!(write_response_and_check_hash(self.id.as_str(), content_path.clone(), self.id.as_str(), response));
@ -108,7 +108,7 @@ impl ContentValidator for Content {
let _ = fs::remove_dir_all(&content_path); let _ = fs::remove_dir_all(&content_path);
} }
(self.on_done)(result.as_ref().ok().cloned()); (self.on_done)(result.as_ref().ok().cloned());
result result.map(ValidatorResponse::Local)
} }
} }
@ -157,7 +157,7 @@ impl Dapp {
impl ContentValidator for Dapp { impl ContentValidator for Dapp {
type Error = ValidationError; type Error = ValidationError;
fn validate_and_install(&self, response: fetch::Response) -> Result<LocalPageEndpoint, ValidationError> { fn validate_and_install(&self, response: fetch::Response) -> Result<ValidatorResponse, ValidationError> {
let validate = |dapp_path: PathBuf| { let validate = |dapp_path: PathBuf| {
let (file, zip_path) = try!(write_response_and_check_hash(self.id.as_str(), dapp_path.clone(), &format!("{}.zip", self.id), response)); let (file, zip_path) = try!(write_response_and_check_hash(self.id.as_str(), dapp_path.clone(), &format!("{}.zip", self.id), response));
trace!(target: "dapps", "Opening dapp bundle at {:?}", zip_path); trace!(target: "dapps", "Opening dapp bundle at {:?}", zip_path);
@ -211,7 +211,7 @@ impl ContentValidator for Dapp {
let _ = fs::remove_dir_all(&target); let _ = fs::remove_dir_all(&target);
} }
(self.on_done)(result.as_ref().ok().cloned()); (self.on_done)(result.as_ref().ok().cloned());
result result.map(ValidatorResponse::Local)
} }
} }

View File

@ -129,12 +129,12 @@ impl<R: URLHint + Send + Sync + 'static, F: Fetch> Fetcher for ContentFetcher<F,
(None, endpoint.to_async_handler(path, control)) (None, endpoint.to_async_handler(path, control))
}, },
// Content is already being fetched // Content is already being fetched
Some(&mut ContentStatus::Fetching(ref fetch_control)) => { Some(&mut ContentStatus::Fetching(ref fetch_control)) if !fetch_control.is_deadline_reached() => {
trace!(target: "dapps", "Content fetching in progress. Waiting..."); trace!(target: "dapps", "Content fetching in progress. Waiting...");
(None, fetch_control.to_async_handler(path, control)) (None, fetch_control.to_async_handler(path, control))
}, },
// We need to start fetching the content // We need to start fetching the content
None => { _ => {
trace!(target: "dapps", "Content unavailable. Fetching... {:?}", content_id); trace!(target: "dapps", "Content unavailable. Fetching... {:?}", content_id);
let content_hex = content_id.from_hex().expect("to_handler is called only when `contains` returns true."); let content_hex = content_id.from_hex().expect("to_handler is called only when `contains` returns true.");
let content = self.resolver.resolve(content_hex); let content = self.resolver.resolve(content_hex);
@ -156,7 +156,7 @@ impl<R: URLHint + Send + Sync + 'static, F: Fetch> Fetcher for ContentFetcher<F,
(None, Self::still_syncing(self.embeddable_on.clone())) (None, Self::still_syncing(self.embeddable_on.clone()))
}, },
Some(URLHintResult::Dapp(dapp)) => { Some(URLHintResult::Dapp(dapp)) => {
let (handler, fetch_control) = ContentFetcherHandler::new( let handler = ContentFetcherHandler::new(
dapp.url(), dapp.url(),
path, path,
control, control,
@ -171,10 +171,10 @@ impl<R: URLHint + Send + Sync + 'static, F: Fetch> Fetcher for ContentFetcher<F,
self.fetch.clone(), self.fetch.clone(),
); );
(Some(ContentStatus::Fetching(fetch_control)), Box::new(handler) as Box<Handler>) (Some(ContentStatus::Fetching(handler.fetch_control())), Box::new(handler) as Box<Handler>)
}, },
Some(URLHintResult::Content(content)) => { Some(URLHintResult::Content(content)) => {
let (handler, fetch_control) = ContentFetcherHandler::new( let handler = ContentFetcherHandler::new(
content.url, content.url,
path, path,
control, control,
@ -189,7 +189,7 @@ impl<R: URLHint + Send + Sync + 'static, F: Fetch> Fetcher for ContentFetcher<F,
self.fetch.clone(), self.fetch.clone(),
); );
(Some(ContentStatus::Fetching(fetch_control)), Box::new(handler) as Box<Handler>) (Some(ContentStatus::Fetching(handler.fetch_control())), Box::new(handler) as Box<Handler>)
}, },
None if self.sync.is_major_importing() => { None if self.sync.is_major_importing() => {
(None, Self::still_syncing(self.embeddable_on.clone())) (None, Self::still_syncing(self.embeddable_on.clone()))

View File

@ -14,6 +14,7 @@
// You should have received a copy of the GNU General Public License // You should have received a copy of the GNU General Public License
// along with Parity. If not, see <http://www.gnu.org/licenses/>. // along with Parity. If not, see <http://www.gnu.org/licenses/>.
use std::sync::Arc;
use endpoint::{Endpoints, Endpoint}; use endpoint::{Endpoints, Endpoint};
use page::PageEndpoint; use page::PageEndpoint;
use proxypac::ProxyPac; use proxypac::ProxyPac;
@ -21,6 +22,7 @@ use web::Web;
use fetch::Fetch; use fetch::Fetch;
use parity_dapps::WebApp; use parity_dapps::WebApp;
use parity_reactor::Remote; use parity_reactor::Remote;
use {WebProxyTokens};
mod cache; mod cache;
mod fs; mod fs;
@ -40,14 +42,20 @@ pub fn utils() -> Box<Endpoint> {
Box::new(PageEndpoint::with_prefix(parity_ui::App::default(), UTILS_PATH.to_owned())) Box::new(PageEndpoint::with_prefix(parity_ui::App::default(), UTILS_PATH.to_owned()))
} }
pub fn all_endpoints<F: Fetch>(dapps_path: String, signer_address: Option<(String, u16)>, remote: Remote, fetch: F) -> Endpoints { pub fn all_endpoints<F: Fetch>(
dapps_path: String,
signer_address: Option<(String, u16)>,
web_proxy_tokens: Arc<WebProxyTokens>,
remote: Remote,
fetch: F,
) -> Endpoints {
// fetch fs dapps at first to avoid overwriting builtins // fetch fs dapps at first to avoid overwriting builtins
let mut pages = fs::local_endpoints(dapps_path, signer_address.clone()); let mut pages = fs::local_endpoints(dapps_path, signer_address.clone());
// NOTE [ToDr] Dapps will be currently embeded on 8180 // NOTE [ToDr] Dapps will be currently embeded on 8180
insert::<parity_ui::App>(&mut pages, "ui", Embeddable::Yes(signer_address.clone())); insert::<parity_ui::App>(&mut pages, "ui", Embeddable::Yes(signer_address.clone()));
pages.insert("proxy".into(), ProxyPac::boxed(signer_address)); pages.insert("proxy".into(), ProxyPac::boxed(signer_address.clone()));
pages.insert(WEB_PATH.into(), Web::boxed(remote, fetch)); pages.insert(WEB_PATH.into(), Web::boxed(signer_address.clone(), web_proxy_tokens.clone(), remote.clone(), fetch.clone()));
pages pages
} }

View File

@ -31,33 +31,41 @@ use hyper::uri::RequestUri;
use hyper::status::StatusCode; use hyper::status::StatusCode;
use endpoint::EndpointPath; use endpoint::EndpointPath;
use handlers::ContentHandler; use handlers::{ContentHandler, StreamingHandler};
use page::{LocalPageEndpoint, PageHandlerWaiting}; use page::{LocalPageEndpoint, PageHandlerWaiting};
const FETCH_TIMEOUT: u64 = 30; const FETCH_TIMEOUT: u64 = 30;
pub enum ValidatorResponse {
Local(LocalPageEndpoint),
Streaming(StreamingHandler<fetch::Response>),
}
pub trait ContentValidator: Send + 'static {
type Error: fmt::Debug + fmt::Display;
fn validate_and_install(&self, fetch::Response) -> Result<ValidatorResponse, Self::Error>;
}
enum FetchState { enum FetchState {
Waiting, Waiting,
NotStarted(String), NotStarted(String),
Error(ContentHandler), Error(ContentHandler),
InProgress(mpsc::Receiver<FetchState>), InProgress(mpsc::Receiver<FetchState>),
Streaming(StreamingHandler<fetch::Response>),
Done(LocalPageEndpoint, Box<PageHandlerWaiting>), Done(LocalPageEndpoint, Box<PageHandlerWaiting>),
} }
enum WaitResult { enum WaitResult {
Error(ContentHandler), Error(ContentHandler),
Done(LocalPageEndpoint), Done(LocalPageEndpoint),
NonAwaitable,
} }
pub trait ContentValidator: Send + 'static { #[derive(Clone)]
type Error: fmt::Debug + fmt::Display;
fn validate_and_install(&self, fetch::Response) -> Result<LocalPageEndpoint, Self::Error>;
}
pub struct FetchControl { pub struct FetchControl {
abort: Arc<AtomicBool>, abort: Arc<AtomicBool>,
listeners: Mutex<Vec<(Control, mpsc::Sender<WaitResult>)>>, listeners: Arc<Mutex<Vec<(Control, mpsc::Sender<WaitResult>)>>>,
deadline: Instant, deadline: Instant,
} }
@ -65,7 +73,7 @@ impl Default for FetchControl {
fn default() -> Self { fn default() -> Self {
FetchControl { FetchControl {
abort: Arc::new(AtomicBool::new(false)), abort: Arc::new(AtomicBool::new(false)),
listeners: Mutex::new(Vec::new()), listeners: Arc::new(Mutex::new(Vec::new())),
deadline: Instant::now() + Duration::from_secs(FETCH_TIMEOUT), deadline: Instant::now() + Duration::from_secs(FETCH_TIMEOUT),
} }
} }
@ -88,10 +96,15 @@ impl FetchControl {
match *status { match *status {
FetchState::Error(ref handler) => self.notify(|| WaitResult::Error(handler.clone())), FetchState::Error(ref handler) => self.notify(|| WaitResult::Error(handler.clone())),
FetchState::Done(ref endpoint, _) => self.notify(|| WaitResult::Done(endpoint.clone())), FetchState::Done(ref endpoint, _) => self.notify(|| WaitResult::Done(endpoint.clone())),
FetchState::Streaming(_) => self.notify(|| WaitResult::NonAwaitable),
FetchState::NotStarted(_) | FetchState::InProgress(_) | FetchState::Waiting => {}, FetchState::NotStarted(_) | FetchState::InProgress(_) | FetchState::Waiting => {},
} }
} }
pub fn is_deadline_reached(&self) -> bool {
self.deadline < Instant::now()
}
pub fn abort(&self) { pub fn abort(&self) {
self.abort.store(true, Ordering::SeqCst); self.abort.store(true, Ordering::SeqCst);
} }
@ -131,7 +144,7 @@ impl server::Handler<HttpStream> for WaitingHandler {
page_handler.set_uri(&self.uri); page_handler.set_uri(&self.uri);
FetchState::Done(endpoint, page_handler) FetchState::Done(endpoint, page_handler)
}, },
None => { _ => {
warn!("A result for waiting request was not received."); warn!("A result for waiting request was not received.");
FetchState::Waiting FetchState::Waiting
}, },
@ -139,6 +152,7 @@ impl server::Handler<HttpStream> for WaitingHandler {
match self.state { match self.state {
FetchState::Done(_, ref mut handler) => handler.on_request_readable(decoder), FetchState::Done(_, ref mut handler) => handler.on_request_readable(decoder),
FetchState::Streaming(ref mut handler) => handler.on_request_readable(decoder),
FetchState::Error(ref mut handler) => handler.on_request_readable(decoder), FetchState::Error(ref mut handler) => handler.on_request_readable(decoder),
_ => Next::write(), _ => Next::write(),
} }
@ -147,6 +161,7 @@ impl server::Handler<HttpStream> for WaitingHandler {
fn on_response(&mut self, res: &mut server::Response) -> Next { fn on_response(&mut self, res: &mut server::Response) -> Next {
match self.state { match self.state {
FetchState::Done(_, ref mut handler) => handler.on_response(res), FetchState::Done(_, ref mut handler) => handler.on_response(res),
FetchState::Streaming(ref mut handler) => handler.on_response(res),
FetchState::Error(ref mut handler) => handler.on_response(res), FetchState::Error(ref mut handler) => handler.on_response(res),
_ => Next::end(), _ => Next::end(),
} }
@ -155,22 +170,69 @@ impl server::Handler<HttpStream> for WaitingHandler {
fn on_response_writable(&mut self, encoder: &mut Encoder<HttpStream>) -> Next { fn on_response_writable(&mut self, encoder: &mut Encoder<HttpStream>) -> Next {
match self.state { match self.state {
FetchState::Done(_, ref mut handler) => handler.on_response_writable(encoder), FetchState::Done(_, ref mut handler) => handler.on_response_writable(encoder),
FetchState::Streaming(ref mut handler) => handler.on_response_writable(encoder),
FetchState::Error(ref mut handler) => handler.on_response_writable(encoder), FetchState::Error(ref mut handler) => handler.on_response_writable(encoder),
_ => Next::end(), _ => Next::end(),
} }
} }
} }
#[derive(Clone)]
struct Errors {
embeddable_on: Option<(String, u16)>,
}
impl Errors {
fn download_error<E: fmt::Debug>(&self, e: E) -> ContentHandler {
ContentHandler::error(
StatusCode::BadGateway,
"Download Error",
"There was an error when fetching the content.",
Some(&format!("{:?}", e)),
self.embeddable_on.clone(),
)
}
fn invalid_content<E: fmt::Debug>(&self, e: E) -> ContentHandler {
ContentHandler::error(
StatusCode::BadGateway,
"Invalid Dapp",
"Downloaded bundle does not contain a valid content.",
Some(&format!("{:?}", e)),
self.embeddable_on.clone(),
)
}
fn timeout_error(&self) -> ContentHandler {
ContentHandler::error(
StatusCode::GatewayTimeout,
"Download Timeout",
&format!("Could not fetch content within {} seconds.", FETCH_TIMEOUT),
None,
self.embeddable_on.clone(),
)
}
fn method_not_allowed(&self) -> ContentHandler {
ContentHandler::error(
StatusCode::MethodNotAllowed,
"Method Not Allowed",
"Only <code>GET</code> requests are allowed.",
None,
self.embeddable_on.clone(),
)
}
}
pub struct ContentFetcherHandler<H: ContentValidator, F: Fetch> { pub struct ContentFetcherHandler<H: ContentValidator, F: Fetch> {
fetch_control: Arc<FetchControl>, fetch_control: FetchControl,
control: Control, control: Control,
remote: Remote, remote: Remote,
status: FetchState, status: FetchState,
fetch: F, fetch: F,
installer: Option<H>, installer: Option<H>,
path: EndpointPath, path: EndpointPath,
uri: RequestUri, errors: Errors,
embeddable_on: Option<(String, u16)>,
} }
impl<H: ContentValidator, F: Fetch> ContentFetcherHandler<H, F> { impl<H: ContentValidator, F: Fetch> ContentFetcherHandler<H, F> {
@ -178,70 +240,64 @@ impl<H: ContentValidator, F: Fetch> ContentFetcherHandler<H, F> {
url: String, url: String,
path: EndpointPath, path: EndpointPath,
control: Control, control: Control,
handler: H, installer: H,
embeddable_on: Option<(String, u16)>, embeddable_on: Option<(String, u16)>,
remote: Remote, remote: Remote,
fetch: F, fetch: F,
) -> (Self, Arc<FetchControl>) { ) -> Self {
let fetch_control = Arc::new(FetchControl::default()); ContentFetcherHandler {
let handler = ContentFetcherHandler { fetch_control: FetchControl::default(),
fetch_control: fetch_control.clone(),
control: control, control: control,
remote: remote, remote: remote,
fetch: fetch, fetch: fetch,
status: FetchState::NotStarted(url), status: FetchState::NotStarted(url),
installer: Some(handler), installer: Some(installer),
path: path, path: path,
uri: RequestUri::default(), errors: Errors {
embeddable_on: embeddable_on, embeddable_on: embeddable_on,
}; },
}
(handler, fetch_control)
} }
fn fetch_content(&self, url: &str, installer: H) -> mpsc::Receiver<FetchState> { pub fn fetch_control(&self) -> FetchControl {
self.fetch_control.clone()
}
fn fetch_content(&self, uri: RequestUri, url: &str, installer: H) -> mpsc::Receiver<FetchState> {
let (tx, rx) = mpsc::channel(); let (tx, rx) = mpsc::channel();
let abort = self.fetch_control.abort.clone(); let abort = self.fetch_control.abort.clone();
let control = self.control.clone();
let embeddable_on = self.embeddable_on.clone();
let uri = self.uri.clone();
let path = self.path.clone(); let path = self.path.clone();
let tx2 = tx.clone();
let control = self.control.clone();
let errors = self.errors.clone();
let future = self.fetch.fetch_with_abort(url, abort.into()).then(move |result| { let future = self.fetch.fetch_with_abort(url, abort.into()).then(move |result| {
trace!(target: "dapps", "Fetching content finished. Starting validation: {:?}", result); trace!(target: "dapps", "Fetching content finished. Starting validation: {:?}", result);
let new_state = match result { let new_state = match result {
Ok(response) => match installer.validate_and_install(response) { Ok(response) => match installer.validate_and_install(response) {
Ok(endpoint) => { Ok(ValidatorResponse::Local(endpoint)) => {
trace!(target: "dapps", "Validation OK. Returning response."); trace!(target: "dapps", "Validation OK. Returning response.");
let mut handler = endpoint.to_page_handler(path); let mut handler = endpoint.to_page_handler(path);
handler.set_uri(&uri); handler.set_uri(&uri);
FetchState::Done(endpoint, handler) FetchState::Done(endpoint, handler)
}, },
Ok(ValidatorResponse::Streaming(handler)) => {
trace!(target: "dapps", "Validation OK. Streaming response.");
FetchState::Streaming(handler)
},
Err(e) => { Err(e) => {
trace!(target: "dapps", "Error while validating content: {:?}", e); trace!(target: "dapps", "Error while validating content: {:?}", e);
FetchState::Error(ContentHandler::error( FetchState::Error(errors.invalid_content(e))
StatusCode::BadGateway,
"Invalid Dapp",
"Downloaded bundle does not contain a valid content.",
Some(&format!("{:?}", e)),
embeddable_on,
))
}, },
}, },
Err(e) => { Err(e) => {
warn!(target: "dapps", "Unable to fetch content: {:?}", e); warn!(target: "dapps", "Unable to fetch content: {:?}", e);
FetchState::Error(ContentHandler::error( FetchState::Error(errors.download_error(e))
StatusCode::BadGateway,
"Download Error",
"There was an error when fetching the content.",
Some(&format!("{:?}", e)),
embeddable_on,
))
}, },
}; };
// Content may be resolved when the connection is already dropped. // Content may be resolved when the connection is already dropped.
let _ = tx.send(new_state); let _ = tx2.send(new_state);
// Ignoring control errors // Ignoring control errors
let _ = control.ready(Next::read()); let _ = control.ready(Next::read());
Ok(()) as Result<(), ()> Ok(()) as Result<(), ()>
@ -250,7 +306,14 @@ impl<H: ContentValidator, F: Fetch> ContentFetcherHandler<H, F> {
// make sure to run within fetch thread pool. // make sure to run within fetch thread pool.
let future = self.fetch.process(future); let future = self.fetch.process(future);
// spawn to event loop // spawn to event loop
self.remote.spawn(future); let control = self.control.clone();
let errors = self.errors.clone();
self.remote.spawn_with_timeout(|| future, Duration::from_secs(FETCH_TIMEOUT), move || {
// Notify about the timeout
let _ = tx.send(FetchState::Error(errors.timeout_error()));
// Ignoring control errors
let _ = control.ready(Next::read());
});
rx rx
} }
@ -258,24 +321,19 @@ impl<H: ContentValidator, F: Fetch> ContentFetcherHandler<H, F> {
impl<H: ContentValidator, F: Fetch> server::Handler<HttpStream> for ContentFetcherHandler<H, F> { impl<H: ContentValidator, F: Fetch> server::Handler<HttpStream> for ContentFetcherHandler<H, F> {
fn on_request(&mut self, request: server::Request<HttpStream>) -> Next { fn on_request(&mut self, request: server::Request<HttpStream>) -> Next {
self.uri = request.uri().clone();
let installer = self.installer.take().expect("Installer always set initialy; installer used only in on_request; on_request invoked only once; qed");
let status = if let FetchState::NotStarted(ref url) = self.status { let status = if let FetchState::NotStarted(ref url) = self.status {
let uri = request.uri().clone();
let installer = self.installer.take().expect("Installer always set initialy; installer used only in on_request; on_request invoked only once; qed");
Some(match *request.method() { Some(match *request.method() {
// Start fetching content // Start fetching content
Method::Get => { Method::Get => {
trace!(target: "dapps", "Fetching content from: {:?}", url); trace!(target: "dapps", "Fetching content from: {:?}", url);
let receiver = self.fetch_content(url, installer); let receiver = self.fetch_content(uri, url, installer);
FetchState::InProgress(receiver) FetchState::InProgress(receiver)
}, },
// or return error // or return error
_ => FetchState::Error(ContentHandler::error( _ => FetchState::Error(self.errors.method_not_allowed()),
StatusCode::MethodNotAllowed,
"Method Not Allowed",
"Only <code>GET</code> requests are allowed.",
None,
self.embeddable_on.clone(),
)),
}) })
} else { None }; } else { None };
@ -290,16 +348,9 @@ impl<H: ContentValidator, F: Fetch> server::Handler<HttpStream> for ContentFetch
fn on_request_readable(&mut self, decoder: &mut Decoder<HttpStream>) -> Next { fn on_request_readable(&mut self, decoder: &mut Decoder<HttpStream>) -> Next {
let (status, next) = match self.status { let (status, next) = match self.status {
// Request may time out // Request may time out
FetchState::InProgress(_) if self.fetch_control.deadline < Instant::now() => { FetchState::InProgress(_) if self.fetch_control.is_deadline_reached() => {
trace!(target: "dapps", "Fetching dapp failed because of timeout."); trace!(target: "dapps", "Fetching dapp failed because of timeout.");
let timeout = ContentHandler::error( (Some(FetchState::Error(self.errors.timeout_error())), Next::write())
StatusCode::GatewayTimeout,
"Download Timeout",
&format!("Could not fetch content within {} seconds.", FETCH_TIMEOUT),
None,
self.embeddable_on.clone(),
);
(Some(FetchState::Error(timeout)), Next::write())
}, },
FetchState::InProgress(ref receiver) => { FetchState::InProgress(ref receiver) => {
// Check if there is an answer // Check if there is an answer
@ -326,6 +377,7 @@ impl<H: ContentValidator, F: Fetch> server::Handler<HttpStream> for ContentFetch
fn on_response(&mut self, res: &mut server::Response) -> Next { fn on_response(&mut self, res: &mut server::Response) -> Next {
match self.status { match self.status {
FetchState::Done(_, ref mut handler) => handler.on_response(res), FetchState::Done(_, ref mut handler) => handler.on_response(res),
FetchState::Streaming(ref mut handler) => handler.on_response(res),
FetchState::Error(ref mut handler) => handler.on_response(res), FetchState::Error(ref mut handler) => handler.on_response(res),
_ => Next::end(), _ => Next::end(),
} }
@ -334,6 +386,7 @@ impl<H: ContentValidator, F: Fetch> server::Handler<HttpStream> for ContentFetch
fn on_response_writable(&mut self, encoder: &mut Encoder<HttpStream>) -> Next { fn on_response_writable(&mut self, encoder: &mut Encoder<HttpStream>) -> Next {
match self.status { match self.status {
FetchState::Done(_, ref mut handler) => handler.on_response_writable(encoder), FetchState::Done(_, ref mut handler) => handler.on_response_writable(encoder),
FetchState::Streaming(ref mut handler) => handler.on_response_writable(encoder),
FetchState::Error(ref mut handler) => handler.on_response_writable(encoder), FetchState::Error(ref mut handler) => handler.on_response_writable(encoder),
_ => Next::end(), _ => Next::end(),
} }

View File

@ -17,16 +17,18 @@
//! Hyper handlers implementations. //! Hyper handlers implementations.
mod auth; mod auth;
mod echo;
mod content; mod content;
mod redirect; mod echo;
mod fetch; mod fetch;
mod redirect;
mod streaming;
pub use self::auth::AuthRequiredHandler; pub use self::auth::AuthRequiredHandler;
pub use self::echo::EchoHandler;
pub use self::content::ContentHandler; pub use self::content::ContentHandler;
pub use self::echo::EchoHandler;
pub use self::fetch::{ContentFetcherHandler, ContentValidator, FetchControl, ValidatorResponse};
pub use self::redirect::Redirection; pub use self::redirect::Redirection;
pub use self::fetch::{ContentFetcherHandler, ContentValidator, FetchControl}; pub use self::streaming::StreamingHandler;
use url::Url; use url::Url;
use hyper::{server, header, net, uri}; use hyper::{server, header, net, uri};
@ -49,20 +51,30 @@ pub fn add_security_headers(headers: &mut header::Headers, embeddable_on: Option
} }
} }
/// Extracts URL part from the Request. /// Extracts URL part from the Request.
pub fn extract_url(req: &server::Request<net::HttpStream>) -> Option<Url> { pub fn extract_url(req: &server::Request<net::HttpStream>) -> Option<Url> {
match *req.uri() { convert_uri_to_url(req.uri(), req.headers().get::<header::Host>())
}
/// Extracts URL given URI and Host header.
pub fn convert_uri_to_url(uri: &uri::RequestUri, host: Option<&header::Host>) -> Option<Url> {
match *uri {
uri::RequestUri::AbsoluteUri(ref url) => { uri::RequestUri::AbsoluteUri(ref url) => {
match Url::from_generic_url(url.clone()) { match Url::from_generic_url(url.clone()) {
Ok(url) => Some(url), Ok(url) => Some(url),
_ => None, _ => None,
} }
}, },
uri::RequestUri::AbsolutePath { ref path, .. } => { uri::RequestUri::AbsolutePath { ref path, ref query } => {
let query = match *query {
Some(ref query) => format!("?{}", query),
None => "".into(),
};
// Attempt to prepend the Host header (mandatory in HTTP/1.1) // Attempt to prepend the Host header (mandatory in HTTP/1.1)
let url_string = match req.headers().get::<header::Host>() { let url_string = match host {
Some(ref host) => { Some(ref host) => {
format!("http://{}:{}{}", host.hostname, host.port.unwrap_or(80), path) format!("http://{}:{}{}{}", host.hostname, host.port.unwrap_or(80), path, query)
}, },
None => return None, None => return None,
}; };

View File

@ -0,0 +1,101 @@
// Copyright 2015, 2016 Parity Technologies (UK) Ltd.
// This file is part of Parity.
// Parity is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
// Parity is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
// You should have received a copy of the GNU General Public License
// along with Parity. If not, see <http://www.gnu.org/licenses/>.
//! Content Stream Response
use std::io::{self, Read};
use hyper::{header, server, Decoder, Encoder, Next};
use hyper::net::HttpStream;
use hyper::mime::Mime;
use hyper::status::StatusCode;
use handlers::add_security_headers;
const BUFFER_SIZE: usize = 1024;
pub struct StreamingHandler<R: io::Read> {
buffer: [u8; BUFFER_SIZE],
buffer_leftover: usize,
status: StatusCode,
content: io::BufReader<R>,
mimetype: Mime,
safe_to_embed_on: Option<(String, u16)>,
}
impl<R: io::Read> StreamingHandler<R> {
pub fn new(content: R, status: StatusCode, mimetype: Mime, embeddable_on: Option<(String, u16)>) -> Self {
StreamingHandler {
buffer: [0; BUFFER_SIZE],
buffer_leftover: 0,
status: status,
content: io::BufReader::new(content),
mimetype: mimetype,
safe_to_embed_on: embeddable_on,
}
}
pub fn set_initial_content(&mut self, content: &str) {
assert_eq!(self.buffer_leftover, 0);
let bytes = content.as_bytes();
self.buffer_leftover = bytes.len();
self.buffer[0..self.buffer_leftover].copy_from_slice(bytes);
}
}
impl<R: io::Read> server::Handler<HttpStream> for StreamingHandler<R> {
fn on_request(&mut self, _request: server::Request<HttpStream>) -> Next {
Next::write()
}
fn on_request_readable(&mut self, _decoder: &mut Decoder<HttpStream>) -> Next {
Next::write()
}
fn on_response(&mut self, res: &mut server::Response) -> Next {
res.set_status(self.status);
res.headers_mut().set(header::ContentType(self.mimetype.clone()));
add_security_headers(&mut res.headers_mut(), self.safe_to_embed_on.clone());
Next::write()
}
fn on_response_writable(&mut self, encoder: &mut Encoder<HttpStream>) -> Next {
fn handle_error(e: io::Error) -> Next {
match e.kind() {
::std::io::ErrorKind::WouldBlock => Next::write(),
_ => Next::end(),
}
}
let write_pos = self.buffer_leftover;
match self.content.read(&mut self.buffer[write_pos..]) {
Err(e) => handle_error(e),
Ok(read) => match encoder.write(&self.buffer[..write_pos + read]) {
Err(e) => handle_error(e),
Ok(0) => Next::end(),
Ok(wrote) => {
self.buffer_leftover = write_pos + read - wrote;
if self.buffer_leftover > 0 {
for i in self.buffer_leftover..write_pos + read {
self.buffer.swap(i, i - self.buffer_leftover);
}
}
Next::write()
},
},
}
}
}

View File

@ -111,12 +111,23 @@ impl<F> SyncStatus for F where F: Fn() -> bool + Send + Sync {
fn is_major_importing(&self) -> bool { self() } fn is_major_importing(&self) -> bool { self() }
} }
/// Validates Web Proxy tokens
pub trait WebProxyTokens: Send + Sync {
/// Should return true if token is a valid web proxy access token.
fn is_web_proxy_token_valid(&self, token: &String) -> bool;
}
impl<F> WebProxyTokens for F where F: Fn(String) -> bool + Send + Sync {
fn is_web_proxy_token_valid(&self, token: &String) -> bool { self(token.to_owned()) }
}
/// Webapps HTTP+RPC server build. /// Webapps HTTP+RPC server build.
pub struct ServerBuilder { pub struct ServerBuilder {
dapps_path: String, dapps_path: String,
handler: Arc<IoHandler>, handler: Arc<IoHandler>,
registrar: Arc<ContractClient>, registrar: Arc<ContractClient>,
sync_status: Arc<SyncStatus>, sync_status: Arc<SyncStatus>,
web_proxy_tokens: Arc<WebProxyTokens>,
signer_address: Option<(String, u16)>, signer_address: Option<(String, u16)>,
remote: Remote, remote: Remote,
fetch: Option<FetchClient>, fetch: Option<FetchClient>,
@ -136,6 +147,7 @@ impl ServerBuilder {
handler: Arc::new(IoHandler::new()), handler: Arc::new(IoHandler::new()),
registrar: registrar, registrar: registrar,
sync_status: Arc::new(|| false), sync_status: Arc::new(|| false),
web_proxy_tokens: Arc::new(|_| false),
signer_address: None, signer_address: None,
remote: remote, remote: remote,
fetch: None, fetch: None,
@ -152,6 +164,11 @@ impl ServerBuilder {
self.sync_status = status; self.sync_status = status;
} }
/// Change default web proxy tokens validator.
pub fn with_web_proxy_tokens(&mut self, tokens: Arc<WebProxyTokens>) {
self.web_proxy_tokens = tokens;
}
/// Change default signer port. /// Change default signer port.
pub fn with_signer_address(&mut self, signer_address: Option<(String, u16)>) { pub fn with_signer_address(&mut self, signer_address: Option<(String, u16)>) {
self.signer_address = signer_address; self.signer_address = signer_address;
@ -169,6 +186,7 @@ impl ServerBuilder {
self.signer_address.clone(), self.signer_address.clone(),
self.registrar.clone(), self.registrar.clone(),
self.sync_status.clone(), self.sync_status.clone(),
self.web_proxy_tokens.clone(),
self.remote.clone(), self.remote.clone(),
try!(self.fetch()), try!(self.fetch()),
) )
@ -186,6 +204,7 @@ impl ServerBuilder {
self.signer_address.clone(), self.signer_address.clone(),
self.registrar.clone(), self.registrar.clone(),
self.sync_status.clone(), self.sync_status.clone(),
self.web_proxy_tokens.clone(),
self.remote.clone(), self.remote.clone(),
try!(self.fetch()), try!(self.fetch()),
) )
@ -241,6 +260,7 @@ impl Server {
signer_address: Option<(String, u16)>, signer_address: Option<(String, u16)>,
registrar: Arc<ContractClient>, registrar: Arc<ContractClient>,
sync_status: Arc<SyncStatus>, sync_status: Arc<SyncStatus>,
web_proxy_tokens: Arc<WebProxyTokens>,
remote: Remote, remote: Remote,
fetch: F, fetch: F,
) -> Result<Server, ServerError> { ) -> Result<Server, ServerError> {
@ -253,7 +273,7 @@ impl Server {
remote.clone(), remote.clone(),
fetch.clone(), fetch.clone(),
)); ));
let endpoints = Arc::new(apps::all_endpoints(dapps_path, signer_address.clone(), remote.clone(), fetch.clone())); let endpoints = Arc::new(apps::all_endpoints(dapps_path, signer_address.clone(), web_proxy_tokens, remote.clone(), fetch.clone()));
let cors_domains = Self::cors_domains(signer_address.clone()); let cors_domains = Self::cors_domains(signer_address.clone());
let special = Arc::new({ let special = Arc::new({

View File

@ -21,15 +21,16 @@ pub mod auth;
mod host_validation; mod host_validation;
use address; use address;
use std::cmp;
use std::sync::Arc; use std::sync::Arc;
use std::collections::HashMap; use std::collections::HashMap;
use url::{Url, Host}; use url::{Url, Host};
use hyper::{self, server, Next, Encoder, Decoder, Control, StatusCode}; use hyper::{self, server, header, Next, Encoder, Decoder, Control, StatusCode};
use hyper::net::HttpStream; use hyper::net::HttpStream;
use apps::{self, DAPPS_DOMAIN}; use apps::{self, DAPPS_DOMAIN};
use apps::fetcher::Fetcher; use apps::fetcher::Fetcher;
use endpoint::{Endpoint, Endpoints, EndpointPath}; use endpoint::{Endpoint, Endpoints, EndpointPath};
use handlers::{Redirection, extract_url, ContentHandler}; use handlers::{self, Redirection, ContentHandler};
use self::auth::{Authorization, Authorized}; use self::auth::{Authorization, Authorized};
/// Special endpoints are accessible on every domain (every dapp) /// Special endpoints are accessible on every domain (every dapp)
@ -57,9 +58,11 @@ impl<A: Authorization + 'static> server::Handler<HttpStream> for Router<A> {
fn on_request(&mut self, req: server::Request<HttpStream>) -> Next { fn on_request(&mut self, req: server::Request<HttpStream>) -> Next {
// Choose proper handler depending on path / domain // Choose proper handler depending on path / domain
let url = extract_url(&req); let url = handlers::extract_url(&req);
let endpoint = extract_endpoint(&url); let endpoint = extract_endpoint(&url);
let referer = extract_referer_endpoint(&req);
let is_utils = endpoint.1 == SpecialEndpoint::Utils; let is_utils = endpoint.1 == SpecialEndpoint::Utils;
let is_get_request = *req.method() == hyper::Method::Get;
trace!(target: "dapps", "Routing request to {:?}. Details: {:?}", url, req); trace!(target: "dapps", "Routing request to {:?}. Details: {:?}", url, req);
@ -83,25 +86,42 @@ impl<A: Authorization + 'static> server::Handler<HttpStream> for Router<A> {
return self.handler.on_request(req); return self.handler.on_request(req);
} }
let control = self.control.take().expect("on_request is called only once; control is always defined at start; qed"); let control = self.control.take().expect("on_request is called only once; control is always defined at start; qed");
debug!(target: "dapps", "Handling endpoint request: {:?}", endpoint); debug!(target: "dapps", "Handling endpoint request: {:?}", endpoint);
self.handler = match endpoint { self.handler = match (endpoint.0, endpoint.1, referer) {
// Handle invalid web requests that we can recover from
(ref path, SpecialEndpoint::None, Some((ref referer, ref referer_url)))
if is_get_request
&& referer.app_id == apps::WEB_PATH
&& self.endpoints.contains_key(apps::WEB_PATH)
&& !is_web_endpoint(path)
=>
{
trace!(target: "dapps", "Redirecting to correct web request: {:?}", referer_url);
// TODO [ToDr] Some nice util for this!
let using_domain = if referer.using_dapps_domains { 0 } else { 1 };
let len = cmp::min(referer_url.path.len(), using_domain + 3); // token + protocol + hostname
let base = referer_url.path[..len].join("/");
let requested = url.map(|u| u.path.join("/")).unwrap_or_default();
Redirection::boxed(&format!("/{}/{}", base, requested))
},
// First check special endpoints // First check special endpoints
(ref path, ref endpoint) if self.special.contains_key(endpoint) => { (ref path, ref endpoint, _) if self.special.contains_key(endpoint) => {
trace!(target: "dapps", "Resolving to special endpoint."); trace!(target: "dapps", "Resolving to special endpoint.");
self.special.get(endpoint) self.special.get(endpoint)
.expect("special known to contain key; qed") .expect("special known to contain key; qed")
.to_async_handler(path.clone().unwrap_or_default(), control) .to_async_handler(path.clone().unwrap_or_default(), control)
}, },
// Then delegate to dapp // Then delegate to dapp
(Some(ref path), _) if self.endpoints.contains_key(&path.app_id) => { (Some(ref path), _, _) if self.endpoints.contains_key(&path.app_id) => {
trace!(target: "dapps", "Resolving to local/builtin dapp."); trace!(target: "dapps", "Resolving to local/builtin dapp.");
self.endpoints.get(&path.app_id) self.endpoints.get(&path.app_id)
.expect("special known to contain key; qed") .expect("endpoints known to contain key; qed")
.to_async_handler(path.clone(), control) .to_async_handler(path.clone(), control)
}, },
// Try to resolve and fetch the dapp // Try to resolve and fetch the dapp
(Some(ref path), _) if self.fetch.contains(&path.app_id) => { (Some(ref path), _, _) if self.fetch.contains(&path.app_id) => {
trace!(target: "dapps", "Resolving to fetchable content."); trace!(target: "dapps", "Resolving to fetchable content.");
self.fetch.to_async_handler(path.clone(), control) self.fetch.to_async_handler(path.clone(), control)
}, },
@ -110,7 +130,7 @@ impl<A: Authorization + 'static> server::Handler<HttpStream> for Router<A> {
// It should be safe to remove it in (near) future. // It should be safe to remove it in (near) future.
// //
// 404 for non-existent content // 404 for non-existent content
(Some(ref path), _) if *req.method() == hyper::Method::Get && path.app_id != "home" => { (Some(ref path), _, _) if is_get_request && path.app_id != "home" => {
trace!(target: "dapps", "Resolving to 404."); trace!(target: "dapps", "Resolving to 404.");
Box::new(ContentHandler::error( Box::new(ContentHandler::error(
StatusCode::NotFound, StatusCode::NotFound,
@ -121,7 +141,7 @@ impl<A: Authorization + 'static> server::Handler<HttpStream> for Router<A> {
)) ))
}, },
// Redirect any other GET request to signer. // Redirect any other GET request to signer.
_ if *req.method() == hyper::Method::Get => { _ if is_get_request => {
if let Some(signer_address) = self.signer_address.clone() { if let Some(signer_address) = self.signer_address.clone() {
trace!(target: "dapps", "Redirecting to signer interface."); trace!(target: "dapps", "Redirecting to signer interface.");
Redirection::boxed(&format!("http://{}", address(signer_address))) Redirection::boxed(&format!("http://{}", address(signer_address)))
@ -192,6 +212,23 @@ impl<A: Authorization> Router<A> {
} }
} }
fn is_web_endpoint(path: &Option<EndpointPath>) -> bool {
match *path {
Some(ref path) if path.app_id == apps::WEB_PATH => true,
_ => false,
}
}
fn extract_referer_endpoint(req: &server::Request<HttpStream>) -> Option<(EndpointPath, Url)> {
let referer = req.headers().get::<header::Referer>();
let url = referer.and_then(|referer| Url::parse(&referer.0).ok());
url.and_then(|url| {
let option = Some(url);
extract_endpoint(&option).0.map(|endpoint| (endpoint, option.expect("Just wrapped; qed")))
})
}
fn extract_endpoint(url: &Option<Url>) -> (Option<EndpointPath>, SpecialEndpoint) { fn extract_endpoint(url: &Option<Url>) -> (Option<EndpointPath>, SpecialEndpoint) {
fn special_endpoint(url: &Url) -> SpecialEndpoint { fn special_endpoint(url: &Url) -> SpecialEndpoint {
if url.path.len() <= 1 { if url.path.len() <= 1 {

View File

@ -37,6 +37,9 @@ pub struct Url {
/// Empty entries of `""` correspond to trailing slashes. /// Empty entries of `""` correspond to trailing slashes.
pub path: Vec<String>, pub path: Vec<String>,
/// The URL query.
pub query: Option<String>,
/// The URL username field, from the userinfo section of the URL. /// The URL username field, from the userinfo section of the URL.
/// ///
/// `None` if the `@` character was not part of the input OR /// `None` if the `@` character was not part of the input OR
@ -86,11 +89,13 @@ impl Url {
let host = try!(raw_url.host().ok_or_else(|| "Valid host, because only data:, mailto: protocols does not have host.".to_owned())).to_owned(); let host = try!(raw_url.host().ok_or_else(|| "Valid host, because only data:, mailto: protocols does not have host.".to_owned())).to_owned();
let path = try!(raw_url.path_segments().ok_or_else(|| "Valid path segments. In HTTP we won't get cannot-be-a-base URLs".to_owned())) let path = try!(raw_url.path_segments().ok_or_else(|| "Valid path segments. In HTTP we won't get cannot-be-a-base URLs".to_owned()))
.map(|part| part.to_owned()).collect(); .map(|part| part.to_owned()).collect();
let query = raw_url.query().map(|x| x.to_owned());
Ok(Url { Ok(Url {
port: port, port: port,
host: host, host: host,
path: path, path: path,
query: query,
raw: raw_url, raw: raw_url,
username: username, username: username,
password: password, password: password,

View File

@ -16,24 +16,36 @@
//! Serving web-based content (proxying) //! Serving web-based content (proxying)
use endpoint::{Endpoint, Handler, EndpointPath}; use std::sync::Arc;
use handlers::{ContentFetcherHandler, ContentHandler, ContentValidator, Redirection, extract_url};
use page::{LocalPageEndpoint};
use fetch::{self, Fetch}; use fetch::{self, Fetch};
use url::Url; use parity_reactor::Remote;
use hyper::{self, server, net, Next, Encoder, Decoder}; use hyper::{self, server, net, Next, Encoder, Decoder};
use hyper::status::StatusCode; use hyper::status::StatusCode;
use parity_reactor::Remote;
use apps::WEB_PATH; use apps;
use endpoint::{Endpoint, Handler, EndpointPath};
use handlers::{
ContentFetcherHandler, ContentHandler, ContentValidator, ValidatorResponse,
StreamingHandler, Redirection, extract_url,
};
use url::Url;
use WebProxyTokens;
pub type Embeddable = Option<(String, u16)>;
pub struct Web<F> { pub struct Web<F> {
embeddable_on: Embeddable,
web_proxy_tokens: Arc<WebProxyTokens>,
remote: Remote, remote: Remote,
fetch: F, fetch: F,
} }
impl<F: Fetch> Web<F> { impl<F: Fetch> Web<F> {
pub fn boxed(remote: Remote, fetch: F) -> Box<Endpoint> { pub fn boxed(embeddable_on: Embeddable, web_proxy_tokens: Arc<WebProxyTokens>, remote: Remote, fetch: F) -> Box<Endpoint> {
Box::new(Web { Box::new(Web {
embeddable_on: embeddable_on,
web_proxy_tokens: web_proxy_tokens,
remote: remote, remote: remote,
fetch: fetch, fetch: fetch,
}) })
@ -48,20 +60,33 @@ impl<F: Fetch> Endpoint for Web<F> {
path: path, path: path,
remote: self.remote.clone(), remote: self.remote.clone(),
fetch: self.fetch.clone(), fetch: self.fetch.clone(),
web_proxy_tokens: self.web_proxy_tokens.clone(),
embeddable_on: self.embeddable_on.clone(),
}) })
} }
} }
pub struct WebInstaller; struct WebInstaller {
embeddable_on: Embeddable,
}
impl ContentValidator for WebInstaller { impl ContentValidator for WebInstaller {
type Error = String; type Error = String;
fn validate_and_install(&self, _response: fetch::Response) -> Result<LocalPageEndpoint, String> { fn validate_and_install(&self, response: fetch::Response) -> Result<ValidatorResponse, String> {
// let path = unimplemented!(); let status = StatusCode::from_u16(response.status().to_u16());
// let mime = response.content_type().unwrap_or(mime!(Text/Html)); let is_html = response.is_html();
// Ok(LocalPageEndpoint::single_file(path, mime, PageCache::Enabled)) let mime = response.content_type().unwrap_or(mime!(Text/Html));
Err("unimplemented".into()) let mut handler = StreamingHandler::new(
response,
status,
mime,
self.embeddable_on.clone(),
);
if is_html {
handler.set_initial_content(&format!(r#"<script src="/{}/inject.js"></script>"#, apps::UTILS_PATH));
}
Ok(ValidatorResponse::Streaming(handler))
} }
} }
@ -78,46 +103,61 @@ struct WebHandler<F: Fetch> {
path: EndpointPath, path: EndpointPath,
remote: Remote, remote: Remote,
fetch: F, fetch: F,
web_proxy_tokens: Arc<WebProxyTokens>,
embeddable_on: Embeddable,
} }
impl<F: Fetch> WebHandler<F> { impl<F: Fetch> WebHandler<F> {
fn extract_target_url(url: Option<Url>) -> Result<String, State<F>> { fn extract_target_url(&self, url: Option<Url>) -> Result<String, State<F>> {
let path = match url { let (path, query) = match url {
Some(url) => url.path, Some(url) => (url.path, url.query),
None => { None => {
return Err(State::Error( return Err(State::Error(ContentHandler::error(
ContentHandler::error(StatusCode::BadRequest, "Invalid URL", "Couldn't parse URL", None, None) StatusCode::BadRequest, "Invalid URL", "Couldn't parse URL", None, self.embeddable_on.clone()
)); )));
} }
}; };
// TODO [ToDr] Check if token supplied in URL is correct.
// Support domain based routing. // Support domain based routing.
let idx = match path.get(0).map(|m| m.as_ref()) { let idx = match path.get(0).map(|m| m.as_ref()) {
Some(WEB_PATH) => 1, Some(apps::WEB_PATH) => 1,
_ => 0, _ => 0,
}; };
// Check if token supplied in URL is correct.
match path.get(idx) {
Some(ref token) if self.web_proxy_tokens.is_web_proxy_token_valid(token) => {},
_ => {
return Err(State::Error(ContentHandler::error(
StatusCode::BadRequest, "Invalid Access Token", "Invalid or old web proxy access token supplied.", Some("Try refreshing the page."), self.embeddable_on.clone()
)));
}
}
// Validate protocol // Validate protocol
let protocol = match path.get(idx).map(|a| a.as_str()) { let protocol = match path.get(idx + 1).map(|a| a.as_str()) {
Some("http") => "http", Some("http") => "http",
Some("https") => "https", Some("https") => "https",
_ => { _ => {
return Err(State::Error( return Err(State::Error(ContentHandler::error(
ContentHandler::error(StatusCode::BadRequest, "Invalid Protocol", "Invalid protocol used", None, None) StatusCode::BadRequest, "Invalid Protocol", "Invalid protocol used.", None, self.embeddable_on.clone()
)); )));
} }
}; };
// Redirect if address to main page does not end with / // Redirect if address to main page does not end with /
if let None = path.get(idx + 2) { if let None = path.get(idx + 3) {
return Err(State::Redirecting( return Err(State::Redirecting(
Redirection::new(&format!("/{}/", path.join("/"))) Redirection::new(&format!("/{}/", path.join("/")))
)); ));
} }
Ok(format!("{}://{}", protocol, path[2..].join("/"))) let query = match query {
Some(query) => format!("?{}", query),
None => "".into(),
};
Ok(format!("{}://{}{}", protocol, path[idx + 2..].join("/"), query))
} }
} }
@ -126,7 +166,7 @@ impl<F: Fetch> server::Handler<net::HttpStream> for WebHandler<F> {
let url = extract_url(&request); let url = extract_url(&request);
// First extract the URL (reject invalid URLs) // First extract the URL (reject invalid URLs)
let target_url = match Self::extract_target_url(url) { let target_url = match self.extract_target_url(url) {
Ok(url) => url, Ok(url) => url,
Err(error) => { Err(error) => {
self.state = error; self.state = error;
@ -134,12 +174,14 @@ impl<F: Fetch> server::Handler<net::HttpStream> for WebHandler<F> {
} }
}; };
let (mut handler, _control) = ContentFetcherHandler::new( let mut handler = ContentFetcherHandler::new(
target_url, target_url,
self.path.clone(), self.path.clone(),
self.control.clone(), self.control.clone(),
WebInstaller, WebInstaller {
None, embeddable_on: self.embeddable_on.clone(),
},
self.embeddable_on.clone(),
self.remote.clone(), self.remote.clone(),
self.fetch.clone(), self.fetch.clone(),
); );

View File

@ -37,6 +37,11 @@ export default class Signer {
.execute('signer_generateAuthorizationToken'); .execute('signer_generateAuthorizationToken');
} }
generateWebProxyAccessToken () {
return this._transport
.execute('signer_generateWebProxyAccessToken');
}
rejectRequest (requestId) { rejectRequest (requestId) {
return this._transport return this._transport
.execute('signer_rejectRequest', inNumber16(requestId)); .execute('signer_rejectRequest', inNumber16(requestId));

View File

@ -26,6 +26,15 @@ export default {
} }
}, },
generateWebProxyAccessToken: {
desc: 'Generates a new web proxy access token',
params: [],
returns: {
type: String,
desc: 'The new web proxy access token'
}
},
requestsToConfirm: { requestsToConfirm: {
desc: 'Returns a list of the transactions requiring authorization', desc: 'Returns a list of the transactions requiring authorization',
params: [], params: [],

View File

@ -16,9 +16,10 @@
import { import {
Accounts, Account, Addresses, Address, Application, Accounts, Account, Addresses, Address, Application,
Contract, Contracts, WriteContract, Wallet, Dapp, Dapps, Contract, Contracts, Dapp, Dapps,
Settings, SettingsBackground, SettingsParity, SettingsProxy, Settings, SettingsBackground, SettingsParity, SettingsProxy,
SettingsViews, Signer, Status SettingsViews, Signer, Status,
Wallet, Web, WriteContract
} from '~/views'; } from '~/views';
function handleDeprecatedRoute (nextState, replace) { function handleDeprecatedRoute (nextState, replace) {
@ -111,6 +112,7 @@ const routes = [
{ path: 'apps', component: Dapps }, { path: 'apps', component: Dapps },
{ path: 'app/:id', component: Dapp }, { path: 'app/:id', component: Dapp },
{ path: 'web', component: Web },
{ path: 'signer', component: Signer } { path: 'signer', component: Signer }
] ]
} }

View File

@ -56,7 +56,7 @@ class Application extends Component {
render () { render () {
const [root] = (window.location.hash || '').replace('#/', '').split('/'); const [root] = (window.location.hash || '').replace('#/', '').split('/');
const isDapp = root === 'app'; const isMinimized = root === 'app' || root === 'web';
if (inFrame) { if (inFrame) {
return ( return (
@ -66,9 +66,9 @@ class Application extends Component {
return ( return (
<div> <div>
{ isDapp ? this.renderDapp() : this.renderApp() } { isMinimized ? this.renderMinimized() : this.renderApp() }
<Connection /> <Connection />
<ParityBar dapp={ isDapp } /> <ParityBar dapp={ isMinimized } />
</div> </div>
); );
} }
@ -98,7 +98,7 @@ class Application extends Component {
); );
} }
renderDapp () { renderMinimized () {
const { children } = this.props; const { children } = this.props;
return ( return (

View File

@ -39,12 +39,8 @@ export default class Summary extends Component {
return null; return null;
} }
let image = <div className={ styles.image }>&nbsp;</div>; const image = this.renderImage(dappsUrl, app);
if (app.type === 'local') { const link = this.renderLink(app);
image = <img src={ `${dappsUrl}/${app.id}/${app.iconUrl}` } className={ styles.image } />;
} else {
image = <img src={ `${dappsUrl}${app.image}` } className={ styles.image } />;
}
return ( return (
<Container className={ styles.container }> <Container className={ styles.container }>
@ -53,11 +49,7 @@ export default class Summary extends Component {
<div className={ styles.description }> <div className={ styles.description }>
<ContainerTitle <ContainerTitle
className={ styles.title } className={ styles.title }
title={ title={ link }
<Link to={ `/app/${app.id}` }>
{ app.name }
</Link>
}
byline={ app.description } byline={ app.description }
/> />
<div className={ styles.author }> <div className={ styles.author }>
@ -68,4 +60,33 @@ export default class Summary extends Component {
</Container> </Container>
); );
} }
renderImage (dappsUrl, app) {
if (app.type === 'local') {
return (
<img src={ `${dappsUrl}/${app.id}/${app.iconUrl}` } className={ styles.image } />
);
}
return (
<img src={ `${dappsUrl}${app.image}` } className={ styles.image } />
);
}
renderLink (app) {
// Special case for web dapp
if (app.url === 'web') {
return (
<Link to={ `/web` }>
{ app.name }
</Link>
);
}
return (
<Link to={ `/app/${app.id}` }>
{ app.name }
</Link>
);
}
} }

View File

@ -64,5 +64,14 @@
"version": "1.0.0", "version": "1.0.0",
"visible": false, "visible": false,
"secure": true "secure": true
},
{
"id": "0x9042323cd85c6576992d211de34b3ecc183f15e4f639aa87859882f839c374e5",
"url": "web",
"name": "Browser",
"description": "A Web 2.0 hosted pseudo-dapps browser.",
"author": "Parity Team <admin@ethcore.io>",
"version": "1.0.0",
"visible": true
} }
] ]

View File

@ -0,0 +1,110 @@
// Copyright 2015, 2016 Parity Technologies (UK) Ltd.
// This file is part of Parity.
// Parity is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
// Parity is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
// You should have received a copy of the GNU General Public License
// along with Parity. If not, see <http://www.gnu.org/licenses/>.
import React, { Component, PropTypes } from 'react';
import Refresh from 'material-ui/svg-icons/navigation/refresh';
import Close from 'material-ui/svg-icons/navigation/close';
import Subdirectory from 'material-ui/svg-icons/navigation/subdirectory-arrow-left';
import { Button } from '~/ui';
const KEY_ESC = 27;
const KEY_ENTER = 13;
export default class AddressBar extends Component {
static propTypes = {
className: PropTypes.string,
isLoading: PropTypes.bool.isRequired,
onChange: PropTypes.func.isRequired,
onRefresh: PropTypes.func.isRequired,
url: PropTypes.string.isRequired
};
state = {
currentUrl: this.props.url
};
componentWillReceiveProps (nextProps) {
if (this.props.url === nextProps.url) {
return;
}
this.setState({
currentUrl: nextProps.url
});
}
isPristine () {
return this.state.currentUrl === this.props.url;
}
render () {
const { isLoading } = this.props;
const { currentUrl } = this.state;
const isPristine = this.isPristine();
return (
<div className={ this.props.className }>
<Button
disabled={ isLoading }
onClick={ this.onGo }
icon={ isLoading ? <Close /> : <Refresh /> }
/>
<input
onChange={ this.onUpdateUrl }
onKeyDown={ this.onKey }
type='text'
value={ currentUrl }
/>
<Button
disabled={ isPristine }
onClick={ this.onGo }
icon={ <Subdirectory /> }
/>
</div>
);
}
onUpdateUrl = (ev) => {
this.setState({
currentUrl: ev.target.value
});
};
onKey = (ev) => {
const key = ev.which;
if (key === KEY_ESC) {
this.setState({
currentUrl: this.props.url
});
return;
}
if (key === KEY_ENTER) {
this.onGo();
return;
}
};
onGo = () => {
if (this.isPristine()) {
this.props.onRefresh();
} else {
this.props.onChange(this.state.currentUrl);
}
};
}

View File

@ -0,0 +1,17 @@
// Copyright 2015, 2016 Parity Technologies (UK) Ltd.
// This file is part of Parity.
// Parity is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
// Parity is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
// You should have received a copy of the GNU General Public License
// along with Parity. If not, see <http://www.gnu.org/licenses/>.
export default from './addressBar';

17
js/src/views/Web/index.js Normal file
View File

@ -0,0 +1,17 @@
// Copyright 2015, 2016 Parity Technologies (UK) Ltd.
// This file is part of Parity.
// Parity is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
// Parity is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
// You should have received a copy of the GNU General Public License
// along with Parity. If not, see <http://www.gnu.org/licenses/>.
export default from './web';

68
js/src/views/Web/web.css Normal file
View File

@ -0,0 +1,68 @@
/* Copyright 2015, 2016 Ethcore (UK) Ltd.
/* This file is part of Parity.
/*
/* Parity is free software: you can redistribute it and/or modify
/* it under the terms of the GNU General Public License as published by
/* the Free Software Foundation, either version 3 of the License, or
/* (at your option) any later version.
/*
/* Parity is distributed in the hope that it will be useful,
/* but WITHOUT ANY WARRANTY; without even the implied warranty of
/* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
/* GNU General Public License for more details.
/*
/* You should have received a copy of the GNU General Public License
/* along with Parity. If not, see <http://www.gnu.org/licenses/>.
*/
.wrapper {
border: 0;
position: absolute;
height: 100%;
width: 100%;
}
.loading {
text-align: center;
margin-top: 5em;
color: #999;
font-size: 2em;
}
$addressbar: 36px;
.url {
position: absolute;
top: 0;
width: 100%;
box-sizing: border-box;
height: $addressbar;
line-height: $addressbar;
display: flex;
background: rgba(0, 0, 0, 0.85);
> button {
min-width: 50px !important;
}
> input {
flex: 1;
font-size: 1.1em;
padding: 0.2em 0.5em;
border-radius: 0.25em;
border: none;
background: #666;
color: #eee;
outline: none;
box-shadow: 0 0 2px #111 inset;
margin: 2px 0;
}
}
.frame {
position: absolute;
width: 100%;
height: calc(100% - $addressbar);
top: $addressbar;
bottom: 0;
left: 0;
right: 0;
}

118
js/src/views/Web/web.js Normal file
View File

@ -0,0 +1,118 @@
// Copyright 2015, 2016 Parity Technologies (UK) Ltd.
// This file is part of Parity.
// Parity is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
// Parity is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
// You should have received a copy of the GNU General Public License
// along with Parity. If not, see <http://www.gnu.org/licenses/>.
import React, { Component, PropTypes } from 'react';
import store from 'store';
import AddressBar from './AddressBar';
import styles from './web.css';
const LS_LAST_ADDRESS = '_parity::webLastAddress';
export default class Web extends Component {
static contextTypes = {
api: PropTypes.object.isRequired
}
state = {
displayedUrl: this.lastAddress(),
isLoading: true,
token: null,
url: this.lastAddress()
};
componentDidMount () {
this.context.api.signer.generateWebProxyAccessToken().then(token => {
this.setState({ token });
});
}
address () {
const { dappsUrl } = this.context.api;
const { url, token } = this.state;
const path = url.replace(/:/g, '').replace(/\/\//g, '/');
return `${dappsUrl}/web/${token}/${path}/`;
}
lastAddress () {
return store.get(LS_LAST_ADDRESS) || 'https://mkr.market';
}
render () {
const { displayedUrl, isLoading, token } = this.state;
const address = this.address();
if (!token) {
return (
<div className={ styles.wrapper }>
<h1 className={ styles.loading }>
Requesting access token...
</h1>
</div>
);
}
return (
<div className={ styles.wrapper }>
<AddressBar
className={ styles.url }
isLoading={ isLoading }
onChange={ this.handleUpdateUrl }
onRefresh={ this.handleOnRefresh }
url={ displayedUrl }
/>
<iframe
className={ styles.frame }
frameBorder={ 0 }
name={ name }
onLoad={ this.handleIframeLoad }
sandbox='allow-forms allow-same-origin allow-scripts'
scrolling='auto'
src={ address } />
</div>
);
}
handleUpdateUrl = (url) => {
store.set(LS_LAST_ADDRESS, url);
this.setState({
isLoading: true,
displayedUrl: url,
url: url
});
};
handleOnRefresh = (ev) => {
const { displayedUrl } = this.state;
const hasQuery = displayedUrl.indexOf('?') > 0;
const separator = hasQuery ? '&' : '?';
this.setState({
isLoading: true,
url: `${displayedUrl}${separator}t=${Date.now()}`
});
};
handleIframeLoad = (ev) => {
this.setState({
isLoading: false
});
};
}

View File

@ -23,6 +23,7 @@ import Contract from './Contract';
import Contracts from './Contracts'; import Contracts from './Contracts';
import WriteContract from './WriteContract'; import WriteContract from './WriteContract';
import Dapp from './Dapp'; import Dapp from './Dapp';
import Web from './Web';
import Dapps from './Dapps'; import Dapps from './Dapps';
import ParityBar from './ParityBar'; import ParityBar from './ParityBar';
import Settings, { SettingsBackground, SettingsParity, SettingsProxy, SettingsViews } from './Settings'; import Settings, { SettingsBackground, SettingsParity, SettingsProxy, SettingsViews } from './Settings';
@ -49,5 +50,6 @@ export {
SettingsViews, SettingsViews,
Signer, Signer,
Status, Status,
Wallet Wallet,
Web
}; };

View File

@ -21,6 +21,14 @@ import './dev.web3.html';
const http = new Web3.providers.HttpProvider('/rpc/'); const http = new Web3.providers.HttpProvider('/rpc/');
const web3 = new Web3(http); const web3 = new Web3(http);
// set default account
web3.eth.getAccounts((err, accounts) => {
if (err || !accounts || !accounts[0]) {
return;
}
web3.eth.defaultAccount = accounts[0];
});
web3extensions(web3).map((extension) => web3._extend(extension)); web3extensions(web3).map((extension) => web3._extend(extension));

View File

@ -21,6 +21,7 @@ use ethcore::client::Client;
use ethsync::SyncProvider; use ethsync::SyncProvider;
use helpers::replace_home; use helpers::replace_home;
use dir::default_data_path; use dir::default_data_path;
use rpc_apis::SignerService;
use hash_fetch::fetch::Client as FetchClient; use hash_fetch::fetch::Client as FetchClient;
use parity_reactor::Remote; use parity_reactor::Remote;
@ -57,6 +58,7 @@ pub struct Dependencies {
pub sync: Arc<SyncProvider>, pub sync: Arc<SyncProvider>,
pub remote: Remote, pub remote: Remote,
pub fetch: FetchClient, pub fetch: FetchClient,
pub signer: Arc<SignerService>,
} }
pub fn new(configuration: Configuration, deps: Dependencies) -> Result<Option<WebappServer>, String> { pub fn new(configuration: Configuration, deps: Dependencies) -> Result<Option<WebappServer>, String> {
@ -64,7 +66,6 @@ pub fn new(configuration: Configuration, deps: Dependencies) -> Result<Option<We
return Ok(None); return Ok(None);
} }
let signer_address = deps.apis.signer_service.address();
let url = format!("{}:{}", configuration.interface, configuration.port); let url = format!("{}:{}", configuration.interface, configuration.port);
let addr = try!(url.parse().map_err(|_| format!("Invalid Webapps listen host/port given: {}", url))); let addr = try!(url.parse().map_err(|_| format!("Invalid Webapps listen host/port given: {}", url)));
@ -79,7 +80,7 @@ pub fn new(configuration: Configuration, deps: Dependencies) -> Result<Option<We
(username.to_owned(), password) (username.to_owned(), password)
}); });
Ok(Some(try!(setup_dapps_server(deps, configuration.dapps_path, &addr, configuration.hosts, auth, signer_address)))) Ok(Some(try!(setup_dapps_server(deps, configuration.dapps_path, &addr, configuration.hosts, auth))))
} }
pub use self::server::WebappServer; pub use self::server::WebappServer;
@ -97,7 +98,6 @@ mod server {
_url: &SocketAddr, _url: &SocketAddr,
_allowed_hosts: Option<Vec<String>>, _allowed_hosts: Option<Vec<String>>,
_auth: Option<(String, String)>, _auth: Option<(String, String)>,
_signer_address: Option<(String, u16)>,
) -> Result<WebappServer, String> { ) -> Result<WebappServer, String> {
Err("Your Parity version has been compiled without WebApps support.".into()) Err("Your Parity version has been compiled without WebApps support.".into())
} }
@ -126,7 +126,6 @@ mod server {
url: &SocketAddr, url: &SocketAddr,
allowed_hosts: Option<Vec<String>>, allowed_hosts: Option<Vec<String>>,
auth: Option<(String, String)>, auth: Option<(String, String)>,
signer_address: Option<(String, u16)>,
) -> Result<WebappServer, String> { ) -> Result<WebappServer, String> {
use ethcore_dapps as dapps; use ethcore_dapps as dapps;
@ -137,9 +136,12 @@ mod server {
); );
let sync = deps.sync.clone(); let sync = deps.sync.clone();
let client = deps.client.clone(); let client = deps.client.clone();
let signer = deps.signer.clone();
server.with_fetch(deps.fetch.clone()); server.with_fetch(deps.fetch.clone());
server.with_sync_status(Arc::new(move || is_major_importing(Some(sync.status().state), client.queue_info()))); server.with_sync_status(Arc::new(move || is_major_importing(Some(sync.status().state), client.queue_info())));
server.with_signer_address(signer_address); server.with_web_proxy_tokens(Arc::new(move |token| signer.is_valid_web_proxy_access_token(&token)));
server.with_signer_address(deps.signer.address());
let server = rpc_apis::setup_rpc(server, deps.apis.clone(), rpc_apis::ApiSet::UnsafeContext); let server = rpc_apis::setup_rpc(server, deps.apis.clone(), rpc_apis::ApiSet::UnsafeContext);
let start_result = match auth { let start_result = match auth {

View File

@ -370,6 +370,7 @@ pub fn execute(cmd: RunCmd, can_restart: bool, logger: Arc<RotatingLogger>) -> R
sync: sync_provider.clone(), sync: sync_provider.clone(),
remote: event_loop.remote(), remote: event_loop.remote(),
fetch: fetch.clone(), fetch: fetch.clone(),
signer: deps_for_rpc_apis.signer_service.clone(),
}; };
let dapps_server = try!(dapps::new(cmd.dapps_conf.clone(), dapps_deps)); let dapps_server = try!(dapps::new(cmd.dapps_conf.clone(), dapps_deps));

View File

@ -16,28 +16,50 @@
use std::sync::Arc; use std::sync::Arc;
use std::ops::Deref; use std::ops::Deref;
use util::Mutex;
use transient_hashmap::TransientHashMap;
use ethstore::random_string;
use v1::helpers::signing_queue::{ConfirmationsQueue}; use v1::helpers::signing_queue::{ConfirmationsQueue};
const TOKEN_LIFETIME_SECS: u64 = 3600;
/// Manages communication with Signer crate /// Manages communication with Signer crate
pub struct SignerService { pub struct SignerService {
queue: Arc<ConfirmationsQueue>, queue: Arc<ConfirmationsQueue>,
web_proxy_tokens: Mutex<TransientHashMap<String, ()>>,
generate_new_token: Box<Fn() -> Result<String, String> + Send + Sync + 'static>, generate_new_token: Box<Fn() -> Result<String, String> + Send + Sync + 'static>,
address: Option<(String, u16)>, address: Option<(String, u16)>,
} }
impl SignerService { impl SignerService {
/// Creates new Signer Service given function to generate new tokens. /// Creates new Signer Service given function to generate new tokens.
pub fn new<F>(new_token: F, address: Option<(String, u16)>) -> Self pub fn new<F>(new_token: F, address: Option<(String, u16)>) -> Self
where F: Fn() -> Result<String, String> + Send + Sync + 'static { where F: Fn() -> Result<String, String> + Send + Sync + 'static {
SignerService { SignerService {
queue: Arc::new(ConfirmationsQueue::default()), queue: Arc::new(ConfirmationsQueue::default()),
web_proxy_tokens: Mutex::new(TransientHashMap::new(TOKEN_LIFETIME_SECS)),
generate_new_token: Box::new(new_token), generate_new_token: Box::new(new_token),
address: address, address: address,
} }
} }
/// Generates new token. /// Checks if the token is valid web proxy access token.
pub fn is_valid_web_proxy_access_token(&self, token: &String) -> bool {
self.web_proxy_tokens.lock().contains_key(&token)
}
/// Generates a new web proxy access token.
pub fn generate_web_proxy_access_token(&self) -> String {
let token = random_string(16);
let mut tokens = self.web_proxy_tokens.lock();
tokens.prune();
tokens.insert(token.clone(), ());
token
}
/// Generates new signer authorization token.
pub fn generate_token(&self) -> Result<String, String> { pub fn generate_token(&self) -> Result<String, String> {
(self.generate_new_token)() (self.generate_new_token)()
} }

View File

@ -199,5 +199,12 @@ impl<C: 'static, M: 'static> Signer for SignerClient<C, M> where C: MiningBlockC
signer.generate_token() signer.generate_token()
.map_err(|e| errors::token(e)) .map_err(|e| errors::token(e))
} }
fn generate_web_proxy_token(&self) -> Result<String, Error> {
try!(self.active());
let signer = take_weak!(self.signer);
Ok(signer.generate_web_proxy_access_token())
}
} }

View File

@ -23,6 +23,7 @@ use ethcore::client::TestBlockChainClient;
use ethcore::transaction::{Transaction, Action}; use ethcore::transaction::{Transaction, Action};
use rlp::encode; use rlp::encode;
use serde_json;
use jsonrpc_core::{IoHandler, GenericIoHandler}; use jsonrpc_core::{IoHandler, GenericIoHandler};
use v1::{SignerClient, Signer}; use v1::{SignerClient, Signer};
use v1::tests::helpers::TestMinerService; use v1::tests::helpers::TestMinerService;
@ -372,3 +373,29 @@ fn should_generate_new_token() {
// then // then
assert_eq!(tester.io.handle_request_sync(&request), Some(response.to_owned())); assert_eq!(tester.io.handle_request_sync(&request), Some(response.to_owned()));
} }
#[test]
fn should_generate_new_web_proxy_token() {
use jsonrpc_core::{Response, Output, Value};
// given
let tester = signer_tester();
// when
let request = r#"{
"jsonrpc":"2.0",
"method":"signer_generateWebProxyAccessToken",
"params":[],
"id":1
}"#;
let response = tester.io.handle_request_sync(&request).unwrap();
let result = serde_json::from_str(&response).unwrap();
if let Response::Single(Output::Success(ref success)) = result {
if let Value::String(ref token) = success.result {
assert!(tester.signer.is_valid_web_proxy_access_token(&token), "It should return valid web proxy token.");
return;
}
}
assert!(false, "Expected successful response, got: {:?}", result);
}

View File

@ -46,5 +46,9 @@ build_rpc_trait! {
/// Generates new authorization token. /// Generates new authorization token.
#[rpc(name = "signer_generateAuthorizationToken")] #[rpc(name = "signer_generateAuthorizationToken")]
fn generate_token(&self) -> Result<String, Error>; fn generate_token(&self) -> Result<String, Error>;
/// Generates new web proxy access token.
#[rpc(name = "signer_generateWebProxyAccessToken")]
fn generate_web_proxy_token(&self) -> Result<String, Error>;
} }
} }

View File

@ -22,8 +22,8 @@ use std::sync::atomic::{self, AtomicBool};
use futures::{self, BoxFuture, Future}; use futures::{self, BoxFuture, Future};
use futures_cpupool::{CpuPool, CpuFuture}; use futures_cpupool::{CpuPool, CpuFuture};
use mime::{self, Mime};
use reqwest; use reqwest;
pub use mime::Mime;
#[derive(Default, Debug, Clone)] #[derive(Default, Debug, Clone)]
pub struct Abort(Arc<AtomicBool>); pub struct Abort(Arc<AtomicBool>);
@ -47,9 +47,9 @@ pub trait Fetch: Clone + Send + Sync + 'static {
/// Implementation is optional. /// Implementation is optional.
fn process<F>(&self, f: F) -> BoxFuture<(), ()> where fn process<F>(&self, f: F) -> BoxFuture<(), ()> where
F: Future<Item=(), Error=()> + Send + 'static, F: Future<Item=(), Error=()> + Send + 'static,
{ {
f.boxed() f.boxed()
} }
/// Fetch URL and get a future for the result. /// Fetch URL and get a future for the result.
/// Supports aborting the request in the middle of execution. /// Supports aborting the request in the middle of execution.
@ -99,9 +99,9 @@ impl Fetch for Client {
fn process<F>(&self, f: F) -> BoxFuture<(), ()> where fn process<F>(&self, f: F) -> BoxFuture<(), ()> where
F: Future<Item=(), Error=()> + Send + 'static, F: Future<Item=(), Error=()> + Send + 'static,
{ {
self.pool.spawn(f).boxed() self.pool.spawn(f).boxed()
} }
fn fetch_with_abort(&self, url: &str, abort: Abort) -> Self::Result { fn fetch_with_abort(&self, url: &str, abort: Abort) -> Self::Result {
debug!(target: "fetch", "Fetching from: {:?}", url); debug!(target: "fetch", "Fetching from: {:?}", url);
@ -191,6 +191,20 @@ impl Response {
} }
} }
pub fn status(&self) -> reqwest::StatusCode {
match self.inner {
ResponseInner::Response(ref r) => *r.status(),
_ => reqwest::StatusCode::Ok,
}
}
pub fn is_html(&self) -> bool {
match self.content_type() {
Some(Mime(mime::TopLevel::Text, mime::SubLevel::Html, _)) => true,
_ => false,
}
}
pub fn content_type(&self) -> Option<Mime> { pub fn content_type(&self) -> Option<Mime> {
match self.inner { match self.inner {
ResponseInner::Response(ref r) => { ResponseInner::Response(ref r) => {

View File

@ -21,9 +21,12 @@ extern crate log;
extern crate futures; extern crate futures;
extern crate futures_cpupool; extern crate futures_cpupool;
extern crate mime;
extern crate reqwest; extern crate reqwest;
pub extern crate mime;
pub mod client; pub mod client;
pub use self::client::{Client, Fetch, Error, Response, Mime, Abort}; pub use self::reqwest::StatusCode;
pub use self::mime::Mime;
pub use self::client::{Client, Fetch, Error, Response, Abort};

View File

@ -22,8 +22,9 @@ extern crate tokio_core;
use std::thread; use std::thread;
use std::sync::mpsc; use std::sync::mpsc;
use std::time::Duration;
use futures::{Future, IntoFuture}; use futures::{Future, IntoFuture};
use self::tokio_core::reactor::Remote as TokioRemote; use self::tokio_core::reactor::{Remote as TokioRemote, Timeout};
/// Event Loop for futures. /// Event Loop for futures.
/// Wrapper around `tokio::reactor::Core`. /// Wrapper around `tokio::reactor::Core`.
@ -107,6 +108,28 @@ impl Remote {
}, },
} }
} }
/// Spawn a new future and wait for it or for a timeout to occur.
pub fn spawn_with_timeout<F, R, T>(&self, f: F, duration: Duration, on_timeout: T) where
T: FnOnce() -> () + Send + 'static,
F: FnOnce() -> R + Send + 'static,
R: IntoFuture<Item=(), Error=()>,
R::Future: 'static,
{
match self.inner {
Mode::Tokio(ref remote) => remote.spawn(move |handle| {
let future = f().into_future();
let timeout = Timeout::new(duration, handle).expect("Event loop is still up.");
future.select(timeout.then(move |_| {
on_timeout();
Ok(())
})).then(|_| Ok(()))
}),
Mode::Sync => {
let _ = f().into_future().wait();
},
}
}
} }
/// A handle to running event loop. Dropping the handle will cause event loop to finish. /// A handle to running event loop. Dropping the handle will cause event loop to finish.