fix compile warnings (#10993)

* fix warnings

* fix: failing build, use `spec` as dev-dependency

parity/account_utils.rs

@@ -199,14 +199,14 @@ mod accounts {
 		}
 	}
 
-	pub fn private_tx_signer(accounts: Arc<AccountProvider>, passwords: &[Password]) -> Result<Arc<::ethcore_private_tx::Signer>, String> {
+	pub fn private_tx_signer(accounts: Arc<AccountProvider>, passwords: &[Password]) -> Result<Arc<dyn (ethcore_private_tx::Signer)>, String> {
 		Ok(Arc::new(self::private_tx::AccountSigner {
 			accounts,
 			passwords: passwords.to_vec(),
 		}))
 	}
 
-	pub fn accounts_list(account_provider: Arc<AccountProvider>) -> Arc<Fn() -> Vec<Address> + Send + Sync> {
+	pub fn accounts_list(account_provider: Arc<AccountProvider>) -> Arc<dyn Fn() -> Vec<Address> + Send + Sync> {
 		Arc::new(move || account_provider.accounts().unwrap_or_default())
 	}
 

parity/blockchain.rs

@@ -244,7 +244,7 @@ fn execute_import_light(cmd: ImportBlockchain) -> Result<(), String> {
 
 	let client = service.client();
 
-	let mut instream: Box<io::Read> = match cmd.file_path {
+	let mut instream: Box<dyn io::Read> = match cmd.file_path {
 		Some(f) => Box::new(fs::File::open(&f).map_err(|_| format!("Cannot open given file: {}", f))?),
 		None => Box::new(io::stdin()),
 	};
@@ -412,7 +412,7 @@ fn execute_import(cmd: ImportBlockchain) -> Result<(), String> {
 
 	let client = service.client();
 
-	let mut instream: Box<io::Read> = match cmd.file_path {
+	let mut instream: Box<dyn io::Read> = match cmd.file_path {
 		Some(f) => Box::new(fs::File::open(&f).map_err(|_| format!("Cannot open given file: {}", f))?),
 		None => Box::new(io::stdin()),
 	};
@@ -621,7 +621,7 @@ fn execute_export(cmd: ExportBlockchain) -> Result<(), String> {
 
 	let client = service.client();
 
-	let mut out: Box<io::Write> = match cmd.file_path {
+	let mut out: Box<dyn io::Write> = match cmd.file_path {
 		Some(f) => Box::new(fs::File::create(&f).map_err(|_| format!("Cannot write to file given: {}", f))?),
 		None => Box::new(io::stdout()),
 	};
@@ -665,7 +665,7 @@ fn execute_export_state(cmd: ExportState) -> Result<(), String> {
 
 	let client = service.client();
 
-	let mut out: Box<io::Write> = match cmd.file_path {
+	let mut out: Box<dyn io::Write> = match cmd.file_path {
 		Some(f) => Box::new(fs::File::create(&f).map_err(|_| format!("Cannot write to file given: {}", f))?),
 		None => Box::new(io::stdout()),
 	};

parity/db/rocksdb/mod.rs

@@ -37,13 +37,13 @@ mod helpers;
 pub use self::migration::migrate;
 
 struct AppDB {
-	key_value: Arc<KeyValueDB>,
+	key_value: Arc<dyn KeyValueDB>,
 	blooms: blooms_db::Database,
 	trace_blooms: blooms_db::Database,
 }
 
 impl BlockChainDB for AppDB {
-	fn key_value(&self) -> &Arc<KeyValueDB> {
+	fn key_value(&self) -> &Arc<dyn KeyValueDB> {
 		&self.key_value
 	}
 
@@ -58,7 +58,7 @@ impl BlockChainDB for AppDB {
 
 /// Open a secret store DB using the given secret store data path. The DB path is one level beneath the data path.
 #[cfg(feature = "secretstore")]
-pub fn open_secretstore_db(data_path: &str) -> Result<Arc<KeyValueDB>, String> {
+pub fn open_secretstore_db(data_path: &str) -> Result<Arc<dyn KeyValueDB>, String> {
 	use std::path::PathBuf;
 
 	let mut db_path = PathBuf::from(data_path);
@@ -68,7 +68,7 @@ pub fn open_secretstore_db(data_path: &str) -> Result<Arc<KeyValueDB>, String> {
 }
 
 /// Create a restoration db handler using the config generated by `client_path` and `client_config`.
-pub fn restoration_db_handler(client_path: &Path, client_config: &ClientConfig) -> Box<BlockChainDBHandler> {
+pub fn restoration_db_handler(client_path: &Path, client_config: &ClientConfig) -> Box<dyn BlockChainDBHandler> {
 	let client_db_config = helpers::client_db_config(client_path, client_config);
 
 	struct RestorationDBHandler {
@@ -76,7 +76,7 @@ pub fn restoration_db_handler(client_path: &Path, client_config: &ClientConfig)
 	}
 
 	impl BlockChainDBHandler for RestorationDBHandler {
-		fn open(&self, db_path: &Path) -> io::Result<Arc<BlockChainDB>> {
+		fn open(&self, db_path: &Path) -> io::Result<Arc<dyn BlockChainDB>> {
 			open_database(&db_path.to_string_lossy(), &self.config)
 		}
 	}
@@ -87,7 +87,11 @@ pub fn restoration_db_handler(client_path: &Path, client_config: &ClientConfig)
 }
 
 /// Open a new main DB.
-pub fn open_db(client_path: &str, cache_config: &CacheConfig, compaction: &DatabaseCompactionProfile) -> io::Result<Arc<BlockChainDB>> {
+pub fn open_db(
+	client_path: &str,
+	cache_config: &CacheConfig,
+	compaction: &DatabaseCompactionProfile
+) -> io::Result<Arc<dyn BlockChainDB>> {
 	let path = Path::new(client_path);
 
 	let db_config = DatabaseConfig {
@@ -99,7 +103,7 @@ pub fn open_db(client_path: &str, cache_config: &CacheConfig, compaction: &Datab
 	open_database(client_path, &db_config)
 }
 
-pub fn open_database(client_path: &str, config: &DatabaseConfig) -> io::Result<Arc<BlockChainDB>> {
+pub fn open_database(client_path: &str, config: &DatabaseConfig) -> io::Result<Arc<dyn BlockChainDB>> {
 	let path = Path::new(client_path);
 
 	let blooms_path = path.join("blooms");

parity/informant.rs

@@ -124,8 +124,8 @@ pub trait InformantData: Send + Sync {
 /// Informant data for a full node.
 pub struct FullNodeInformantData {
 	pub client: Arc<Client>,
-	pub sync: Option<Arc<SyncProvider>>,
-	pub net: Option<Arc<ManageNetwork>>,
+	pub sync: Option<Arc<dyn SyncProvider>>,
+	pub net: Option<Arc<dyn ManageNetwork>>,
 }
 
 impl InformantData for FullNodeInformantData {
@@ -180,7 +180,7 @@ impl InformantData for FullNodeInformantData {
 
 /// Informant data for a light node -- note that the network is required.
 pub struct LightNodeInformantData {
-	pub client: Arc<LightChainClient>,
+	pub client: Arc<dyn LightChainClient>,
 	pub sync: Arc<LightSync>,
 	pub cache: Arc<Mutex<LightDataCache>>,
 }

parity/ipfs.rs

@@ -40,7 +40,7 @@ impl Default for Configuration {
 	}
 }
 
-pub fn start_server(conf: Configuration, client: Arc<BlockChainClient>) -> Result<Option<Listening>, ServerError> {
+pub fn start_server(conf: Configuration, client: Arc<dyn BlockChainClient>) -> Result<Option<Listening>, ServerError> {
 	if !conf.enabled {
 		return Ok(None);
 	}

parity/light_helpers/epoch_fetch.rs

@@ -35,7 +35,7 @@ use ethereum_types::H256;
 
 const ALL_VALID_BACKREFS: &str = "no back-references, therefore all back-references valid; qed";
 
-type BoxFuture<T, E> = Box<Future<Item = T, Error = E>>;
+type BoxFuture<T, E> = Box<dyn Future<Item = T, Error = E>>;
 
 /// Allows on-demand fetch of data useful for the light client.
 pub struct EpochFetch {
@@ -83,7 +83,7 @@ impl ChainDataFetcher for EpochFetch {
 	}
 
 	/// Fetch epoch transition proof at given header.
-	fn epoch_transition(&self, hash: H256, engine: Arc<Engine>, checker: Arc<StateDependentProof>)
+	fn epoch_transition(&self, hash: H256, engine: Arc<dyn Engine>, checker: Arc<dyn StateDependentProof>)
 		-> Self::Transition
 	{
 		self.request(request::Signal {

parity/modules.rs

@@ -28,9 +28,9 @@ pub use ethcore::client::ChainNotify;
 use ethcore_logger::Config as LogConfig;
 
 pub type SyncModules = (
-	Arc<SyncProvider>,
-	Arc<ManageNetwork>,
-	Arc<ChainNotify>,
+	Arc<dyn SyncProvider>,
+	Arc<dyn ManageNetwork>,
+	Arc<dyn ChainNotify>,
 	mpsc::Sender<sync::PriorityTask>,
 );
 
@@ -38,13 +38,13 @@ pub fn sync(
 	config: SyncConfig,
 	executor: Executor,
 	network_config: NetworkConfiguration,
-	chain: Arc<BlockChainClient>,
-	snapshot_service: Arc<SnapshotService>,
-	private_tx_handler: Option<Arc<PrivateTxHandler>>,
+	chain: Arc<dyn BlockChainClient>,
+	snapshot_service: Arc<dyn SnapshotService>,
+	private_tx_handler: Option<Arc<dyn PrivateTxHandler>>,
 	private_state: Option<Arc<PrivateStateDB>>,
-	provider: Arc<Provider>,
+	provider: Arc<dyn Provider>,
 	_log_settings: &LogConfig,
-	connection_filter: Option<Arc<ConnectionFilter>>,
+	connection_filter: Option<Arc<dyn ConnectionFilter>>,
 ) -> Result<SyncModules, sync::Error> {
 	let eth_sync = EthSync::new(Params {
 		config,
@@ -59,9 +59,9 @@ pub fn sync(
 	connection_filter)?;
 
 	Ok((
-		eth_sync.clone() as Arc<SyncProvider>,
-		eth_sync.clone() as Arc<ManageNetwork>,
-		eth_sync.clone() as Arc<ChainNotify>,
+		eth_sync.clone() as Arc<dyn SyncProvider>,
+		eth_sync.clone() as Arc<dyn ManageNetwork>,
+		eth_sync.clone() as Arc<dyn ChainNotify>,
 		eth_sync.priority_tasks()
 	))
 }

parity/rpc_apis.rs

@@ -235,16 +235,16 @@ pub trait Dependencies {
 pub struct FullDependencies {
 	pub signer_service: Arc<SignerService>,
 	pub client: Arc<Client>,
-	pub snapshot: Arc<SnapshotService>,
-	pub sync: Arc<SyncProvider>,
-	pub net: Arc<ManageNetwork>,
+	pub snapshot: Arc<dyn SnapshotService>,
+	pub sync: Arc<dyn SyncProvider>,
+	pub net: Arc<dyn ManageNetwork>,
 	pub accounts: Arc<AccountProvider>,
 	pub private_tx_service: Option<Arc<PrivateTxService>>,
 	pub miner: Arc<Miner>,
 	pub external_miner: Arc<ExternalMiner>,
 	pub logger: Arc<RotatingLogger>,
 	pub settings: Arc<NetworkSettings>,
-	pub net_service: Arc<ManageNetwork>,
+	pub net_service: Arc<dyn ManageNetwork>,
 	pub updater: Arc<Updater>,
 	pub geth_compatibility: bool,
 	pub experimental_rpcs: bool,
@@ -485,7 +485,7 @@ pub struct LightDependencies<T> {
 	pub signer_service: Arc<SignerService>,
 	pub client: Arc<T>,
 	pub sync: Arc<LightSync>,
-	pub net: Arc<ManageNetwork>,
+	pub net: Arc<dyn ManageNetwork>,
 	pub accounts: Arc<AccountProvider>,
 	pub logger: Arc<RotatingLogger>,
 	pub settings: Arc<NetworkSettings>,

parity/run.rs

@@ -583,7 +583,7 @@ fn execute_impl<Cr, Rr>(cmd: RunCmd, logger: Arc<RotatingLogger>, on_client_rq:
 	// take handle to private transactions service
 	let private_tx_service = service.private_tx_service();
 	let private_tx_provider = private_tx_service.provider();
-	let connection_filter = connection_filter_address.map(|a| Arc::new(NodeFilter::new(Arc::downgrade(&client) as Weak<BlockChainClient>, a)));
+	let connection_filter = connection_filter_address.map(|a| Arc::new(NodeFilter::new(Arc::downgrade(&client) as Weak<dyn BlockChainClient>, a)));
 	let snapshot_service = service.snapshot_service();
 	if let Some(filter) = connection_filter.clone() {
 		service.add_notify(filter.clone());
@@ -636,7 +636,7 @@ fn execute_impl<Cr, Rr>(cmd: RunCmd, logger: Arc<RotatingLogger>, on_client_rq:
 	}
 
 	let (private_tx_sync, private_state) = match cmd.private_tx_enabled {
-		true => (Some(private_tx_service.clone() as Arc<PrivateTxHandler>), Some(private_tx_provider.private_state_db())),
+		true => (Some(private_tx_service.clone() as Arc<dyn PrivateTxHandler>), Some(private_tx_provider.private_state_db())),
 		false => (None, None),
 	};
 
@@ -651,7 +651,7 @@ fn execute_impl<Cr, Rr>(cmd: RunCmd, logger: Arc<RotatingLogger>, on_client_rq:
 		private_state,
 		client.clone(),
 		&cmd.logger_config,
-		connection_filter.clone().map(|f| f as Arc<::sync::ConnectionFilter + 'static>),
+		connection_filter.clone().map(|f| f as Arc<dyn sync::ConnectionFilter + 'static>),
 	).map_err(|e| format!("Sync error: {}", e))?;
 
 	service.add_notify(chain_notify.clone());
@@ -706,7 +706,7 @@ fn execute_impl<Cr, Rr>(cmd: RunCmd, logger: Arc<RotatingLogger>, on_client_rq:
 	// the updater service
 	let updater_fetch = fetch.clone();
 	let updater = Updater::new(
-		&Arc::downgrade(&(service.client() as Arc<BlockChainClient>)),
+		&Arc::downgrade(&(service.client() as Arc<dyn BlockChainClient>)),
 		&Arc::downgrade(&sync_provider),
 		update_policy,
 		hash_fetch::Client::with_fetch(contract_client.clone(), updater_fetch, runtime.executor())
@@ -843,14 +843,14 @@ enum RunningClientInner {
 		rpc: jsonrpc_core::MetaIoHandler<Metadata, informant::Middleware<rpc_apis::LightClientNotifier>>,
 		informant: Arc<Informant<LightNodeInformantData>>,
 		client: Arc<LightClient>,
-		keep_alive: Box<Any>,
+		keep_alive: Box<dyn Any>,
 	},
 	Full {
 		rpc: jsonrpc_core::MetaIoHandler<Metadata, informant::Middleware<informant::ClientNotifier>>,
 		informant: Arc<Informant<FullNodeInformantData>>,
 		client: Arc<Client>,
 		client_service: Arc<ClientService>,
-		keep_alive: Box<Any>,
+		keep_alive: Box<dyn Any>,
 	},
 }
 

parity/secretstore.rs

@@ -93,7 +93,7 @@ pub struct Dependencies<'a> {
 	/// Blockchain client.
 	pub client: Arc<Client>,
 	/// Sync provider.
-	pub sync: Arc<SyncProvider>,
+	pub sync: Arc<dyn SyncProvider>,
 	/// Miner service.
 	pub miner: Arc<Miner>,
 	/// Account provider.