fix compile warnings (#10993)

* fix warnings

* fix: failing build, use `spec` as dev-dependency

rpc/src/v1/tests/helpers/miner_service.rs

@@ -55,7 +55,7 @@ pub struct TestMinerService {
 	/// Minimum gas price
 	pub min_gas_price: RwLock<Option<U256>>,
 	/// Signer (if any)
-	pub signer: RwLock<Option<Box<EngineSigner>>>,
+	pub signer: RwLock<Option<Box<dyn EngineSigner>>>,
 
 	authoring_params: RwLock<AuthoringParams>,
 }
@@ -102,7 +102,7 @@ impl StateClient for TestMinerService {
 }
 
 impl EngineInfo for TestMinerService {
-	fn engine(&self) -> &Engine {
+	fn engine(&self) -> &dyn Engine {
 		unimplemented!()
 	}
 }

rpc/src/v1/tests/mocked/manage_network.rs

@@ -31,5 +31,5 @@ impl ManageNetwork for TestManageNetwork {
 	fn start_network(&self) {}
 	fn stop_network(&self) {}
 	fn num_peers_range(&self) -> RangeInclusive<u32> { 25..=50 }
-	fn with_proto_context(&self, _: ProtocolId, _: &mut FnMut(&NetworkContext)) { }
+	fn with_proto_context(&self, _: ProtocolId, _: &mut dyn FnMut(&dyn NetworkContext)) { }
 }

rpc/src/v1/tests/mocked/parity.rs

@@ -45,7 +45,7 @@ pub struct Dependencies {
 	pub updater: Arc<TestUpdater>,
 	pub logger: Arc<RotatingLogger>,
 	pub settings: Arc<NetworkSettings>,
-	pub network: Arc<ManageNetwork>,
+	pub network: Arc<dyn ManageNetwork>,
 	pub ws_address: Option<Host>,
 }
 

rpc/src/v1/tests/mocked/parity_set.rs

@@ -58,7 +58,7 @@ fn parity_set_client(
 		client,
 		miner,
 		updater,
-		&(net.clone() as Arc<ManageNetwork>),
+		&(net.clone() as Arc<dyn ManageNetwork>),
 		FakeFetch::new(Some(1)),
 	)
 }