grassrootseconomics/openethereum
5
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Revert "temporarily comment out checking zero prefixed int"

Browse Source 
This reverts commit 500dd1480d.
This commit is contained in:
debris 2016-01-27 14:31:43 +01:00
parent 4e52aa8f8a
commit e068bad4e0
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
util/src/bytes.rs
View File

@ -274,8 +274,8 @@ pub enum FromBytesError {
DataIsTooShort,
/// TODO [debris] Please document me
DataIsTooLong,
// Integer-representation is non-canonically prefixed with zero byte(s).
//ZeroPrefixedInt,
/// Integer-representation is non-canonically prefixed with zero byte(s).
ZeroPrefixedInt,
}
impl StdError for FromBytesError {
@ -312,9 +312,9 @@ macro_rules! impl_uint_from_bytes {
match bytes.len() {
0 => Ok(0),
l if l <= mem::size_of::<$to>() => {
//if bytes[0] == 0 {
//return Err(FromBytesError::ZeroPrefixedInt)
//}
if bytes[0] == 0 {
return Err(FromBytesError::ZeroPrefixedInt)
}
let mut res = 0 as $to;
for i in 0..l {
let shift = (l - 1 - i) * 8;
@ -349,10 +349,9 @@ macro_rules! impl_uint_from_bytes {
($name: ident) => {
impl FromBytes for $name {
fn from_bytes(bytes: &[u8]) -> FromBytesResult<$name> {
//if !bytes.is_empty() && bytes[0] == 0 {
//Err(FromBytesError::ZeroPrefixedInt)
//} else
if bytes.len() <= $name::SIZE {
if !bytes.is_empty() && bytes[0] == 0 {
Err(FromBytesError::ZeroPrefixedInt)
} else if bytes.len() <= $name::SIZE {
Ok($name::from(bytes))
} else {
Err(FromBytesError::DataIsTooLong)