grassrootseconomics/openethereum
7
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

warn on double vote

Browse Source
This commit is contained in:
keorn 2016-11-29 12:20:38 +00:00
parent 49b953a9f4
commit e784fa906e
1 changed files with 58 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
ethcore/src/engines/tendermint/vote_collector.rs
View File

@ -104,12 +104,20 @@ impl VoteCollector {
} }
pub fn count_step_votes(&self, height: Height, round: Round, step: Step) -> usize { pub fn count_step_votes(&self, height: Height, round: Round, step: Step) -> usize {
self.votes let guard = self.votes.read();
.read() let current = guard.iter().skip_while(|&(m, _)| !m.is_step(height, round, step));
.keys() let mut origins = HashSet::new();
.skip_while(|m| !m.is_step(height, round, step)) let mut n = 0;
.take_while(|m| m.is_step(height, round, step)) for (message, origin) in current {
.count() if message.is_step(height, round, step) {
if origins.insert(origin) {
n += 1;
} else {
warn!("count_step_votes: authority {} has cast multiple step votes, this indicates malicious behaviour.", origin)
}
}
}
n
} }
} }
@ -120,8 +128,12 @@ mod tests {
use super::super::{Height, Round, BlockHash, Step}; use super::super::{Height, Round, BlockHash, Step};
use super::super::message::ConsensusMessage; use super::super::message::ConsensusMessage;
fn simple_vote(collector: &VoteCollector, signature: H520, h: Height, r: Round, step: Step, block_hash: Option<BlockHash>) -> Option<H160> { fn random_vote(collector: &VoteCollector, signature: H520, h: Height, r: Round, step: Step, block_hash: Option<BlockHash>) -> Option<H160> {
collector.vote(ConsensusMessage { signature: signature, height: h, round: r, step: step, block_hash: block_hash }, H160::default()) full_vote(collector, signature, h, r, step, block_hash, H160::random())
}
fn full_vote(collector: &VoteCollector, signature: H520, h: Height, r: Round, step: Step, block_hash: Option<BlockHash>, address: Address) -> Option<H160> {
collector.vote(ConsensusMessage { signature: signature, height: h, round: r, step: step, block_hash: block_hash }, address)
} }
#[test] #[test]
@ -135,31 +147,31 @@ mod tests {
signatures.push(H520::random()); signatures.push(H520::random());
} }
// Wrong height proposal. // Wrong height proposal.
simple_vote(&collector, signatures[4].clone(), h - 1, r, Step::Propose, bh.clone()); random_vote(&collector, signatures[4].clone(), h - 1, r, Step::Propose, bh.clone());
// Good proposal. // Good proposal.
simple_vote(&collector, signatures[0].clone(), h, r, Step::Propose, bh.clone()); random_vote(&collector, signatures[0].clone(), h, r, Step::Propose, bh.clone());
// Wrong block proposal. // Wrong block proposal.
simple_vote(&collector, signatures[0].clone(), h, r, Step::Propose, Some("0".sha3())); random_vote(&collector, signatures[0].clone(), h, r, Step::Propose, Some("0".sha3()));
// Wrong block precommit. // Wrong block precommit.
simple_vote(&collector, signatures[3].clone(), h, r, Step::Precommit, Some("0".sha3())); random_vote(&collector, signatures[3].clone(), h, r, Step::Precommit, Some("0".sha3()));
// Wrong round proposal. // Wrong round proposal.
simple_vote(&collector, signatures[0].clone(), h, r - 1, Step::Propose, bh.clone()); random_vote(&collector, signatures[0].clone(), h, r - 1, Step::Propose, bh.clone());
// Prevote. // Prevote.
simple_vote(&collector, signatures[0].clone(), h, r, Step::Prevote, bh.clone()); random_vote(&collector, signatures[0].clone(), h, r, Step::Prevote, bh.clone());
// Relevant precommit. // Relevant precommit.
simple_vote(&collector, signatures[2].clone(), h, r, Step::Precommit, bh.clone()); random_vote(&collector, signatures[2].clone(), h, r, Step::Precommit, bh.clone());
// Replcated vote. // Replcated vote.
simple_vote(&collector, signatures[2].clone(), h, r, Step::Precommit, bh.clone()); random_vote(&collector, signatures[2].clone(), h, r, Step::Precommit, bh.clone());
// Wrong round precommit. // Wrong round precommit.
simple_vote(&collector, signatures[4].clone(), h, r + 1, Step::Precommit, bh.clone()); random_vote(&collector, signatures[4].clone(), h, r + 1, Step::Precommit, bh.clone());
// Wrong height precommit. // Wrong height precommit.
simple_vote(&collector, signatures[3].clone(), h + 1, r, Step::Precommit, bh.clone()); random_vote(&collector, signatures[3].clone(), h + 1, r, Step::Precommit, bh.clone());
// Relevant precommit. // Relevant precommit.
simple_vote(&collector, signatures[1].clone(), h, r, Step::Precommit, bh.clone()); random_vote(&collector, signatures[1].clone(), h, r, Step::Precommit, bh.clone());
// Wrong round precommit, same signature. // Wrong round precommit, same signature.
simple_vote(&collector, signatures[1].clone(), h, r + 1, Step::Precommit, bh.clone()); random_vote(&collector, signatures[1].clone(), h, r + 1, Step::Precommit, bh.clone());
// Wrong round precommit. // Wrong round precommit.
simple_vote(&collector, signatures[4].clone(), h, r - 1, Step::Precommit, bh.clone()); random_vote(&collector, signatures[4].clone(), h, r - 1, Step::Precommit, bh.clone());
let seal = SealSignatures { let seal = SealSignatures {
proposal: signatures[0], proposal: signatures[0],
votes: signatures[1..3].to_vec() votes: signatures[1..3].to_vec()
@ -171,22 +183,22 @@ mod tests {
fn count_votes() { fn count_votes() {
let collector = VoteCollector::new(); let collector = VoteCollector::new();
// good prevote // good prevote
simple_vote(&collector, H520::random(), 3, 2, Step::Prevote, Some("0".sha3())); random_vote(&collector, H520::random(), 3, 2, Step::Prevote, Some("0".sha3()));
simple_vote(&collector, H520::random(), 3, 1, Step::Prevote, Some("0".sha3())); random_vote(&collector, H520::random(), 3, 1, Step::Prevote, Some("0".sha3()));
// good precommit // good precommit
simple_vote(&collector, H520::random(), 3, 2, Step::Precommit, Some("0".sha3())); random_vote(&collector, H520::random(), 3, 2, Step::Precommit, Some("0".sha3()));
simple_vote(&collector, H520::random(), 3, 3, Step::Precommit, Some("0".sha3())); random_vote(&collector, H520::random(), 3, 3, Step::Precommit, Some("0".sha3()));
// good prevote // good prevote
simple_vote(&collector, H520::random(), 3, 2, Step::Prevote, Some("1".sha3())); random_vote(&collector, H520::random(), 3, 2, Step::Prevote, Some("1".sha3()));
// good prevote // good prevote
let same_sig = H520::random(); let same_sig = H520::random();
simple_vote(&collector, same_sig.clone(), 3, 2, Step::Prevote, Some("1".sha3())); random_vote(&collector, same_sig.clone(), 3, 2, Step::Prevote, Some("1".sha3()));
simple_vote(&collector, same_sig, 3, 2, Step::Prevote, Some("1".sha3())); random_vote(&collector, same_sig, 3, 2, Step::Prevote, Some("1".sha3()));
// good precommit // good precommit
simple_vote(&collector, H520::random(), 3, 2, Step::Precommit, Some("1".sha3())); random_vote(&collector, H520::random(), 3, 2, Step::Precommit, Some("1".sha3()));
// good prevote // good prevote
simple_vote(&collector, H520::random(), 3, 2, Step::Prevote, Some("0".sha3())); random_vote(&collector, H520::random(), 3, 2, Step::Prevote, Some("0".sha3()));
simple_vote(&collector, H520::random(), 2, 2, Step::Precommit, Some("2".sha3())); random_vote(&collector, H520::random(), 2, 2, Step::Precommit, Some("2".sha3()));
assert_eq!(collector.count_step_votes(3, 2, Step::Prevote), 4); assert_eq!(collector.count_step_votes(3, 2, Step::Prevote), 4);
assert_eq!(collector.count_step_votes(3, 2, Step::Precommit), 2); assert_eq!(collector.count_step_votes(3, 2, Step::Precommit), 2);
@ -204,13 +216,13 @@ mod tests {
#[test] #[test]
fn remove_old() { fn remove_old() {
let collector = VoteCollector::new(); let collector = VoteCollector::new();
simple_vote(&collector, H520::random(), 3, 2, Step::Prevote, Some("0".sha3())); random_vote(&collector, H520::random(), 3, 2, Step::Prevote, Some("0".sha3()));
simple_vote(&collector, H520::random(), 3, 1, Step::Prevote, Some("0".sha3())); random_vote(&collector, H520::random(), 3, 1, Step::Prevote, Some("0".sha3()));
simple_vote(&collector, H520::random(), 3, 3, Step::Precommit, Some("0".sha3())); random_vote(&collector, H520::random(), 3, 3, Step::Precommit, Some("0".sha3()));
simple_vote(&collector, H520::random(), 3, 2, Step::Prevote, Some("1".sha3())); random_vote(&collector, H520::random(), 3, 2, Step::Prevote, Some("1".sha3()));
simple_vote(&collector, H520::random(), 3, 2, Step::Prevote, Some("1".sha3())); random_vote(&collector, H520::random(), 3, 2, Step::Prevote, Some("1".sha3()));
simple_vote(&collector, H520::random(), 3, 2, Step::Prevote, Some("0".sha3())); random_vote(&collector, H520::random(), 3, 2, Step::Prevote, Some("0".sha3()));
simple_vote(&collector, H520::random(), 2, 2, Step::Precommit, Some("2".sha3())); random_vote(&collector, H520::random(), 2, 2, Step::Precommit, Some("2".sha3()));
let message = ConsensusMessage { let message = ConsensusMessage {
signature: H520::default(), signature: H520::default(),
@ -222,4 +234,12 @@ mod tests {
collector.throw_out_old(&message); collector.throw_out_old(&message);
assert_eq!(collector.votes.read().len(), 1); assert_eq!(collector.votes.read().len(), 1);
} }
#[test]
fn malicious_authority() {
let collector = VoteCollector::new();
full_vote(&collector, H520::random(), 3, 2, Step::Prevote, Some("0".sha3()), Address::default());
full_vote(&collector, H520::random(), 3, 2, Step::Prevote, Some("1".sha3()), Address::default());
assert_eq!(collector.count_step_votes(3, 2, Step::Prevote), 1);
}
} }