From eea3de00c1636a84966271597f6f49f14b2f7da4 Mon Sep 17 00:00:00 2001
From: Pierre Krieger <pierre.krieger1708@gmail.com>
Date: Thu, 10 Jan 2019 13:11:39 +0100
Subject: [PATCH] Merge Machine and WithRewards (#10071)

---
 ethcore/src/engines/block_reward.rs |  4 ++--
 ethcore/src/engines/null_engine.rs  |  4 ++--
 ethcore/src/machine.rs              | 12 +++++-------
 machine/src/lib.rs                  | 17 +++++++----------
 4 files changed, 16 insertions(+), 21 deletions(-)

diff --git a/ethcore/src/engines/block_reward.rs b/ethcore/src/engines/block_reward.rs
index 39d1afa7d..42db6889c 100644
--- a/ethcore/src/engines/block_reward.rs
+++ b/ethcore/src/engines/block_reward.rs
@@ -25,7 +25,7 @@ use std::sync::Arc;
 use hash::keccak;
 use error::Error;
 use machine::WithRewards;
-use parity_machine::{Machine, WithBalances};
+use parity_machine::Machine;
 use trace;
 use types::BlockNumber;
 use super::{SystemOrCodeCall, SystemOrCodeCallKind};
@@ -152,7 +152,7 @@ impl BlockRewardContract {
 
 /// Applies the given block rewards, i.e. adds the given balance to each beneficiary' address.
 /// If tracing is enabled the operations are recorded.
-pub fn apply_block_rewards<M: Machine + WithBalances + WithRewards>(
+pub fn apply_block_rewards<M: Machine + WithRewards>(
 	rewards: &[(Address, RewardKind, U256)],
 	block: &mut M::LiveBlock,
 	machine: &M,
diff --git a/ethcore/src/engines/null_engine.rs b/ethcore/src/engines/null_engine.rs
index c62d372e9..4a2610259 100644
--- a/ethcore/src/engines/null_engine.rs
+++ b/ethcore/src/engines/null_engine.rs
@@ -18,7 +18,7 @@ use engines::Engine;
 use engines::block_reward::{self, RewardKind};
 use ethereum_types::U256;
 use machine::WithRewards;
-use parity_machine::{Header, LiveBlock, WithBalances, TotalScoredHeader};
+use parity_machine::{Machine, Header, LiveBlock, TotalScoredHeader};
 use types::BlockNumber;
 
 /// Params for a null engine.
@@ -58,7 +58,7 @@ impl<M: Default> Default for NullEngine<M> {
 	}
 }
 
-impl<M: WithBalances + WithRewards> Engine<M> for NullEngine<M>
+impl<M: Machine + WithRewards> Engine<M> for NullEngine<M>
   where M::ExtendedHeader: TotalScoredHeader,
         <M::ExtendedHeader as TotalScoredHeader>::Value: Ord
 {
diff --git a/ethcore/src/machine.rs b/ethcore/src/machine.rs
index 4ceab9bf0..873262d5d 100644
--- a/ethcore/src/machine.rs
+++ b/ethcore/src/machine.rs
@@ -437,14 +437,7 @@ impl ::parity_machine::Machine for EthereumMachine {
 	type AncestryAction = ::types::ancestry_action::AncestryAction;
 
 	type Error = Error;
-}
 
-impl<'a> ::parity_machine::LocalizedMachine<'a> for EthereumMachine {
-	type StateContext = Call<'a>;
-	type AuxiliaryData = AuxiliaryData<'a>;
-}
-
-impl ::parity_machine::WithBalances for EthereumMachine {
 	fn balance(&self, live: &ExecutedBlock, address: &Address) -> Result<U256, Error> {
 		live.state().balance(address).map_err(Into::into)
 	}
@@ -454,6 +447,11 @@ impl ::parity_machine::WithBalances for EthereumMachine {
 	}
 }
 
+impl<'a> ::parity_machine::LocalizedMachine<'a> for EthereumMachine {
+	type StateContext = Call<'a>;
+	type AuxiliaryData = AuxiliaryData<'a>;
+}
+
 /// A state machine that uses block rewards.
 pub trait WithRewards: ::parity_machine::Machine {
 	/// Note block rewards, traces each reward storing information about benefactor, amount and type
diff --git a/machine/src/lib.rs b/machine/src/lib.rs
index 8a0b5e3f2..b7054ca03 100644
--- a/machine/src/lib.rs
+++ b/machine/src/lib.rs
@@ -112,6 +112,13 @@ pub trait Machine: for<'a> LocalizedMachine<'a> {
 
 	/// Errors which can occur when querying or interacting with the machine.
 	type Error;
+
+	/// Get the balance, in base units, associated with an account.
+	/// Extracts data from the live block.
+	fn balance(&self, live: &Self::LiveBlock, address: &Address) -> Result<U256, Self::Error>;
+
+	/// Increment the balance of an account in the state of the live block.
+	fn add_balance(&self, live: &mut Self::LiveBlock, address: &Address, amount: &U256) -> Result<(), Self::Error>;
 }
 
 /// Machine-related types localized to a specific lifetime.
@@ -123,13 +130,3 @@ pub trait LocalizedMachine<'a>: Sync + Send {
 	/// Generally also provides verifiable proofs.
 	type StateContext: ?Sized + 'a;
 }
-
-/// A state machine that uses balances.
-pub trait WithBalances: Machine {
-	/// Get the balance, in base units, associated with an account.
-	/// Extracts data from the live block.
-	fn balance(&self, live: &Self::LiveBlock, address: &Address) -> Result<U256, Self::Error>;
-
-	/// Increment the balance of an account in the state of the live block.
-	fn add_balance(&self, live: &mut Self::LiveBlock, address: &Address, amount: &U256) -> Result<(), Self::Error>;
-}