From f40e198eb767e342120cedb9bda87c11c348d99f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jochen=20M=C3=BCller?= Date: Fri, 5 Feb 2021 13:33:39 +0100 Subject: [PATCH] Give IoService a consistent interface (#257) The start() method had two different signatures depending on configuration. Since ethcore is built with either config depending on the build target, this resulted in compiler errors for either evmbin or oe. --- crates/runtime/io/src/service_non_mio.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/crates/runtime/io/src/service_non_mio.rs b/crates/runtime/io/src/service_non_mio.rs index 96148a01e..376abb9d9 100644 --- a/crates/runtime/io/src/service_non_mio.rs +++ b/crates/runtime/io/src/service_non_mio.rs @@ -267,7 +267,9 @@ where Message: Send + Sync + 'static, { /// Starts IO event loop - pub fn start() -> Result, IoError> { + pub fn start(_symbolic_name: &'static str) -> Result, IoError> { + // This minimal implementation of IoService does have named Workers + // like the mio-dependent one does, so _symbolic_name is ignored. let (tx, rx) = deque::fifo(); let shared = Arc::new(Shared {