* whisper/cli: add p2p port and ip parameters
This is so that those params don't change randomly and are in sync with the URL that
is displayed.
* feedback: Result instead of panic
Co-Authored-By: gballet <gballet@gmail.com>
* feedback: Map error in port conversion
Co-Authored-By: gballet <gballet@gmail.com>
* whisper/cli: User can specify enode private key
So that the enode doesn't change at every run.
* whipser/cli: finish integrating review feedback.
* Accomodate error API change
* Update rustc-hex version in whisper/cli/Cargo.toml
Co-Authored-By: gballet <gballet@gmail.com>
* Update README with new whisper cli options
* Fix typo in error message
Co-Authored-By: gballet <gballet@gmail.com>
* Fix Cargo.lock and build issue after lib version upgrade
* Fix another typo
Co-Authored-By: gballet <gballet@gmail.com>
* Replace ethcore-logger with env-logger.
* Fix logger initialization in WASM tests.
* uncomment logger initialization in secret store
* Don't use ethcore-logger in whisper.
* Move ethcore-logger within parity dir.
* Uncomment rest from secret-store.
* Use `let _ =` in private_contract for consistency
* `ok()` to `let _ =` fix in service
* Use `let _ = ` for state_db
* Handle graceful shutdown with unwinding
* Fix a race condition
* Avoid double exit deadlock
* typo: fix docs
* Fix ethkey cli compilation
* Fix all other cases panic_hook::set -> panic_hook::set_abort
* struct fields do not need to be public
* Add comments on why exiting AtomicBool is needed
Docopt handles `--help` automatically for us, however we've handled those
Errors the same as all others: by exiting with Return Code `1`, which is wrong
for a totally appropriate a quit on `--help`. Fortunately `docopt:Error`
provides an `exit` helper function that discriminates properly between fatal
and non-fatal errors and exist appropriately.
This patch makes sure we use that handy function in case we encounter such an
error in the CLI of ethkey, ethstore and whisper. Thus those are now giving
the appropriate Return code on `--help`.
fixes#8851
* getting started
* wip wip
* add parsing of pool-size and enable panic-hook
* more cli options
* remove explicit unwrapping
* bump dependencies to parity-jsonrpc
* add tests
* remove tests
* bump jsonrpc
* Remove unused dependencies
* add logging to the cli
* Fix so `FilterManager` drops its resources
* Introduced an AtomicBool flag in FilterManager to cancel the `Decryption Worker Thread`
* Added some very basic test to faulty arguments
* ignore privileged port test