Yurii Rashkovskii 
							
						 
					 
					
						
						
						
						
							
						
						
							18f555464e 
							
						 
					 
					
						
						
							
							Problem: AttachedProtocols don't get registered ( #7610 )  
						
						... 
						
						
						
						I was investigating issues I am having with Whisper support. I've
enabled Whisper on a custom test network and inserted traces into
Whisper handler implementation (Network<T> and NetworkProtocolHandler
for Network<T>) and I noticed that the handler was never invoked.
After further research on this matter, I found out that
AttachedProtocol's register function does nothing:
https://github.com/paritytech/parity/blob/master/sync/src/api.rs#L172 
but there was an implementation originally:
99075ad#diff-5212acb6bcea60e9804ba7b50f6fe6ec and it did the actual
expected logic of registering the protocol in the NetworkService.
However, as of 16d84f8#diff-5212acb6bcea60e9804ba7b50f6fe6ec ("finished
removing ipc") this implementation is gone and only the no-op function
is left.
Which leads me to a conclusion that in fact Whisper's handler never gets
registered in the service and therefore two nodes won't communicate
using it.
Solution: Resurrect original non-empty `AttachedProtocols.register`
implementation
Resolves  #7566  
						
					 
					
						2018-01-19 17:33:49 +01:00 
						 
				 
			
				
					
						
							
							
								Marek Kotewicz 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							d430e7f4e2 
							
						 
					 
					
						
						
							
							Updated dependencies ( #7628 )  
						
						... 
						
						
						
						* Updated few dependencies
* Updated parking_lot to 0.5
* Updated backtrace to 0.3.5
* Updated crossbeam to 0.3 
						
					 
					
						2018-01-19 13:46:11 +01:00 
						 
				 
			
				
					
						
							
							
								Tomasz Drwięga 
							
						 
					 
					
						
						
						
						
							
						
						
							ad44855a1b 
							
						 
					 
					
						
						
							
							Fix Temporarily Invalid blocks handling ( #7613 )  
						
						... 
						
						
						
						* Handle temporarily invalid blocks in sync.
* Fix tests. 
						
					 
					
						2018-01-19 10:38:59 +01:00 
						 
				 
			
				
					
						
							
							
								Tomasz Drwięga 
							
						 
					 
					
						
						
						
						
							
						
						
							f044b61f42 
							
						 
					 
					
						
						
							
							Extract some parts of miner from ethcore. ( #7353 )  
						
						... 
						
						
						
						* Move miner away from ethcore.
* Fix ethcore to use miner/transaction.
* Fix tests and warnings.
* fixed incorrect merge of the test in the documentation 
						
					 
					
						2018-01-11 17:49:10 +01:00 
						 
				 
			
				
					
						
							
							
								Marek Kotewicz 
							
						 
					 
					
						
						
						
						
							
						
						
							e95b093483 
							
						 
					 
					
						
						
							
							dissolve util ( #7460 )  
						
						... 
						
						
						
						* ethereum-types refactor in progress
* ethereum-types refactor in progress
* ethereum-types refactor in progress
* ethereum-types refactor in progress
* ethereum-types refactor finished
* removed obsolete util/src/lib.rs
* removed commented out code 
						
					 
					
						2018-01-10 15:35:18 +03:00 
						 
				 
			
				
					
						
							
							
								Tomasz Drwięga 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							00883e477a 
							
						 
					 
					
						
						
							
							Get rid of clippy remainings.  
						
						
						
					 
					
						2017-12-21 11:27:26 +01:00 
						 
				 
			
				
					
						
							
							
								Arkadiy Paronyan 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							dde6baedec 
							
						 
					 
					
						
						
							
							Removed ethcore-util dependency from ethcore-network ( #7180 )  
						
						... 
						
						
						
						* Removed ethcore-util dependency
* Removed snappy 
						
					 
					
						2017-12-02 10:08:04 +01:00 
						 
				 
			
				
					
						
							
							
								Robert Habermeier 
							
						 
					 
					
						
						
						
						
							
						
						
							81212c5031 
							
						 
					 
					
						
						
							
							Merge branch 'master' into upload-crates  
						
						
						
					 
					
						2017-11-17 16:42:41 +01:00 
						 
				 
			
				
					
						
							
							
								Marek Kotewicz 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							0230a44b15 
							
						 
					 
					
						
						
							
							Merge pull request  #7040  from paritytech/squashed_network_error_chain  
						
						... 
						
						
						
						squashed ethcore-network changes which introduce error-chain 
						
					 
					
						2017-11-15 18:18:25 +01:00 
						 
				 
			
				
					
						
							
							
								debris 
							
						 
					 
					
						
						
						
						
							
						
						
							a22c48b6b0 
							
						 
					 
					
						
						
							
							removed redundant imports  
						
						
						
					 
					
						2017-11-14 17:47:41 +01:00 
						 
				 
			
				
					
						
							
							
								debris 
							
						 
					 
					
						
						
						
						
							
						
						
							3cf52dac59 
							
						 
					 
					
						
						
							
							use error-chain in ethcore-network  
						
						
						
					 
					
						2017-11-13 16:48:58 +01:00 
						 
				 
			
				
					
						
							
							
								Robert Habermeier 
							
						 
					 
					
						
						
						
						
							
						
						
							ec5519ccd1 
							
						 
					 
					
						
						
							
							rename hash crate to keccak-hash  
						
						
						
					 
					
						2017-11-10 20:08:28 +01:00 
						 
				 
			
				
					
						
							
							
								Dmitry Kashitsyn 
							
						 
					 
					
						
						
						
						
							
						
						
							851401dded 
							
						 
					 
					
						
						
							
							Removes obsolete is_valid_node_url()  
						
						
						
					 
					
						2017-11-06 13:01:37 +07:00 
						 
				 
			
				
					
						
							
							
								Dmitry Kashitsyn 
							
						 
					 
					
						
						
						
						
							
						
						
							1516fc1c57 
							
						 
					 
					
						
						
							
							Adds validate_node_url() and refactors boot node check ( #6907 )  
						
						
						
					 
					
						2017-11-06 12:46:11 +07:00 
						 
				 
			
				
					
						
							
							
								Dmitry Kashitsyn 
							
						 
					 
					
						
						
						
						
							
						
						
							7eacef99b9 
							
						 
					 
					
						
						
							
							Removes MAX_TX_TO_IMPORT from ChainSync ( #6976 )  
						
						
						
					 
					
						2017-11-03 13:09:59 +01:00 
						 
				 
			
				
					
						
							
							
								David Dorgan 
							
						 
					 
					
						
						
						
						
							
						
						
							bdf1e6afcc 
							
						 
					 
					
						
						
							
							Revert "Sync parity-ewf with parity"  
						
						... 
						
						
						
						This reverts commit f7ba063b22 
						
					 
					
						2017-10-24 13:31:58 +01:00 
						 
				 
			
				
					
						
							
							
								David Dorgan 
							
						 
					 
					
						
						
						
						
							
						
						
							f7ba063b22 
							
						 
					 
					
						
						
							
							Sync parity-ewf with parity  
						
						
						
					 
					
						2017-10-24 12:31:50 +01:00 
						 
				 
			
				
					
						
							
							
								arkpar 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							3ea9d80859 
							
						 
					 
					
						
						
							
							Tweaked snapshot sync threshold  
						
						
						
					 
					
						2017-10-19 23:11:38 +02:00 
						 
				 
			
				
					
						
							
							
								debris 
							
						 
					 
					
						
						
						
						
							
						
						
							16d84f8ecf 
							
						 
					 
					
						
						
							
							finished removing ipc  
						
						
						
					 
					
						2017-10-16 18:18:43 +02:00 
						 
				 
			
				
					
						
							
							
								debris 
							
						 
					 
					
						
						
						
						
							
						
						
							db3ff67182 
							
						 
					 
					
						
						
							
							Merge branch 'master' into kvdb_split  
						
						
						
					 
					
						2017-10-15 16:40:20 +02:00 
						 
				 
			
				
					
						
							
							
								debris 
							
						 
					 
					
						
						
						
						
							
						
						
							616cafb04a 
							
						 
					 
					
						
						
							
							renamed kvdb_memorydb::in_memory -> kvdb_memorydb::create  
						
						
						
					 
					
						2017-10-15 16:17:15 +02:00 
						 
				 
			
				
					
						
							
							
								Dmitry Kashitsyn 
							
						 
					 
					
						
						
						
						
							
						
						
							74876fd410 
							
						 
					 
					
						
						
							
							Removes redundant mut in sync  
						
						
						
					 
					
						2017-10-15 20:11:20 +07:00 
						 
				 
			
				
					
						
							
							
								debris 
							
						 
					 
					
						
						
						
						
							
						
						
							5c220ab64b 
							
						 
					 
					
						
						
							
							Merge branch 'master' into kvdb_split  
						
						
						
					 
					
						2017-10-13 12:18:49 +02:00 
						 
				 
			
				
					
						
							
							
								Arkadiy Paronyan 
							
						 
					 
					
						
						
						
						
							
						
						
							f3ea2f354e 
							
						 
					 
					
						
						
							
							v1.9.0 ( #6727 )  
						
						
						
					 
					
						2017-10-12 23:44:02 +02:00 
						 
				 
			
				
					
						
							
							
								debris 
							
						 
					 
					
						
						
						
						
							
						
						
							eb526b7769 
							
						 
					 
					
						
						
							
							separated kvdb into 3 crates: kvdb, kvdb-memorydb && kvdb-rocksdb,  #6693  
						
						
						
					 
					
						2017-10-12 15:36:27 +02:00 
						 
				 
			
				
					
						
							
							
								Marek Kotewicz 
							
						 
					 
					
						
						
						
						
							
						
						
							6279ff32f5 
							
						 
					 
					
						
						
							
							Separate migrations from util ( #6690 )  
						
						... 
						
						
						
						* separate migration from util and make its dependencies into libs:
* snappy
* kvdb
* error
* common
* renamed common -> macros
* util error does not depend on snappy module
* ethsync does not depend on util nor ethcore_error
* nibbleslice and nibblevec merged with patricia_trie crate
* removed unused dependencies from util
* util journaldb traits does not need to be public
* util_error
* fixed ethcore compile error
* ignore .swo files
* Update chain.rs 
						
					 
					
						2017-10-10 20:01:27 +02:00 
						 
				 
			
				
					
						
							
							
								Arkadiy Paronyan 
							
						 
					 
					
						
						
						
						
							
						
						
							1b45870af8 
							
						 
					 
					
						
						
							
							Tweaked block download timeouts ( #6595 ) ( #6655 )  
						
						
						
					 
					
						2017-10-06 13:46:11 +02:00 
						 
				 
			
				
					
						
							
							
								Lorenzo Manacorda 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							5f025cc1b8 
							
						 
					 
					
						
						
							
							Rename Requests to Batch  
						
						
						
					 
					
						2017-09-24 20:09:30 +02:00 
						 
				 
			
				
					
						
							
							
								Arkadiy Paronyan 
							
						 
					 
					
						
						
						
						
							
						
						
							684b142711 
							
						 
					 
					
						
						
							
							Sync progress and error handling fixes ( #6560 )  
						
						
						
					 
					
						2017-09-21 10:12:27 +02:00 
						 
				 
			
				
					
						
							
							
								Hawstein 
							
						 
					 
					
						
						
						
						
							
						
						
							ade37be25b 
							
						 
					 
					
						
						
							
							separate trie from util and make its dependencies into libs:  
						
						... 
						
						
						
						* bytes
* hashdb
* memorydb
* nibbleslice
* nibblevec 
						
					 
					
						2017-09-15 11:03:53 +08:00 
						 
				 
			
				
					
						
							
							
								Robert Habermeier 
							
						 
					 
					
						
						
						
						
							
						
						
							375668bc40 
							
						 
					 
					
						
						
							
							Compatibility with whisper v6 ( #6179 )  
						
						... 
						
						
						
						* compatibility with whisper v6
* separate subprotocol for parity extensions
* kill version field 
						
					 
					
						2017-09-10 18:02:14 +02:00 
						 
				 
			
				
					
						
							
							
								Robert Habermeier 
							
						 
					 
					
						
						
						
						
							
						
						
							ad39446e87 
							
						 
					 
					
						
						
							
							Revert "fixed master ( #6465 )"  
						
						... 
						
						
						
						This reverts commit 899538ae25 
						
					 
					
						2017-09-05 17:54:05 +02:00 
						 
				 
			
				
					
						
							
							
								Marek Kotewicz 
							
						 
					 
					
						
						
						
						
							
						
						
							899538ae25 
							
						 
					 
					
						
						
							
							fixed master ( #6465 )  
						
						... 
						
						
						
						* fixed master
* Revert "Merge pull request #6370  from paritytech/light-poa"
This reverts commit 3c60f99defb731ccea18 
						
					 
					
						2017-09-05 14:53:09 +02:00 
						 
				 
			
				
					
						
							
							
								Fredrik Harrysson 
							
						 
					 
					
						
						
						
						
							
						
						
							dccdedc001 
							
						 
					 
					
						
						
							
							Merge branch 'master' into fo-6418-dont-export-bigint  
						
						
						
					 
					
						2017-09-05 10:48:54 +02:00 
						 
				 
			
				
					
						
							
							
								Fredrik 
							
						 
					 
					
						
						
						
						
							
						
						
							e54784bfeb 
							
						 
					 
					
						
						
							
							Merge branch 'master' into fo-6418-dont-export-bigint  
						
						... 
						
						
						
						# Conflicts:
#	dapps/src/tests/helpers/registrar.rs
#	ethcore/evm/src/interpreter/shared_cache.rs
#	ethcore/light/src/client/header_chain.rs
#	ethcore/light/src/client/mod.rs
#	ethcore/light/src/net/mod.rs
#	ethcore/light/src/on_demand/request.rs
#	ethcore/light/src/on_demand/tests.rs
#	ethcore/light/src/provider.rs
#	ethcore/node_filter/src/lib.rs
#	ethcore/src/block.rs
#	ethcore/src/blockchain/blockchain.rs
#	ethcore/src/client/test_client.rs
#	ethcore/src/engines/authority_round/mod.rs
#	ethcore/src/engines/basic_authority.rs
#	ethcore/src/engines/mod.rs
#	ethcore/src/engines/tendermint/mod.rs
#	ethcore/src/engines/validator_set/contract.rs
#	ethcore/src/engines/validator_set/multi.rs
#	ethcore/src/engines/validator_set/safe_contract.rs
#	ethcore/src/engines/vote_collector.rs
#	ethcore/src/miner/external.rs
#	ethcore/src/miner/miner.rs
#	ethcore/src/miner/service_transaction_checker.rs
#	ethcore/src/miner/work_notify.rs
#	ethcore/src/pod_account.rs
#	ethcore/src/pod_state.rs
#	ethcore/src/snapshot/block.rs
#	ethcore/src/snapshot/consensus/work.rs
#	ethcore/src/snapshot/mod.rs
#	ethcore/src/snapshot/service.rs
#	ethcore/src/spec/spec.rs
#	ethcore/src/state/backend.rs
#	ethcore/src/trace/db.rs
#	ethcore/src/verification/queue/mod.rs
#	ethcore/src/verification/verification.rs
#	parity/informant.rs
#	rpc/src/v1/helpers/dispatch.rs
#	rpc/src/v1/helpers/light_fetch.rs
#	rpc/src/v1/helpers/signing_queue.rs
#	rpc/src/v1/impls/eth.rs
#	rpc/src/v1/impls/eth_filter.rs
#	rpc/src/v1/impls/eth_pubsub.rs
#	rpc/src/v1/impls/light/eth.rs
#	rpc/src/v1/impls/signing.rs
#	rpc/src/v1/tests/helpers/miner_service.rs
#	rpc/src/v1/tests/helpers/snapshot_service.rs
#	rpc/src/v1/tests/helpers/sync_provider.rs
#	rpc/src/v1/tests/mocked/eth.rs
#	stratum/src/lib.rs
#	sync/src/blocks.rs
#	sync/src/chain.rs
#	sync/src/light_sync/mod.rs
#	sync/src/tests/helpers.rs
#	sync/src/tests/snapshot.rs
#	updater/src/updater.rs
#	util/src/lib.rs
#	util/triehash/src/lib.rs 
						
					 
					
						2017-09-04 18:32:55 +02:00 
						 
				 
			
				
					
						
							
							
								Fredrik 
							
						 
					 
					
						
						
						
						
							
						
						
							308f36a532 
							
						 
					 
					
						
						
							
							Don't reexport bigint from util  
						
						
						
					 
					
						2017-09-04 16:36:49 +02:00 
						 
				 
			
				
					
						
							
							
								Robert Habermeier 
							
						 
					 
					
						
						
						
						
							
						
						
							372779915f 
							
						 
					 
					
						
						
							
							Merge branch 'master' into light-poa  
						
						
						
					 
					
						2017-09-04 12:30:37 +02:00 
						 
				 
			
				
					
						
							
							
								Marek Kotewicz 
							
						 
					 
					
						
						
						
						
							
						
						
							b731ccea18 
							
						 
					 
					
						
						
							
							triehash is separated from util ( #6428 )  
						
						
						
					 
					
						2017-09-03 09:11:14 +02:00 
						 
				 
			
				
					
						
							
							
								Hawstein 
							
						 
					 
					
						
						
						
						
							
						
						
							7b8af30590 
							
						 
					 
					
						
						
							
							remove re-export of parking_lot in util ( #6435 )  
						
						
						
					 
					
						2017-09-02 20:09:13 +02:00 
						 
				 
			
				
					
						
							
							
								debris 
							
						 
					 
					
						
						
						
						
							
						
						
							94f717a255 
							
						 
					 
					
						
						
							
							Merge branch 'master' into keccak_fn  
						
						
						
					 
					
						2017-08-31 11:53:26 +02:00 
						 
				 
			
				
					
						
							
							
								debris 
							
						 
					 
					
						
						
						
						
							
						
						
							7849fff41e 
							
						 
					 
					
						
						
							
							finished  
						
						
						
					 
					
						2017-08-31 11:35:41 +02:00 
						 
				 
			
				
					
						
							
							
								Robert Habermeier 
							
						 
					 
					
						
						
						
						
							
						
						
							abfa8e95a2 
							
						 
					 
					
						
						
							
							Merge branch 'master' into light-poa  
						
						
						
					 
					
						2017-08-30 18:18:52 +02:00 
						 
				 
			
				
					
						
							
							
								Axel Chalon 
							
						 
					 
					
						
						
						
						
							
						
						
							6b5ad69c22 
							
						 
					 
					
						
						
							
							Remove reexport of HeapSizeOf in util ( #6419 )  
						
						
						
					 
					
						2017-08-30 16:04:47 +02:00 
						 
				 
			
				
					
						
							
							
								Robert Habermeier 
							
						 
					 
					
						
						
						
						
							
						
						
							d3c3e0b164 
							
						 
					 
					
						
						
							
							Merge branch 'master' into light-poa  
						
						
						
					 
					
						2017-08-29 15:14:58 +02:00 
						 
				 
			
				
					
						
							
							
								Arkadiy Paronyan 
							
						 
					 
					
						
						
						
						
							
						
						
							d520aa2633 
							
						 
					 
					
						
						
							
							Connection filter ( #6359 )  
						
						
						
					 
					
						2017-08-29 14:38:01 +02:00 
						 
				 
			
				
					
						
							
							
								Robert Habermeier 
							
						 
					 
					
						
						
						
						
							
						
						
							b953f9b66a 
							
						 
					 
					
						
						
							
							glue for fetching epoch proofs from network  
						
						
						
					 
					
						2017-08-24 15:17:48 +02:00 
						 
				 
			
				
					
						
							
							
								Arkadiy Paronyan 
							
						 
					 
					
						
						
						
						
							
						
						
							d41dd13918 
							
						 
					 
					
						
						
							
							Tweaked snapshot params ( #6344 )  
						
						
						
					 
					
						2017-08-22 11:24:56 +02:00 
						 
				 
			
				
					
						
							
							
								Tomasz Drwięga 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							73644adf69 
							
						 
					 
					
						
						
							
							Rename network_id to chain_id where applicable.  
						
						
						
					 
					
						2017-08-21 14:23:10 +02:00 
						 
				 
			
				
					
						
							
							
								Tomasz Drwięga 
							
						 
					 
					
						
						
						
						
							
						
						
							f157461ee1 
							
						 
					 
					
						
						
							
							Multi-call RPC ( #6195 )  
						
						... 
						
						
						
						* Removing duplicated pending state accessors in miner.
* Merge miner+client call.
* Multicall & multicall RPC.
* Sensible defaults.
* Fix tests. 
						
					 
					
						2017-08-04 15:58:14 +02:00 
						 
				 
			
				
					
						
							
							
								debris 
							
						 
					 
					
						
						
						
						
							
						
						
							88cc4cd17a 
							
						 
					 
					
						
						
							
							Merge branch 'master' into split  
						
						
						
					 
					
						2017-07-29 23:44:55 +02:00