a04c5b180a
* WIP * Replace Rlp with UntrustedRlp in views, explicity unwrap with expect First pass to get it to compile. Need to figure out whether to do this or to propogate Errors upstream, which would require many more changes to dependent code. If we do this way we are assuming that the views are always used in a context where the rlp is trusted to be valid e.g. when reading from our own DB. So need to fid out whether views are used with data received from an untrusted (e.g. extrernal peer). * Remove original Rlp impl, rename UntrustedRlp -> Rlp * Create rlp views with view! macro to record debug info Views are assumed to be over valid rlp, so if there is a decoding error we record where the view was created in the first place and report it in the expect * Use $crate in view! macro to avoid import, fix tests * Expect valid rlp in decode functions for now * Replace spaces with tabs in new file * Add doc tests for creating views with macro * Update rlp docs to reflect removing of UntrustedRlp * Replace UntrustedRlp usages in private-tx merge
41 lines
1.3 KiB
Rust
41 lines
1.3 KiB
Rust
// Copyright 2015-2017 Parity Technologies (UK) Ltd.
|
|
// This file is part of Parity.
|
|
|
|
// Parity is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// Parity is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Parity. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
//! Block oriented views onto rlp.
|
|
|
|
#[macro_use]
|
|
mod view_rlp;
|
|
mod block;
|
|
mod body;
|
|
mod header;
|
|
mod transaction;
|
|
|
|
pub use self::view_rlp::ViewRlp;
|
|
pub use self::block::BlockView;
|
|
pub use self::body::BodyView;
|
|
pub use self::header::HeaderView;
|
|
pub use self::transaction::TransactionView;
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::HeaderView;
|
|
|
|
#[test]
|
|
#[should_panic(expected="View rlp is trusted and should be valid. Constructed in ethcore/src/views/mod.rs on line 39: RlpExpectedToBeList")]
|
|
fn should_include_file_line_number_in_panic_for_invalid_rlp() {
|
|
let _ = view!(HeaderView, &[]).parent_hash();
|
|
}
|
|
} |