openethereum/ethcore/src/client
David de906d4afd
Improve logging and cleanup in miner around block sealing (#10745)
* Stop breaking out of loop if a non-canonical hash is found

* include expected hash in log msg

* More logging

* Scope

* Syntax

* Log in blank RollingFinality
Escalate bad proposer to warning

* Check validator set size: warn if 1 or even number

* More readable code

* Use SimpleList::new

* Extensive logging on unexpected non-canonical hash

* Wording

* wip

* Update ethcore/blockchain/src/blockchain.rs

Co-Authored-By: Tomasz Drwięga <tomusdrw@users.noreply.github.com>

* Improved logging, address grumbles

* Update ethcore/src/engines/validator_set/simple_list.rs

Co-Authored-By: Luke Schoen <ltfschoen@users.noreply.github.com>

* Report benign misbehaviour iff currently a validator

* Report malicious behaviour iff we're a validator

* Escalate to warning and fix wording

* Test reporting behaviour
Don't require node to be part of the validator set to report malicious behaviour

* Include missing parent hash in MissingParent error

* Update ethcore/src/engines/validator_set/simple_list.rs

Co-Authored-By: Luke Schoen <ltfschoen@users.noreply.github.com>

* docs

* remove unneeded into()
Move check for parent_step == step for clarity&efficiency
Remove dead code for Seal::Proposal

* typo

* Wording

* naming

* WIP

* cleanup

* cosmetics

* cosmetics and one less lvar

* spelling

* Better loggin when a block is already in chain

* More logging

* On second thought non-validators are allowed to report

* cleanup

* remove dead code

* Keep track of the hash of the last imported block

* Let it lock

* Serialize access to block sealing

* Take a lock while sealing a block

* Cleanup

* whitespace
2019-07-04 18:03:22 +02:00
..
ancient_import.rs removed EthEngine alias (#10805) 2019-06-28 10:18:18 +02:00
bad_blocks.rs misc: bump license header to 2019 (#10135) 2019-01-07 11:33:07 +01:00
chain_notify.rs misc: bump license header to 2019 (#10135) 2019-01-07 11:33:07 +01:00
client.rs Improve logging and cleanup in miner around block sealing (#10745) 2019-07-04 18:03:22 +02:00
config.rs misc: bump license header to 2019 (#10135) 2019-01-07 11:33:07 +01:00
evm_test_client.rs Upgrade ethereum types (#10670) 2019-06-03 15:36:21 +02:00
io_message.rs Fix deprectation warnings on nightly (#10746) 2019-06-14 18:48:35 +02:00
mod.rs Refactor ethcore::client::TransactResult to use it inside std::result::Result (#10366) 2019-02-26 13:49:33 +01:00
private_notify.rs misc: bump license header to 2019 (#10135) 2019-01-07 11:33:07 +01:00
test_client.rs Break circular dependency between Client and Engine (part 1) (#10833) 2019-07-04 13:43:20 +02:00
trace.rs Fix deprectation warnings on nightly (#10746) 2019-06-14 18:48:35 +02:00
traits.rs removed additional_params method (#10818) 2019-06-29 09:31:15 +02:00