grassrootseconomics/sarafu-api
8
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

dev-api-aliases #5

Merged
lash merged 6 commits from dev-api-aliases into master 2025-01-21 07:17:09 +01:00
Conversation 1 Commits 6 Files Changed 3 +170 -110
carlos commented 2025-01-20 15:39:35 +01:00
Member
Copy Link

PR Change:

  • Persists account aliases for the local dev api.

  • Implements RequestAlias for the HTTPAccountService

PR Change: - Persists account aliases for the local dev api. - Implements RequestAlias for the HTTPAccountService
carlos added 2 commits 2025-01-20 15:39:35 +01:00
persist aliases,construct the fqdn 23b4180e50
implement request alias 8a47d1d674
lash requested changes 2025-01-20 16:25:11 +01:00
dev/api.go Outdated
@@ -26,2 +26,3 @@
logg = logging.NewVanilla().WithDomain("sarafu-api.devapi")
logg = logging.NewVanilla().WithDomain("sarafu-api.devapi")
aliasRegex = regexp.MustCompile("^\\+?[a-zA-Z0-9\\-_]+$")
searchDomain = ".sarafu.local"
lash commented 2025-01-20 15:44:43 +01:00
Owner
Copy Link

Export please

Export please
carlos commented 2025-01-20 18:24:04 +01:00
Author
Member
Copy Link

@lash Should be moved to: https://git.grassecon.net/grassrootseconomics/common?

@lash Should be moved to: https://git.grassecon.net/grassrootseconomics/common?
lash commented 2025-01-20 18:31:04 +01:00
Owner
Copy Link

no its fine here, it's for dev only anyway.

no its fine here, it's for dev only anyway.
dev/api.go
@@ -108,0 +105,4 @@
defaultAccount string
emitterFunc event.EmitterFunc
pfx []byte
// accountsSession map[string]string
lash commented 2025-01-20 15:45:04 +01:00
Owner
Copy Link

remove commentedp lease

remove commentedp lease
dev/api.go Outdated
@@ -329,0 +348,4 @@
if err != nil {
return err
}
das.db.SetSession("")
lash commented 2025-01-20 15:46:15 +01:00
Owner
Copy Link

This is probably not correct? Alias is bound to a session, right?

This is probably not correct? Alias is bound to a session, right?
carlos commented 2025-01-20 18:22:39 +01:00
Author
Member
Copy Link

Yeah that's right.Resolved by: ed549cba70

Yeah that's right.Resolved by: ed549cba7046818638f28ce28fae15c3eb344bc8
👍 1
dev/api.go Outdated
@@ -408,1 +432,3 @@
Balance: strconv.Itoa(v),
TokenSymbol: voucher.Symbol,
TokenDecimals: strconv.Itoa(voucher.Decimals),
Balance: strconv.Itoa(500),
lash commented 2025-01-20 15:51:15 +01:00
Owner
Copy Link

Why hardcoded number?

Why hardcoded number?
remote/http/service.go Outdated
@@ -19,1 +20,4 @@
var (
aliasRegex = regexp.MustCompile("^\\+?[a-zA-Z0-9\\-_]+$")
searchDomain = ".sarafu.eth"
lash commented 2025-01-20 15:52:11 +01:00
Owner
Copy Link

THe searchdomain should not be necessary here

THe searchdomain should not be necessary here
remote/http/service.go
@@ -221,3 +227,4 @@
}
// TODO: Use actual custodial api to request available alias
func (as *HTTPAccountService) RequestAlias(ctx context.Context, publicKey string, hint string) (*models.RequestAliasResult, error) {
lash commented 2025-01-20 15:52:31 +01:00
Owner
Copy Link

Can't we just point this to devapi.RequestAlias?

Can't we just point this to devapi.RequestAlias?
carlos commented 2025-01-20 18:19:48 +01:00
Author
Member
Copy Link

@lash Nice catch.Actually that brings up an idea,could we use the same implementation of the devapi to resolve the alias' address given that the api always returns the same address?

@lash Nice catch.Actually that brings up an idea,could we use the same implementation of the devapi to resolve the alias' address given that the api always returns the same address?
lash commented 2025-01-20 18:30:29 +01:00
Owner
Copy Link

yes for sure, while we wait or the api implementation.

yes for sure, while we wait or the api implementation.
👍 1
carlos added 2 commits 2025-01-20 18:13:12 +01:00
bind session id for aliases,soft code voucher balance ed549cba70
implement request alias based on dev implementation 99c704f6ff
carlos added 1 commit 2025-01-20 20:28:38 +01:00
handle accounts created via the api,add getter for the account aliases fa355e3729
carlos added 1 commit 2025-01-21 06:45:20 +01:00
fix failing test a63164bcf5
lash merged commit a4cc7d2a98 into master 2025-01-21 07:17:09 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
lash
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Alfred-mk amina carlos kamikazechaser lash mango-habanero williamluke willruddick
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: grassrootseconomics/sarafu-api#5
Delete Branch "dev-api-aliases"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?