grassrootseconomics/sarafu-api
8
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases Wiki Activity

dev-api-aliases-v2 #6

Merged
lash merged 5 commits from dev-api-aliases-v2 into master 2025-01-23 15:28:06 +01:00
Conversation 1 Commits 5 Files Changed 4 +24 -13
carlos commented 2025-01-23 13:02:46 +01:00
Member
Copy Link

PR Change

  • HTTPAccountService
    - Adds a UseApi bool field that allows switching between a local and remote api to resolve alias address
    - Adds a field to reference the StorageService.

  • Unties the assigned alias to a specific session id.

**PR Change** - HTTPAccountService - Adds a UseApi bool field that allows switching between a local and remote api to resolve alias address - Adds a field to reference the StorageService. - Unties the assigned alias to a specific session id.
carlos added 5 commits 2025-01-23 13:02:46 +01:00
use dev storage service 9c75109b75
dep: downgrade vise-driver bc7afa50a4
resolve alias address based on UseApi field 3f9dc89a40
run go mod tidy 4ae0a484f4
untie session id to saved aliases 448fdffbd0
lash reviewed 2025-01-23 14:09:58 +01:00
dev/api.go
@@ -356,4 +352,3 @@
if err != nil {
return err
}
das.db.SetSession(sessionId)
lash commented 2025-01-23 14:09:55 +01:00
Owner
Copy Link

Please explain this change?

Please explain this change?
carlos commented 2025-01-23 14:51:26 +01:00
Author
Member
Copy Link

When the alias is saved,it will need to be retrieved by any other session id during Send.So when resolving the alias address,we don't really yet know the exact session id the alias belongs to beforehand.It made sense to me to keep this as an independent record that would be resolved in a similar way that we check if a certain public key is in the list of created accounts.

When the alias is saved,it will need to be retrieved by any other session id during Send.So when resolving the alias address,we don't really yet know the exact session id the alias belongs to beforehand.It made sense to me to keep this as an independent record that would be resolved in a similar way that we check if a certain public key is in the list of created accounts.
lash marked this conversation as resolved
lash merged commit 2181388f5b into master 2025-01-23 15:28:06 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
lash
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Alfred-mk amina carlos kamikazechaser lash mango-habanero williamluke willruddick
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: grassrootseconomics/sarafu-api#6
Delete Branch "dev-api-aliases-v2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?