No Branch/Tag Specified
master
send-max-amount-hotfix
shorten-menus
allow-stables-direct-to-mpesa
debt-menu
credit-send-pool-selection-hotfix
have-single-send-node
self-pin-reset
cache-error-fix
mpesa-onramp-offramp
update-balance-on-empty-vouchers
cached_symbols_hotfix
update-go-vise
credit-send-hotfix
send-with-swap
pool-debug
handle-error-codes
normalize-symbols-on-api
ui-cleanup-update
sync-flags
exclude-active-data-from-lists
move-pools-menu
project-tidyup
new-alias-flow
add-balance-to-voucher-list
update-alias
fix-amount-conversion
cosmetic-fixes
hotfix/v1.2.5-rc.1
add-pool-selection
swap-fix
hotfix/v1.2.5-rc
default-env-pool
alfred/pool-swap
sohail/experimental
vouchers-input-selection
checksum-address
alias-register-enhancement
route-api-errors
logdb
extra-sms
update-recipient-validator
update-userdata-devtool
self-pin-reset-node
sms-upsell
lash/attack-of-the-clones
manage-vouchers-in-single-function
address-sms
help-menu
fix-double-alias-request
lash/reset
fix-multiple-alias-requests
active-sym-debug
test-coverage-bump
ens
fix-pin-reset-bug
remove-session-id-from-ctx
tests-menu-traversal
alfred/test-updates
debug-errors-with-temporary-value
clear-temporary-valua-after-use
lash/custom-engin
lash/async-inputs
reset-execpath
menu-invalid-inputs
minor-bug-fixes
update-dependency
alias-fqdn
fix-remote-new-args
lash/dbtx
reset-account-blocked-flag
data-migration
encrypt-pin
lash/update-dump
lash/admin-tool
contact-info-on-pending-page
lash/fix-ssh
lash/api-select
lash/initial-language
lash/dev-api-buildtag
lash/events
v1.4.7-rc.6
v1.4.7-rc.5
v1.4.7-rc.4
v1.4.7-rc.3
v1.4.7-rc.2
v1.4.7-rc.1
v1.4.7-rc
v1.4.6-rc.12
v1.4.6-rc.11
v1.4.6-rc.9
v1.4.6-rc.8
v1.4.6-rc.7
v1.4.6-rc.6
v1.4.6-rc.5
v1.4.6-rc.4
v1.4.6-rc.3
v1.4.6-rc.2
v1.4.6-rc.1
v1.4.6-rc
v1.4.4-rc.10
v1.4.4-rc.9
v1.4.4-rc.8
v1.4.4-rc.7
v1.4.4-rc.6
v1.4.4-rc.5
v1.4.4-rc.4
v1.4.4-rc.3
v1.4.5-rc.1
v1.4.5-rc
v1.4.4-rc.2
v1.4.4-rc.1
v1.4.4-rc
v1.4.3-rc.1
v1.4.3-rc
v1.4.2-rc.7
v1.4.2-rc.6
v1.4.2-rc.5
v1.4.2-rc.4
v1.4.2-rc.3
v1.4.2-rc.2
v1.4.2-rc.1
v1.4.1-rc.4
v1.4.1-rc.3
v1.4.2-rc
v1.4.1-rc.2
v1.4.1-rc.1
v1.4.1-rc
v1.4.0-rc
v1.3.9-rc
v1.3.8-rc.1
v1.3.8-rc
v1.3.7-rc.1
v1.3.7-rc
v1.3.6-rc
v1.3.5-rc
v1.3.4-rc.1
v1.3.4-rc
v1.3.3-rc.7
v1.3.3-rc.6
v1.3.3-rc.5
v1.3.3-rc.4
v1.3.3-rc.3
v1.3.3-rc.2
v1.3.3-rc.1
v1.3.3-rc
v1.3.2-rc
v1.3.1-rc.1
v1.3.1-rc
v1.3.0-rc.10
v1.2.5-rc.2
v1.2.5-rc.1
v1.3.0-rc.9
v1.3.0-rc.8
v1.3.0-rc.7
v1.3.0-rc.6
v1.3.0-rc.5
v1.3.0-rc.4
v1.3.0-rc.3
v1.3.0-rc.2
v1.3.0-rc.1
v1.3.0-rc
v1.2.5-rc
v1.2.4-rc
v1.2.3-rc
v1.2.2-rc
v1.2.1-rc
v1.2.0-rc.2
v1.2.0-rc.1
v1.2.0-rc
v1.0.0-rc.16
v1.0.0-rc.15
v1.0.0-rc.14
v1.1.0-rc
v1.0.0-rc.13
v1.0.0-rc.12
v1.0.0-rc.11
v1.0.0-rc.10
v1.0.0-rc.9
v1.0.0-rc.8
v1.0.0-rc.7
v1.0.0-rc.6
v1.0.0-rc.5
v1.0.0-rc.4
v1.0.0-rc.3
v1.0.0-rc.2
v1.0.0-rc.1
v1.0.0-rc
v0.16.0-beta.1
v0.15.0-beta.1
v0.14.0-beta.1
v0.13.0-beta.1
v0.12.0-beta.1
v0.11.0-beta.1
v0.10.0-beta.1
v0.9.0-beta.1
Labels
Clear labels
ussd/user-reported
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Issue reported by a user while interacting with the ussd
Breaking change that won't be backward compatible
Something is not working
Documentation changes
Improve existing functionality
New functionality
This is security issue
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Milestone
No items
No Milestone
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: grassrootseconomics/sarafu-vise#24
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
We came up with a simple sketch on how the menu will look like with the introduction of the pool swap .We anticipate that the flow will be as here:
https://app.eraser.io/workspace/E8YvxTTqLze700xUSez3
Suggestions and any improvements before implementation will be appreciated.
1. Select pool menu
User should be able to select a pool from a list or enter the pool symbol manually. The list will be provided by an API. An additional endpoint will be provided to fetch a pool's details given its symbol.
2. Select voucher symbol to swap FROM
User should be able to choose the voucher symbol to swap from from a list. The list will be provided by an API. Generally they won't need to enter the voucher symbol because we will check it against their current holdings and populate the list accordingly.
3. Select voucher symbol to swap TO
User should be able to choose the voucher symbol to swap from from a list. The list will be provided by an API endpoint. Priority is given to popular stable coins available.
4.
Display voucher swap limitsDisplay the max FROM tokenEnsure that the limits have the symbol suffixed. e.g. Max 10 SRF, Min 1 SRF. The limits will be provided by an API endpoint.4. Swap preview
Display the swap preview and estimates. This will be provided by an API endpoint.
5. Execute swap
Send a request to the custodial system.
Example:
1
This endpoint lists the top pools to display as a list
If a user inputs a custom pool symbol:
2
This endpoint automatically finds out all the possible tokens a user can select to swap from. Note that this endpoint can take up to 3 seconds to completely resolve due to the nature of checking against the voucher registry and comparing user holdings since these values need to be checked on chain.
3
This endpoint returns the list of possible vouchers to swap to. Since this list could almost always contain all possible vouchers in the pool, it temporarily only displays stable coins available in the pool since that is the most common out token.
4
This endpoint returns the max FROM token only. This is sufficient to determine whether to proceed to the next step or not and follows a similar UX to sarafu.network. It is important to check if max/tokenDecimals > 0.1 for UX purposes and to prevent swapping of dust values.
5
Refer to
eth-custodialdocs./pool/:pool/check/:tokenAddress
{
"ok": true,
"description": "Check",
"result": {
"canSwapFrom": false
}
}
Completed. Minor issues will be created as new issues.