ens #32

carlos · 2025-02-28T16:50:38+01:00

carlos commented

2025-02-28 16:50:38 +01:00

PR Change

Adds a new menu option under My Account to Edit your alias based on name of your choice.
Displays your assigned alias on the Main Menu.
Request aliases based on the ENS.

**PR Change** - Adds a new menu option under My Account to Edit your alias based on name of your choice. - Displays your assigned alias on the Main Menu. - Request aliases based on the ENS.

carlos added 19 commits 2025-02-28 16:50:38 +01:00

add invalid and account alias flags a984c9dd06

add check for account alias data type 1f0e7c016e

feat: reset invalid pin flag,update template text c09ce32010

register new menu handlers 939df35c8c

check for invalid PIN d92dc026f5

feat: add my alias menu option 28e734e0ba

feat: add node to update your alias 0816190469

add node to confirm your alias b887c67e5d

add alias account template 78af4d225f

update authorize_account sink value f922fb6d43

feat: add request for ens based names from user input 8f7d5ff66d

reset invalid PIN flag 5ed63cec39

load current alias 7a6e5b094f

feat: show alias if set on main node 3e422f269f

fix: update authorize test function 226d1f5697

update test data file to include my alias menu option 0cbe391209

chore: remove alias tag,use lower case b for balance 830d867ac8

update check balance test 101afd5ebd

switch to use ens api endpoint for the aliases requests 20c8af582c

carlos requested review from lash 2025-02-28 16:51:23 +01:00

lash reviewed 2025-02-28 23:19:40 +01:00

handlers/application/menuhandler.go

						
				@ -1107,0 +1119,4 @@

							logg.ErrorCtxf(ctx, "Failed to read account alias entry with", "key", "error", storedb.DATA_ACCOUNT_ALIAS, err)

							return res, err

						}

						res.FlagSet = append(res.FlagSet, flag_offerings_set)

lash commented

2025-02-28 23:12:02 +01:00

is this the correct flag to set?

carlos commented

2025-03-03 10:36:43 +01:00

This line of code is actually misplaced. The right flag would have been "flag flag_alias_set" but it is not being utilized or checked in the associated vis file. The commit c2a0b05c84 removes this unnecessary line.

This line of code is actually misplaced. The right flag would have been "flag flag_alias_set" but it is not being utilized or checked in the associated `vis ` file. The commit c2a0b05c84462067456970de472e5240dd6a0cd9 removes this unnecessary line.

handlers/application/menuhandler.go Outdated

						
				@ -1458,3 +1505,3 @@

					balStr := fmt.Sprintf("%.2f %s", balFloat, activeSym)

					res.Content = l.Get("Balance: %s\n", balStr)

					if alias != "" {

lash commented

2025-02-28 23:14:14 +01:00

DRY?

carlos commented

2025-03-03 10:55:30 +01:00

Commit: e97d4be296 aims to resolve this. The CheckBalance should possibly be refactored further maybe? Currently it not only loads the balance,but also the user alias if set.

Commit: e97d4be296ee2dd35197b28aabb7487fc3061886 aims to resolve this. The `CheckBalance` should possibly be refactored further maybe? Currently it not only loads the balance,but also the user alias if set.

handlers/application/menuhandler.go

						
				@ -2397,0 +2462,4 @@

						return res, err

					}

					//Ensures that the call doesn't happen twice for the same alias hint

					if !bytes.Equal(aliasHint, input) {

lash commented

2025-02-28 23:16:07 +01:00

could this fail if something else writes the temp value in the meantime?

carlos commented

2025-03-03 10:49:23 +01:00

could this fail if something else writes the temp value in the meantime?

It is unlikely that this would happen because there can only be one DB write operation to the temp value at a time for that particular session id.

> could this fail if something else writes the temp value in the meantime? It is unlikely that this would happen because there can only be one DB write operation to the temp value at a time for that particular session id.

carlos added 2 commits 2025-03-03 10:17:03 +01:00

fix: update expected content in checkbalance function c2a0b05c84

refactor: break down checkbalance function to avoild code redandancy,remove misplaced flag setting e97d4be296

lash approved these changes 2025-03-07 06:00:12 +01:00

lash left a comment

pending staging tests

lash merged commit 144398e18b into master

2025-03-07 06:00:18 +01:00

lash referenced this issue from a commit

2025-03-07 06:00:19 +01:00

Merge pull request 'ens' (#32) from ens into master

Sign in to join this conversation.