grassrootseconomics/sarafu-vise
8
0
Fork 0
Code Issues 16 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

manage vouchers in single function #42

Merged
lash merged 6 commits from manage-vouchers-in-single-function into master 2025-04-01 21:26:28 +02:00
Conversation 1 Commits 6 Files Changed 4 +113 -181
Alfred-mk commented 2025-03-26 12:35:30 +01:00
Member
Copy Link

Resolves issue #40

Resolves issue https://git.grassecon.net/grassrootseconomics/sarafu-vise/issues/40
Alfred-mk added 4 commits 2025-03-26 12:35:30 +01:00
replace SetDefaultVoucher and CheckVouchers with ManageVouchers 20ee4dfb24
added TestManageVouchers for ManageVouchers 39e1c84a45
replace SetDefaultVoucher and CheckVouchers with ManageVouchers ea117b7222
increase the size limit for the manage_vouchers 0914217769
Alfred-mk changed title from manage-vouchers-in-single-function to manage vouchers in single function 2025-03-26 12:35:44 +01:00
lash reviewed 2025-03-27 13:49:03 +01:00
handlers/application/menuhandler.go
@@ -1964,0 +1981,4 @@
res.FlagReset = append(res.FlagReset, flag_no_active_voucher)
logg.InfoCtxf(ctx, "Fetched user vouchers", "public_key", string(publicKey), "vouchers", vouchersResp)
lash commented 2025-03-27 13:47:58 +01:00
Owner
Copy Link

is this log line a bit noisy? it prints the whole voucher response, cluttering the logs. the list perhaps better in debug?

is this log line a bit noisy? it prints the whole voucher response, cluttering the logs. the list perhaps better in debug?
Alfred-mk commented 2025-04-01 10:13:55 +02:00
Author
Member
Copy Link

This has been cleaned up. The logs were related to debug

This has been cleaned up. The logs were related to debug
Alfred-mk marked this conversation as resolved
Alfred-mk added 1 commit 2025-04-01 10:13:04 +02:00
removed debug related logs ea0fc4491d
lash added 1 commit 2025-04-01 21:26:20 +02:00
Merge branch 'master' into manage-vouchers-in-single-function f82b413e34
lash merged commit c3567313af into master 2025-04-01 21:26:28 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
lash
Labels
Clear labels
ussd/user-reported
Issue reported by a user while interacting with the ussd
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Alfred-mk amina carlos kamikazechaser lash mango-habanero williamluke willruddick
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: grassrootseconomics/sarafu-vise#42
Delete Branch "manage-vouchers-in-single-function"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?