grassrootseconomics/sarafu-vise
8
0
Fork 0
Code Issues 18 Pull Requests 3 Actions 1 Packages Projects Releases Wiki Activity

On certain tokens with high d.p, the value sent is rounded down #68

New Issue
Open
opened 2025-04-25 14:10:52 +02:00 by kamikazechaser · 2 comments
kamikazechaser commented 2025-04-25 14:10:52 +02:00
Owner
Copy Link
  1. Enter 0.1 on the USSD menu
  2. Amount actually sent is 99999999999999999
1. Enter 0.1 on the USSD menu 2. Amount actually sent is 99999999999999999
kamikazechaser added the
Kind/Bug
Priority
Medium
 labels 2025-04-25 14:10:52 +02:00
Alfred-mk self-assigned this 2025-04-27 15:26:35 +02:00
kamikazechaser added this to the USSD project 2025-04-29 10:16:44 +02:00
kamikazechaser commented 2025-05-13 10:47:58 +02:00
Author
Owner
Copy Link

Point out where this code is with tests.

Point out where this code is with tests.
kamikazechaser self-assigned this 2025-05-13 10:48:18 +02:00
Alfred-mk was unassigned by kamikazechaser 2025-05-13 10:48:18 +02:00
Alfred-mk commented 2025-05-13 12:32:40 +02:00
Member
Copy Link

The function ValidateAmount handles the user's amount input and writing it to storedb.DATA_AMOUNT
handlers/application/menuhandler.go Line 1840 in e914d059e2
func (h *MenuHandlers) ValidateAmount(ctx context.Context, sym string, input []byte) (resource.Result, error) {

The InitiateTransaction function reads the transaction data and initializes a transaction
handlers/application/menuhandler.go Line 1966 in e914d059e2
func (h *MenuHandlers) InitiateTransaction(ctx context.Context, sym string, input []byte) (resource.Result, error) {

In the InitiateTransaction, the store.ParseAndScaleAmount(data.Amount, data.ActiveDecimal) scales the amount using the active decimal value of the token
store/tokens.go Line 23 in e914d059e2
func ParseAndScaleAmount(storedAmount, activeDecimal string) (string, error) {

Tests

  1. TestValidateAmount for the ValidateAmount function
    handlers/application/menuhandler_test.go Line 1629 in e914d059e2
    func TestValidateAmount(t *testing.T) {
  2. TestInitiateTransaction for the InitiateTransaction function
    handlers/application/menuhandler_test.go Line 1485 in e914d059e2
    func TestInitiateTransaction(t *testing.T) {
  3. TestParseAndScaleAmount for the ParseAndScaleAmount function in store/tokens_test.go
    store/tokens_test.go Line 10 in e914d059e2
    func TestParseAndScaleAmount(t *testing.T) {
The function `ValidateAmount` handles the user's amount input and writing it to storedb.DATA_AMOUNT https://git.grassecon.net/grassrootseconomics/sarafu-vise/src/commit/e914d059e26b02baa91a1e44e284fea73669860c/handlers/application/menuhandler.go#L1840 --- --- The `InitiateTransaction` function reads the transaction data and initializes a transaction https://git.grassecon.net/grassrootseconomics/sarafu-vise/src/commit/e914d059e26b02baa91a1e44e284fea73669860c/handlers/application/menuhandler.go#L1966 --- --- In the `InitiateTransaction`, the `store.ParseAndScaleAmount(data.Amount, data.ActiveDecimal)` scales the amount using the active decimal value of the token https://git.grassecon.net/grassrootseconomics/sarafu-vise/src/commit/e914d059e26b02baa91a1e44e284fea73669860c/store/tokens.go#L23 --- --- ### Tests 1. `TestValidateAmount` for the `ValidateAmount` function https://git.grassecon.net/grassrootseconomics/sarafu-vise/src/commit/e914d059e26b02baa91a1e44e284fea73669860c/handlers/application/menuhandler_test.go#L1629 2. `TestInitiateTransaction` for the `InitiateTransaction` function https://git.grassecon.net/grassrootseconomics/sarafu-vise/src/commit/e914d059e26b02baa91a1e44e284fea73669860c/handlers/application/menuhandler_test.go#L1485 3. `TestParseAndScaleAmount` for the `ParseAndScaleAmount` function in store/tokens_test.go https://git.grassecon.net/grassrootseconomics/sarafu-vise/src/commit/e914d059e26b02baa91a1e44e284fea73669860c/store/tokens_test.go#L10
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
ussd/user-reported

Issue reported by a user while interacting with the ussd

  
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
ussd/user-reported
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
USSD
Assignees
Clear assignees
No Assignees
kamikazechaser
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: grassrootseconomics/sarafu-vise#68
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?