grassrootseconomics/sarafu-vise
8
0
Fork 0
Code Issues 16 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

fix-amount-conversion #87

Merged
Alfred-mk merged 9 commits from fix-amount-conversion into master 2025-06-26 14:07:29 +02:00
Conversation 2 Commits 9 Files Changed 4 +183 -17
Alfred-mk commented 2025-06-24 14:12:48 +02:00
Member
Copy Link
  • Fix amount conversions to prevent input such as 0.1 ending up as 0.09
  • Updates the ParseAndScaleAmount to return the correct amount in the voucher transfers and swaps
- Fix amount conversions to prevent input such as 0.1 ending up as 0.09 - Updates the ParseAndScaleAmount to return the correct amount in the voucher transfers and swaps
Alfred-mk added 4 commits 2025-06-24 14:12:48 +02:00
use the correct ContractAddress for the Last10TxResponse struct bc48dddd99
truncate two decimal places without risking float rounding issues 96f6ca7d08
add a test case to ensure the stored amount is not rounded off dabdf7eba2
Return finalAmount as a string with 0 decimal places (rounded) 88926480dc
Alfred-mk requested review from kamikazechaser 2025-06-24 14:13:02 +02:00
kamikazechaser commented 2025-06-26 10:30:23 +02:00
Owner
Copy Link

Add tests of 18 d.p. to TestParseAndScaleAmount and for the menu handler itself.

Generally the following should be the behaviour:

1.85 inputted for a 18d.p token - > 1850000000000000000
1.8599999999 inputted for a 18 d.p. token -> 1850000000000000000 (we truncate anything after 2 d.p.)
2.32 inputted for a 6 d.p token -> 2320000

Add tests of 18 d.p. to TestParseAndScaleAmount and for the menu handler itself. Generally the following should be the behaviour: 1.85 inputted for a 18d.p token - > 1850000000000000000 1.8599999999 inputted for a 18 d.p. token -> 1850000000000000000 (we truncate anything after 2 d.p.) 2.32 inputted for a 6 d.p token -> 2320000
Alfred-mk added 1 commit 2025-06-26 11:19:23 +02:00
add a helper function 'TruncateDecimalString' to format amounts to specified decimal places 280c382a3d
Alfred-mk added 4 commits 2025-06-26 11:30:51 +02:00
add test cases with high decimals for the ParseAndScaleAmount func b884b82197
add a test for the TruncateDecimalString 02fd02dc21
use the TruncateDecimalString helper function to format amounts to 2 d.p 7fe40faa9d
add a test case with large decimal amount 3592e7747c
Alfred-mk commented 2025-06-26 11:35:33 +02:00
Author
Member
Copy Link

Add tests of 18 d.p. to TestParseAndScaleAmount and for the menu handler itself.

Generally the following should be the behaviour:

1.85 inputted for a 18d.p token - > 1850000000000000000
1.8599999999 inputted for a 18 d.p. token -> 1850000000000000000 (we truncate anything after 2 d.p.)
2.32 inputted for a 6 d.p token -> 2320000

This has been fixed.

  1. TruncateDecimalString has been added as a helper function to truncate the amounts to whichever specified d.p. This has been set to 2 in the menuhanlder
  2. The ParseAndScaleAmount func will be called after the amount has been truncated to the specified d.p.
  3. Tests have been added to show the behavior of different cases.
> Add tests of 18 d.p. to TestParseAndScaleAmount and for the menu handler itself. > > Generally the following should be the behaviour: > > 1.85 inputted for a 18d.p token - > 1850000000000000000 > 1.8599999999 inputted for a 18 d.p. token -> 1850000000000000000 (we truncate anything after 2 d.p.) > 2.32 inputted for a 6 d.p token -> 2320000 > > This has been fixed. 1. `TruncateDecimalString` has been added as a helper function to truncate the amounts to whichever specified d.p. This has been set to 2 in the menuhanlder 2. The `ParseAndScaleAmount` func will be called after the amount has been truncated to the specified d.p. 3. Tests have been added to show the behavior of different cases.
Alfred-mk merged commit dd56d52f4c into master 2025-06-26 14:07:29 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
kamikazechaser
Labels
Clear labels
ussd/user-reported
Issue reported by a user while interacting with the ussd
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Alfred-mk amina carlos kamikazechaser lash mango-habanero williamluke willruddick
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: grassrootseconomics/sarafu-vise#87
Delete Branch "fix-amount-conversion"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?