config/config.go

@@ -1,7 +1,6 @@
 package config
 
 import (
-	"strconv"
 	"strings"
 
 	"git.defalsify.org/vise.git/logging"
@@ -16,33 +15,17 @@ var (
 	DefaultLanguage	    string
 	dbConn	string
 	dbConnMissing	bool
-	dbConnMode         storage.DbMode
 	stateDbConn	string
-	stateDbConnMode    storage.DbMode
 	resourceDbConn	string
-	resourceDbConnMode storage.DbMode
 	userDbConn	string
-	userDbConnMode     storage.DbMode
 	Languages	[]string
-	configManager      *Config
 )
 
-type Override struct {
-	DbConn           string
-	DbConnMode       storage.DbMode
-	StateConn        string
-	StateConnMode    storage.DbMode
-	ResourceConn     string
-	ResourceConnMode storage.DbMode
-	UserConn         string
-	UserConnMode     storage.DbMode
-}
-
 func setLanguage() error {
 	defaultLanguage = env.GetEnv("DEFAULT_LANGUAGE", defaultLanguage)
 	languages = strings.Split(env.GetEnv("LANGUAGES", defaultLanguage), ",")
 	haveDefaultLanguage := false
-	for i, v := range languages {
+	for i, v := range(languages) {
 		languages[i] = strings.ReplaceAll(v, " ", "")
 		if languages[i] == defaultLanguage {
 			haveDefaultLanguage = true
@@ -64,22 +47,18 @@ func setConn() error {
 	return nil
 }
 
-func ApplyConn(override *Override) {
+func ApplyConn(connStr *string, stateConnStr *string, resourceConnStr *string, userConnStr *string) {
-	if override.DbConn != "?" {
+	if connStr != nil {
-		dbConn = override.DbConn
+		dbConn = *connStr
-		stateDbConn = override.StateConn
-		resourceDbConn = override.ResourceConn
-		userDbConn = override.UserConn
 	}
-	dbConnMode = override.DbConnMode
+	if stateConnStr != nil {
-	if override.StateConn != "?" {
+		stateDbConn = *stateConnStr
-		stateDbConn = override.StateConn
 	}
-	if override.ResourceConn != "?" {
+	if resourceConnStr != nil {
-		resourceDbConn = override.ResourceConn
+		resourceDbConn = *resourceConnStr
 	}
-	if override.UserConn != "?" {
+	if userConnStr != nil {
-		userDbConn = override.UserConn
+		userDbConn = *userConnStr
 	}
 
 	if dbConn == "?" {
@@ -88,45 +67,28 @@ func ApplyConn(override *Override) {
 
 	if stateDbConn == "?" {
 		stateDbConn = dbConn
-		stateDbConnMode = dbConnMode
 	}
 	if resourceDbConn == "?" {
 		resourceDbConn = dbConn
-		resourceDbConnMode = dbConnMode
 	}
 	if userDbConn == "?" {
 		userDbConn = dbConn
-		userDbConnMode = dbConnMode
-	}
-
-	logg.Debugf("conns", "conn", dbConn, "user", userDbConn)
-	if override.DbConnMode != storage.DBMODE_ANY {
-		dbConnMode = override.DbConnMode
-	}
-	if override.StateConnMode != storage.DBMODE_ANY {
-		stateDbConnMode = override.StateConnMode
-	}
-	if override.ResourceConnMode != storage.DBMODE_ANY {
-		resourceDbConnMode = override.ResourceConnMode
-	}
-	if override.UserConnMode != storage.DBMODE_ANY {
-		userDbConnMode = override.UserConnMode
 	}
 }
 
 func GetConns() (storage.Conns, error) {
 	o := storage.NewConns()
-	c, err := storage.ToConnDataMode(stateDbConn, stateDbConnMode)
+	c, err := storage.ToConnData(stateDbConn)
 	if err != nil {
 		return o, err
 	}
 	o.Set(c, storage.STORETYPE_STATE)
-	c, err = storage.ToConnDataMode(resourceDbConn, resourceDbConnMode)
+	c, err = storage.ToConnData(resourceDbConn)
 	if err != nil {
 		return o, err
 	}
 	o.Set(c, storage.STORETYPE_RESOURCE)
-	c, err = storage.ToConnDataMode(userDbConn, userDbConnMode)
+	c, err = storage.ToConnData(userDbConn)
 	if err != nil {
 		return o, err
 	}
@@ -136,17 +98,6 @@ func GetConns() (storage.Conns, error) {
 
 // LoadConfig initializes the configuration values after environment variables are loaded.
 func LoadConfig() error {
-	configManager = NewConfig(logg)
-
-	// Add configuration keys with validation
-	configManager.AddKey("HOST", "127.0.0.1", false, nil)
-	configManager.AddKey("PORT", "7123", false, func(v string) error {
-		_, err := strconv.Atoi(v)
-		return err
-	})
-	configManager.AddKey("DB_CONN", "", true, nil)
-	// ... add other keys ?  or is enough :/ ...
-
 	err := setConn()
 	if err != nil {
 		return err
@@ -158,7 +109,5 @@ func LoadConfig() error {
 	DefaultLanguage = defaultLanguage
 	Languages = languages
 
-	// Report configuration
-	configManager.Report("INFO")
 	return nil
 }

config/config_test.go

@@ -1,63 +0,0 @@
-// +build configreport
-
-package config
-
-import (
-	"fmt"
-	"os"
-	"testing"
-
-	"git.defalsify.org/vise.git/logging"
-)
-
-// go test -tags configreport ./config/...   ---> run with tag
-func TestConfig(t *testing.T) {
-	logger := logging.NewVanilla().WithDomain("test")
-	cfg := NewConfig(logger)
-
-	t.Run("Default Values", func(t *testing.T) {
-		cfg.AddKey("TEST_KEY", "default", false, nil)
-		value, err := cfg.GetValue("TEST_KEY")
-		t.Logf("Got value: %q, error: %v", value, err)
-		if err != nil {
-			t.Errorf("unexpected error: %v", err)
-		}
-		if value != "default" {
-			t.Errorf("expected 'default', got '%s'", value)
-		}
-	})
-
-	t.Run("Environment Override", func(t *testing.T) {
-		os.Setenv("TEST_ENV_KEY", "override")
-		defer os.Unsetenv("TEST_ENV_KEY")
-
-		cfg.AddKey("TEST_ENV_KEY", "default", false, nil)
-		value, err := cfg.GetValue("TEST_ENV_KEY")
-		t.Logf("Got value: %q, error: %v", value, err)
-		if err != nil {
-			t.Errorf("unexpected error: %v", err)
-		}
-		if value != "override" {
-			t.Errorf("expected 'override', got '%s'", value)
-		}
-	})
-
-	t.Run("Validation", func(t *testing.T) {
-		validator := func(v string) error {
-			if v != "valid" {
-				return fmt.Errorf("invalid value")
-			}
-			return nil
-		}
-
-		cfg.AddKey("VALIDATED_KEY", "valid", false, validator)
-		os.Setenv("VALIDATED_KEY", "invalid")
-		defer os.Unsetenv("VALIDATED_KEY")
-
-		value, err := cfg.GetValue("VALIDATED_KEY")
-		t.Logf("Got value: %q, error: %v", value, err)
-		if err == nil {
-			t.Error("expected validation error, got nil")
-		}
-	})
-}

config/reporter.go

@@ -1,95 +0,0 @@
-//go:build configreport
-
-package config
-
-import (
-	"fmt"
-
-	"git.defalsify.org/vise.git/logging"
-	"git.grassecon.net/grassrootseconomics/visedriver/env"
-)
-
-// ConfigValue represents a configuration key-value pair
-type ConfigValue struct {
-	Key       string
-	Default   string
-	Validator func(string) error
-	Sensitive bool
-}
-
-// Config handles configuration management and reporting
-type Config struct {
-	values map[string]ConfigValue
-	logger logging.Vanilla
-}
-
-func NewConfig(logger logging.Vanilla) *Config {
-	return &Config{
-		values: make(map[string]ConfigValue),
-		logger: logger,
-	}
-}
-
-// AddKey registers a new configuration key with optional validation
-func (c *Config) AddKey(key string, defaultValue string, sensitive bool, validator func(string) error) {
-	c.values[key] = ConfigValue{
-		Key:       key,
-		Default:   defaultValue,
-		Validator: validator,
-		Sensitive: sensitive,
-	}
-}
-
-// GetValue returns the value for a given key, applying environment override if present
-func (c *Config) GetValue(key string) (string, error) {
-	// Find config value by key
-	var cv ConfigValue
-	for _, v := range c.values {
-		if v.Key == key {
-			cv = v
-			break
-		}
-	}
-
-	if cv.Key == "" {
-		return "", fmt.Errorf("configuration key not found: %s", key)
-	}
-
-	// Get value from environment or default
-	value := env.GetEnv(key, cv.Default)
-
-	// Validate if validator exists
-	if cv.Validator != nil && cv.Validator(value) != nil {
-		return "", fmt.Errorf("invalid value for key %s", key)
-	}
-
-	return value, nil
-}
-
-// Report outputs all configuration values at the specified log level
-func (c *Config) Report(level string) {
-	for _, cv := range c.values {
-		value, err := c.GetValue(cv.Key)
-		if err != nil {
-			c.logger.Errorf("Error getting value for %s: %v", cv.Key, err)
-			continue
-		}
-
-		if cv.Sensitive {
-			value = "****"
-		}
-
-		switch level {
-		case "DEBUG":
-			c.logger.Debugf("config set", cv.Key, value)
-		case "INFO":
-			c.logger.Infof("config set", cv.Key, value)
-		case "WARN":
-			c.logger.Warnf("config set", cv.Key, value)
-		case "ERROR":
-			c.logger.Errorf("config set", cv.Key, value)
-		default:
-			c.logger.Infof("config set", cv.Key, value)
-		}
-	}
-}

config/reporter_noop.go

@@ -1,21 +0,0 @@
-//go:build !configreport
-
-package config
-
-import (
-    "git.defalsify.org/vise.git/logging"
-)
-
-type Config struct{}
-
-func NewConfig(logger logging.Vanilla) *Config {
-    return &Config{}
-}
-
-func (c *Config) AddKey(key string, defaultValue string, sensitive bool, validator func(string) error) {}
-
-func (c *Config) GetValue(key string) (string, error) {
-    return "", nil
-}
-
-func (c *Config) Report(level string) {} 

entry/handlers.go

@@ -2,9 +2,8 @@ package entry
 
 import (
 	"context"
-
-	"git.defalsify.org/vise.git/persist"
 	"git.defalsify.org/vise.git/resource"
+	"git.defalsify.org/vise.git/persist"
 )
 
 type EntryHandler interface {

go.mod

@@ -3,7 +3,7 @@ module git.grassecon.net/grassrootseconomics/visedriver
 go 1.23.0
 
 require (
-	git.defalsify.org/vise.git v0.2.3-0.20250204132233-2bffe532f21e
+	git.defalsify.org/vise.git v0.2.3-0.20250119111745-4f69d6fe5939
 	github.com/jackc/pgx/v5 v5.7.1
 	github.com/joho/godotenv v1.5.1
 )

go.sum

@@ -1,5 +1,5 @@
-git.defalsify.org/vise.git v0.2.3-0.20250204132233-2bffe532f21e h1:gtB9OdX6x5gQRM3W824dEurXuuf/YPInqgtv2KAp5Zo=
+git.defalsify.org/vise.git v0.2.3-0.20250119111745-4f69d6fe5939 h1:DA0gus9TuKpLvZMDmmqCAwAr5Lly+U93jtO2OKtGAeo=
-git.defalsify.org/vise.git v0.2.3-0.20250204132233-2bffe532f21e/go.mod h1:jyBMe1qTYUz3mmuoC9JQ/TvFeW0vTanCUcPu3H8p4Ck=
+git.defalsify.org/vise.git v0.2.3-0.20250119111745-4f69d6fe5939/go.mod h1:jyBMe1qTYUz3mmuoC9JQ/TvFeW0vTanCUcPu3H8p4Ck=
 github.com/barbashov/iso639-3 v0.0.0-20211020172741-1f4ffb2d8d1c h1:H9Nm+I7Cg/YVPpEV1RzU3Wq2pjamPc/UtHDgItcb7lE=
 github.com/barbashov/iso639-3 v0.0.0-20211020172741-1f4ffb2d8d1c/go.mod h1:rGod7o6KPeJ+hyBpHfhi4v7blx9sf+QsHsA7KAsdN6U=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=

request/base.go

@@ -7,37 +7,28 @@ import (
 	"git.defalsify.org/vise.git/engine"
 	"git.defalsify.org/vise.git/persist"
 	"git.defalsify.org/vise.git/resource"
-	"git.grassecon.net/grassrootseconomics/visedriver/entry"
-	"git.grassecon.net/grassrootseconomics/visedriver/errors"
 	"git.grassecon.net/grassrootseconomics/visedriver/storage"
+	"git.grassecon.net/grassrootseconomics/visedriver/errors"
+	"git.grassecon.net/grassrootseconomics/visedriver/entry"
 )
 
-type EngineFunc func(engine.Config, resource.Resource, *persist.Persister) engine.Engine
-
 type BaseRequestHandler struct {
 	cfgTemplate engine.Config
 	rp RequestParser
 	rs resource.Resource
 	hn entry.EntryHandler
 	provider storage.StorageProvider
-	engineFunc	EngineFunc
 }
 
+//func NewBaseRequestHandler(cfg engine.Config, rs resource.Resource, stateDb db.Db, userdataDb db.Db, rp request.RequestParser, hn *handlers.Handlers) *BaseRequestHandler {
 func NewBaseRequestHandler(cfg engine.Config, rs resource.Resource, stateDb db.Db, userdataDb db.Db, rp RequestParser, hn entry.EntryHandler) *BaseRequestHandler {
-	h := &BaseRequestHandler{
+	return &BaseRequestHandler{
 		cfgTemplate: cfg,
 		rs:          rs,
 		hn:          hn,
 		rp:          rp,
 		provider:    storage.NewSimpleStorageProvider(stateDb, userdataDb),
 	}
-	h.engineFunc = h.getDefaultEngine
-	return h
-}
-
-func (f *BaseRequestHandler) WithEngineFunc(fn EngineFunc) *BaseRequestHandler {
-	f.engineFunc = fn
-	return f
 }
 
 func (f *BaseRequestHandler) Shutdown(ctx context.Context) {
@@ -48,22 +39,15 @@ func (f *BaseRequestHandler) Shutdown(ctx context.Context) {
 }
 
 func (f *BaseRequestHandler) GetEngine(cfg engine.Config, rs resource.Resource, pr *persist.Persister) engine.Engine {
-	return f.engineFunc(cfg, rs, pr)
-}
-
-func (f *BaseRequestHandler) getDefaultEngine(cfg engine.Config, rs resource.Resource, pr *persist.Persister) engine.Engine {
 	en := engine.NewEngine(cfg, rs)
 	en = en.WithPersister(pr)
-	en = en.WithFirst(f.hn.Init)
-	if f.cfgTemplate.EngineDebug {
-		en = en.WithDebug(nil)
-	}
 	return en
 }
 
-func (f *BaseRequestHandler) Process(rqs RequestSession) (RequestSession, error) {
+func(f *BaseRequestHandler) Process(rqs RequestSession) (RequestSession, error) {
 	var r bool
 	var err error
+	var ok bool
 
 	logg.InfoCtxf(rqs.Ctx, "new request", "data", rqs)
 
@@ -73,12 +57,27 @@ func (f *BaseRequestHandler) Process(rqs RequestSession) (RequestSession, error)
 		return rqs, errors.ErrStorage
 	}
 
+	//f.hn = f.hn.WithPersister(rqs.Storage.Persister)
 	f.hn.SetPersister(rqs.Storage.Persister)
 	defer func() {
 		f.hn.Exit()
 	}()
+	eni := f.GetEngine(rqs.Config, f.rs, rqs.Storage.Persister)
+	en, ok := eni.(*engine.DefaultEngine)
+	if !ok {
+		perr := f.provider.Put(rqs.Ctx, rqs.Config.SessionId, rqs.Storage)
+		rqs.Storage = nil
+		if perr != nil {
+			logg.ErrorCtxf(rqs.Ctx, "", "storage put error", perr)
+		}
+		return rqs, errors.ErrEngineType
+	}
+	en = en.WithFirst(f.hn.Init)
+	if rqs.Config.EngineDebug {
+		en = en.WithDebug(nil)
+	}
+	rqs.Engine = en
 
-	rqs.Engine = f.GetEngine(rqs.Config, f.rs, rqs.Storage.Persister)
 	r, err = rqs.Engine.Exec(rqs.Ctx, rqs.Input)
 	if err != nil {
 		perr := f.provider.Put(rqs.Ctx, rqs.Config.SessionId, rqs.Storage)
@@ -93,13 +92,13 @@ func (f *BaseRequestHandler) Process(rqs RequestSession) (RequestSession, error)
 	return rqs, nil
 }
 
-func (f *BaseRequestHandler) Output(rqs RequestSession) (RequestSession, error) {
+func(f *BaseRequestHandler) Output(rqs RequestSession) (RequestSession,  error) {
 	var err error
 	_, err = rqs.Engine.Flush(rqs.Ctx, rqs.Writer)
 	return rqs, err
 }
 
-func (f *BaseRequestHandler) Reset(ctx context.Context, rqs RequestSession) (RequestSession, error) {
+func(f *BaseRequestHandler) Reset(ctx context.Context, rqs RequestSession) (RequestSession, error) {
 	defer f.provider.Put(ctx, rqs.Config.SessionId, rqs.Storage)
 	return rqs, rqs.Engine.Finish(ctx)
 }
@@ -108,6 +107,6 @@ func (f *BaseRequestHandler) GetConfig() engine.Config {
 	return f.cfgTemplate
 }
 
-func (f *BaseRequestHandler) GetRequestParser() RequestParser {
+func(f *BaseRequestHandler) GetRequestParser() RequestParser {
 	return f.rp
 }

request/http/server.go

@@ -5,8 +5,8 @@ import (
 	"strconv"
 
 	"git.defalsify.org/vise.git/logging"
-	"git.grassecon.net/grassrootseconomics/visedriver/errors"
 	"git.grassecon.net/grassrootseconomics/visedriver/request"
+	"git.grassecon.net/grassrootseconomics/visedriver/errors"
 )
 
 var (

request/http/server_test.go

@@ -10,8 +10,8 @@ import (
 
 	"git.defalsify.org/vise.git/engine"
 	viseerrors "git.grassecon.net/grassrootseconomics/visedriver/errors"
-	"git.grassecon.net/grassrootseconomics/visedriver/request"
 	"git.grassecon.net/grassrootseconomics/visedriver/testutil/mocks/httpmocks"
+	"git.grassecon.net/grassrootseconomics/visedriver/request"
 )
 
 // invalidRequestType is a custom type to test invalid request scenarios
@@ -165,7 +165,7 @@ func TestDefaultRequestParser_GetSessionId(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			id, err := parser.GetSessionId(context.Background(), tt.request)
+			id, err := parser.GetSessionId(context.Background(),tt.request)
 
 			if id != tt.expectedID {
 				t.Errorf("Expected session ID %s, got %s", tt.expectedID, id)

request/request.go

@@ -4,10 +4,10 @@ import (
 	"context"
 	"io"
 
+	"git.defalsify.org/vise.git/resource"
+	"git.defalsify.org/vise.git/persist"
 	"git.defalsify.org/vise.git/engine"
 	"git.defalsify.org/vise.git/logging"
-	"git.defalsify.org/vise.git/persist"
-	"git.defalsify.org/vise.git/resource"
 	"git.grassecon.net/grassrootseconomics/visedriver/storage"
 )
 

storage/conn.go

@@ -5,8 +5,6 @@ import (
 	"net/url"
 )
 
-type DbMode uint8
-
 const (
 	DBTYPE_NONE = iota
 	DBTYPE_MEM
@@ -15,12 +13,6 @@ const (
 	DBTYPE_POSTGRES
 )
 
-const (
-	DBMODE_ANY DbMode = iota
-	DBMODE_BINARY
-	DBMODE_TEXT
-)
-
 const (
 	STORETYPE_STATE = iota
 	STORETYPE_RESOURCE
@@ -28,12 +20,6 @@ const (
 	_STORETYPE_MAX
 )
 
-var (
-	DbModeDebug  = []string{"ANY", "BIN", "TXT"}
-	DbTypeDebug  = []string{"NONE", "MEM", "FS", "GDBM", "POSTGRES"}
-	DbStoreDebug = []string{"STATE", "RESOURCE", "USER"}
-)
-
 type Conns map[int8]ConnData
 
 func NewConns() Conns {
@@ -49,18 +35,16 @@ func (c Conns) Set(conn ConnData, typ int8) {
 }
 
 func (c Conns) Have(conn *ConnData) int8 {
-	for i := range _STORETYPE_MAX {
+	for i := range(_STORETYPE_MAX) {
 		ii := int8(i)
 		v, ok := c[ii]
 		if !ok {
 			continue
 		}
-		if v.Raw() == conn.Raw() {
+		if v.String() == conn.String() {
-			if v.Mode() == DBMODE_ANY || v.Mode() == conn.Mode() {
 			return ii
 		}
 	}
-	}
 	return -1
 }
 
@@ -68,31 +52,22 @@ type ConnData struct {
 	typ int
 	str string
 	domain string
-	mode   DbMode
 }
 
 func (cd *ConnData) DbType() int {
 	return cd.typ
 }
 
-func (cd ConnData) String() string {
+func (cd *ConnData) String() string {
-	return fmt.Sprintf("conn: %s, mod %s, typ %s", cd.str, DbModeDebug[uint8(cd.mode)], DbTypeDebug[uint8(cd.typ)])
+	return cd.str
 }
 
 func (cd *ConnData) Domain() string {
 	return cd.domain
 }
 
-func (cd *ConnData) Mode() DbMode {
-	return cd.mode
-}
-
 func (cd *ConnData) Path() string {
 	v, _ := url.Parse(cd.str)
 	v.RawQuery = ""
 	return v.String()
 }
-
-func (cd *ConnData) Raw() string {
-	return cd.str
-}

storage/db/gdbm/gdbm.go

@@ -29,7 +29,7 @@ func NewThreadGdbmDb() *ThreadGdbmDb {
 	return &ThreadGdbmDb{}
 }
 
-func (tdb *ThreadGdbmDb) Connect(ctx context.Context, connStr string) error {
+func(tdb *ThreadGdbmDb) Connect(ctx context.Context, connStr string) error {
 	var ok bool
 	_, ok = dbC[connStr]
 	if ok {
@@ -42,18 +42,18 @@ func (tdb *ThreadGdbmDb) Connect(ctx context.Context, connStr string) error {
 		return err
 	}
 	dbC[connStr] = make(chan db.Db, 1)
-	dbC[connStr] <- gdb
+	dbC[connStr]<- gdb
 	tdb.connStr = connStr
 	return nil
 }
 
-func (tdb *ThreadGdbmDb) reserve() {
+func(tdb *ThreadGdbmDb) reserve() {
 	if tdb.db == nil {
 		tdb.db = <-dbC[tdb.connStr]
 	}
 }
 
-func (tdb *ThreadGdbmDb) release() {
+func(tdb *ThreadGdbmDb) release() {
 	if tdb.db == nil {
 		return
 	}
@@ -61,57 +61,57 @@ func (tdb *ThreadGdbmDb) release() {
 	tdb.db = nil
 }
 
-func (tdb *ThreadGdbmDb) SetPrefix(pfx uint8) {
+func(tdb *ThreadGdbmDb) SetPrefix(pfx uint8) {
 	tdb.reserve()
 	tdb.db.SetPrefix(pfx)
 }
 
-func (tdb *ThreadGdbmDb) SetSession(sessionId string) {
+func(tdb *ThreadGdbmDb) SetSession(sessionId string) {
 	tdb.reserve()
 	tdb.db.SetSession(sessionId)
 }
 
-func (tdb *ThreadGdbmDb) SetLanguage(lng *lang.Language) {
+func(tdb *ThreadGdbmDb) SetLanguage(lng *lang.Language) {
 	tdb.reserve()
 	tdb.db.SetLanguage(lng)
 }
 
-func (tdb *ThreadGdbmDb) Safe() bool {
+func(tdb *ThreadGdbmDb) Safe() bool {
 	tdb.reserve()
 	v := tdb.db.Safe()
 	tdb.release()
 	return v
 }
 
-func (tdb *ThreadGdbmDb) Prefix() uint8 {
+func(tdb *ThreadGdbmDb) Prefix() uint8 {
 	tdb.reserve()
 	v := tdb.db.Prefix()
 	tdb.release()
 	return v
 }
 
-func (tdb *ThreadGdbmDb) SetLock(typ uint8, locked bool) error {
+func(tdb *ThreadGdbmDb) SetLock(typ uint8, locked bool) error {
 	tdb.reserve()
 	err := tdb.db.SetLock(typ, locked)
 	tdb.release()
 	return err
 }
 
-func (tdb *ThreadGdbmDb) Put(ctx context.Context, key []byte, val []byte) error {
+func(tdb *ThreadGdbmDb) Put(ctx context.Context, key []byte, val []byte) error {
 	tdb.reserve()
 	err := tdb.db.Put(ctx, key, val)
 	tdb.release()
 	return err
 }
 
-func (tdb *ThreadGdbmDb) Get(ctx context.Context, key []byte) ([]byte, error) {
+func(tdb *ThreadGdbmDb) Get(ctx context.Context, key []byte) ([]byte, error) {
 	tdb.reserve()
 	v, err := tdb.db.Get(ctx, key)
 	tdb.release()
 	return v, err
 }
 
-func (tdb *ThreadGdbmDb) Close(ctx context.Context) error {
+func(tdb *ThreadGdbmDb) Close(ctx context.Context) error {
 	tdb.reserve()
 	close(dbC[tdb.connStr])
 	delete(dbC, tdb.connStr)
@@ -120,28 +120,28 @@ func (tdb *ThreadGdbmDb) Close(ctx context.Context) error {
 	return err
 }
 
-func (tdb *ThreadGdbmDb) Dump(ctx context.Context, key []byte) (*db.Dumper, error) {
+func(tdb *ThreadGdbmDb) Dump(ctx context.Context, key []byte) (*db.Dumper, error) {
 	tdb.reserve()
 	defer tdb.release()
 	return tdb.db.Dump(ctx, key)
 }
 
-func (tdb *ThreadGdbmDb) DecodeKey(ctx context.Context, key []byte) ([]byte, error) {
+func(tdb *ThreadGdbmDb) DecodeKey(ctx context.Context, key []byte) ([]byte, error) {
 	return tdb.db.DecodeKey(ctx, key)
 }
 
-func (tdb *ThreadGdbmDb) Abort(ctx context.Context) {
+func(tdb *ThreadGdbmDb) Abort(ctx context.Context) {
 	tdb.db.Abort(ctx)
 }
 
-func (tdb *ThreadGdbmDb) Start(ctx context.Context) error {
+func(tdb *ThreadGdbmDb) Start(ctx context.Context) error {
 	return tdb.db.Start(ctx)
 }
 
-func (tdb *ThreadGdbmDb) Stop(ctx context.Context) error {
+func(tdb *ThreadGdbmDb) Stop(ctx context.Context) error {
 	return tdb.db.Stop(ctx)
 }
 
-func (tdb *ThreadGdbmDb) Connection() string {
+func(tdb *ThreadGdbmDb) Connection() string {
 	return tdb.db.Connection()
 }

storage/parse.go

@@ -61,15 +61,6 @@ func probeMem(s string) (string, string, bool) {
 	return "", "", true
 }
 
-func ToConnDataMode(connStr string, mode DbMode) (ConnData, error) {
-	o, err := ToConnData(connStr)
-	if err != nil {
-		return o, err
-	}
-	o.mode = mode
-	return o, nil
-}
-
 func ToConnData(connStr string) (ConnData, error) {
 	var o ConnData
 

storage/storage_service.go

@@ -7,6 +7,7 @@ import (
 	"os"
 	"path"
 	
+	"github.com/jackc/pgx/v5/pgxpool"
 	"git.defalsify.org/vise.git/db"
 	fsdb "git.defalsify.org/vise.git/db/fs"
 	memdb "git.defalsify.org/vise.git/db/mem"
@@ -16,7 +17,6 @@ import (
 	"git.defalsify.org/vise.git/persist"
 	"git.defalsify.org/vise.git/resource"
 	gdbmstorage "git.grassecon.net/grassrootseconomics/visedriver/storage/db/gdbm"
-	"github.com/jackc/pgx/v5/pgxpool"
 )
 
 var (
@@ -55,13 +55,12 @@ func (ms *MenuStorageService) WithDb(store db.Db, typ int8) *MenuStorageService
 	return ms
 }
 
-func (ms *MenuStorageService) checkDb(ctx context.Context, typ int8) db.Db {
+func (ms *MenuStorageService) checkDb(ctx context.Context,typ int8) db.Db {
 	store := ms.store[typ]
 	if store != nil {
 		return store
 	}
 	connData := ms.conns[typ]
-	logg.DebugCtxf(ctx, "db check", "conn", connData, "store", DbStoreDebug[typ])
 	v := ms.conns.Have(&connData)
 	if v == -1 {
 		return nil
@@ -71,7 +70,7 @@ func (ms *MenuStorageService) checkDb(ctx context.Context, typ int8) db.Db {
 		return nil
 	}
 	ms.store[typ] = ms.store[v]
-	logg.DebugCtxf(ctx, "found existing db", "typ", typ, "srctyp", v, "store", ms.store[typ], "srcstore", ms.store[v], "conn", connData)
+	logg.DebugCtxf(ctx, "found existing db", "typ", typ, "srctyp", v, "store", ms.store[typ], "srcstore", ms.store[v])
 	return ms.store[typ]
 }
 
@@ -85,7 +84,7 @@ func (ms *MenuStorageService) getOrCreateDb(ctx context.Context, section string,
 	}
 
 	connData := ms.conns[typ]
-	connStr := connData.Raw()
+	connStr := connData.String()
 	dbTyp := connData.DbType()
 	if dbTyp == DBTYPE_POSTGRES {
 		// TODO: move to vise
@@ -106,16 +105,12 @@ func (ms *MenuStorageService) getOrCreateDb(ctx context.Context, section string,
 		if err != nil {
 			return nil, err
 		}
-		fsdbInstance := fsdb.NewFsDb()
+		newDb = fsdb.NewFsDb().WithBinary()
-		if connData.Mode() == DBMODE_BINARY {
-			fsdbInstance = fsdbInstance.WithBinary()
-		}
-		newDb = fsdbInstance
 	} else if dbTyp == DBTYPE_MEM {
 		logg.WarnCtxf(ctx, "using volatile storage (memdb)")
 		newDb = memdb.NewMemDb()
 	} else {
-		return nil, fmt.Errorf("unsupported connection string: '%s'\n", connData.Raw())
+		return nil, fmt.Errorf("unsupported connection string: '%s'\n", connData.String())
 	}
 	logg.InfoCtxf(ctx, "connecting to db", "conn", connData, "typ", typ)
 	err = newDb.Connect(ctx, connStr)
@@ -140,7 +135,7 @@ func (ms *MenuStorageService) WithGettext(path string, lns []lang.Language) *Men
 	}
 	rs := resource.NewPoResource(lns[0], path)
 
-	for _, ln := range lns {
+	for _, ln := range(lns) {
 		rs = rs.WithLanguage(ln)
 	}
 
@@ -169,9 +164,7 @@ func ensureSchemaExists(ctx context.Context, conn ConnData) error {
 func applySession(ctx context.Context, store db.Db) error {
 	sessionId, ok := ctx.Value("SessionId").(string)
 	if !ok {
-		logg.DebugCtxf(ctx, "missing session to apply", "store", store)
+		return fmt.Errorf("missing session to apply to store: %v", store)
-		return nil
-		//return fmt.Errorf("missing session to apply to store: %v", store)
 	}
 	store.SetSession(sessionId)
 	return nil
@@ -186,6 +179,7 @@ func (ms *MenuStorageService) GetPersister(ctx context.Context) (*persist.Persis
 	if err != nil {
 		return nil, err
 	}
+
 	pr := persist.NewPersister(stateStore)
 	logg.TraceCtxf(ctx, "menu storage service", "persist", pr, "store", stateStore)
 	return pr, nil
@@ -196,6 +190,7 @@ func (ms *MenuStorageService) GetUserdataDb(ctx context.Context) (db.Db, error)
 	if err != nil {
 		return nil, err
 	}
+
 	err = applySession(ctx, userStore)
 	if err != nil {
 		return nil, err
@@ -233,7 +228,7 @@ func (ms *MenuStorageService) ensureDbDir(path string) error {
 func (ms *MenuStorageService) Close(ctx context.Context) error {
 	var errs []error
 	var haveErr bool
-	for i := range _STORETYPE_MAX {
+	for i := range(_STORETYPE_MAX) {
 		err := ms.store[int8(i)].Close(ctx)
 		if err != nil {
 			haveErr = true
@@ -242,7 +237,7 @@ func (ms *MenuStorageService) Close(ctx context.Context) error {
 	}
 	if haveErr {
 		errStr := ""
-		for i, err := range errs {
+		for i, err := range(errs) {
 			errStr += fmt.Sprintf("(%d: %v)", i, err)
 		}
 		return errors.New(errStr)

testutil/mocks/storage.go

@@ -5,8 +5,8 @@ import (
 
 	"git.defalsify.org/vise.git/db"
 	memdb "git.defalsify.org/vise.git/db/mem"
-	"git.defalsify.org/vise.git/persist"
 	"git.defalsify.org/vise.git/resource"
+	"git.defalsify.org/vise.git/persist"
 )
 
 type MemStorageService struct {
@@ -39,3 +39,4 @@ func (mss *MemStorageService) GetUserdataDb(ctx context.Context) (db.Db, error)
 func (mss *MemStorageService) GetResource(ctx context.Context) (resource.Resource, error) {
 	return mss.rs, nil
 }
+