grassrootseconomics/visedriver
8
0
Fork 1
Code Issues 3 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

config reporter #7

Merged
lash merged 3 commits from konstantinmds/visedriver:feature/6-config-reporter-new into master 2025-02-28 00:09:49 +01:00
Conversation 2 Commits 3 Files Changed 4 +192
konstantinmds commented 2025-02-07 15:07:11 +01:00
Contributor
Copy Link
No description provided.
konstantinmds requested review from Alfred-mk 2025-02-07 15:07:18 +01:00
konstantinmds force-pushed feature/6-config-reporter-new from 86bf9b10af to e4cf7d6960 2025-02-07 16:00:41 +01:00 Compare
konstantinmds force-pushed feature/6-config-reporter-new from e4cf7d6960 to 6619afe62b 2025-02-07 16:05:08 +01:00 Compare
lash requested changes 2025-02-22 09:09:01 +01:00
config/reporter.go Outdated
@@ -0,0 +82,4 @@
switch level {
case "DEBUG":
c.logger.Debugf("%s: %s", cv.Key, value)
lash commented 2025-02-22 09:08:55 +01:00
Owner
Copy Link

Debugf is not printf, you probably want something like c.logger.Debugf("config set", cv.Key, value)

Debugf is not printf, you probably want something like `c.logger.Debugf("config set", cv.Key, value)`
👍 1
konstantinmds added 1 commit 2025-02-25 00:17:08 +01:00
change on report method ec9032a42e
konstantinmds requested review from lash 2025-02-25 00:17:50 +01:00
lash commented 2025-02-27 23:57:56 +01:00
Owner
Copy Link

hey just drop the "configuration report" logline (just leave the actual set lines) and we can merge. thanks!

hey just drop the "configuration report" logline (just leave the actual set lines) and we can merge. thanks!
👍 1
konstantinmds added 1 commit 2025-02-28 00:06:36 +01:00
removing redundant logline d91c96f541
lash merged commit bf10e5357c into master 2025-02-28 00:09:49 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Alfred-mk
lash
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Alfred-mk amina carlos kamikazechaser lash mango-habanero williamluke willruddick
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: grassrootseconomics/visedriver#7
Delete Branch "konstantinmds/visedriver:feature/6-config-reporter-new"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?