Simplify conditional scope

apps/cic-eth/cic_eth/runnable/daemons/filters/callback.py

@@ -20,42 +20,39 @@ logg = logging.getLogger().getChild(__name__)
 
 
 def parse_transfer(tx):
-    if tx.payload:
+    if not tx.payload:
-        r = ERC20.parse_transfer_request(tx.payload)
+        return (None, None)
-        transfer_data = {}
+    r = ERC20.parse_transfer_request(tx.payload)
-        transfer_data['to'] = r[0]
+    transfer_data = {}
-        transfer_data['value'] = r[1]
+    transfer_data['to'] = r[0]
-        transfer_data['from'] = tx['from']
+    transfer_data['value'] = r[1]
-        transfer_data['token_address'] = tx['to']
+    transfer_data['from'] = tx['from']
-        return ('transfer', transfer_data)
+    transfer_data['token_address'] = tx['to']
-    else:
+    return ('transfer', transfer_data)
-        pass
 
 
 def parse_transferfrom(tx):
-    if tx.payload:
+    if not tx.payload:
-        r = ERC20.parse_transfer_request(tx.payload)
+        return (None, None)
-        transfer_data = {}
+    r = ERC20.parse_transfer_request(tx.payload)
-        transfer_data['from'] = r[0]
+    transfer_data = {}
-        transfer_data['to'] = r[1]
+    transfer_data['from'] = r[0]
-        transfer_data['value'] = r[2]
+    transfer_data['to'] = r[1]
-        transfer_data['token_address'] = tx['to']
+    transfer_data['value'] = r[2]
-        return ('transferfrom', transfer_data)
+    transfer_data['token_address'] = tx['to']
-    else:
+    return ('transferfrom', transfer_data)
-        pass
 
 
 def parse_giftto(tx):
-    if tx.payload:
+    if not tx.payload:
-        r = Faucet.parse_give_to_request(tx.payload)
+        return (None, None)
-        transfer_data = {}
+    r = Faucet.parse_give_to_request(tx.payload)
-        transfer_data['to'] = r[0]
+    transfer_data = {}
-        transfer_data['value'] = tx['value']
+    transfer_data['to'] = r[0]
-        transfer_data['from'] = tx['from']
+    transfer_data['value'] = tx['value']
-        transfer_data['token_address'] = tx['to']
+    transfer_data['from'] = tx['from']
-        return ('tokengift', transfer_data)
+    transfer_data['token_address'] = tx['to']
-    else:
+    return ('tokengift', transfer_data)
-        pass
 
 
 class CallbackFilter(SyncFilter):
@@ -110,7 +107,8 @@ class CallbackFilter(SyncFilter):
             try:
                 if tx:
                     (transfer_type, transfer_data) = parser(tx)
-                    break
+                    if transfer_type == None:
+                        continue
                 else:
                     pass
             except RequestMismatchException: