From 75ca39b01298446c46061b51a7de5c58b2db581f Mon Sep 17 00:00:00 2001
From: alfred-mk <alfredmwaik@gmail.com>
Date: Thu, 29 Aug 2024 22:57:19 +0300
Subject: [PATCH] Define the regex pattern as a constant
---
internal/handlers/ussd/menuhandler.go | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/internal/handlers/ussd/menuhandler.go b/internal/handlers/ussd/menuhandler.go
index 7dbdec8..d4cd430 100644
--- a/internal/handlers/ussd/menuhandler.go
+++ b/internal/handlers/ussd/menuhandler.go
@@ -59,6 +59,15 @@ func NewHandlers(path string, st *state.State) *Handlers {
}
}
+// Define the regex pattern as a constant
+const pinPattern = `^\d{4}$`
+
+// isValidPIN checks whether the given input is a 4 digit number
+func isValidPIN(pin string) bool {
+ match, _ := regexp.MatchString(pinPattern, pin)
+ return match
+}
+
// SetLanguage sets the language across the menu
func (h *Handlers) SetLanguage(ctx context.Context, sym string, input []byte) (resource.Result, error) {
inputStr := string(input)
@@ -192,13 +201,6 @@ func (h *Handlers) VerifyPin(ctx context.Context, sym string, input []byte) (res
return res, nil
}
-// isValidPIN checks whether the given input is a 4 digit number
-func isValidPIN(pin string) bool {
- match, _ := regexp.MatchString(`^\d{4}$`, pin)
- return match
-}
-
-
//codeFromCtx retrieves language codes from the context that can be used for handling translations
func codeFromCtx(ctx context.Context) string {
var code string