Merge branch 'master' into alias-address-validation

common/db.go

@@ -32,19 +32,7 @@ const (
 	DATA_PUBLIC_KEY_REVERSE
 	DATA_ACTIVE_DECIMAL
 	DATA_ACTIVE_ADDRESS
-	// Start the sub prefix data at 256 (0x0100)
+	DATA_TRANSACTIONS
-	DATA_VOUCHER_SYMBOLS DataTyp = 256 + iota
-	DATA_VOUCHER_BALANCES
-	DATA_VOUCHER_DECIMALS
-	DATA_VOUCHER_ADDRESSES
-	DATA_TX_SENDERS
-	DATA_TX_RECIPIENTS
-	DATA_TX_VALUES
-	DATA_TX_ADDRESSES
-	DATA_TX_HASHES
-	DATA_TX_DATES
-	DATA_TX_SYMBOLS
-	DATA_TX_DECIMALS
 )
 
 var (
@@ -81,10 +69,3 @@ func StringToDataTyp(str string) (DataTyp, error) {
 		return 0, errors.New("invalid DataTyp string")
 	}
 }
-
-// ToBytes converts DataTyp or int to a byte slice
-func ToBytes[T ~uint16 | int](value T) []byte {
-	bytes := make([]byte, 2)
-	binary.BigEndian.PutUint16(bytes, uint16(value))
-	return bytes
-}

common/transfer_statements.go

@@ -57,25 +57,25 @@ func ProcessTransfers(transfers []dataserviceapi.Last10TxResponse) TransferMetad
 // GetTransferData retrieves and matches transfer data
 // returns a formatted string of the full transaction/statement
 func GetTransferData(ctx context.Context, db storage.PrefixDb, publicKey string, index int) (string, error) {
-	keys := []DataTyp{DATA_TX_SENDERS, DATA_TX_RECIPIENTS, DATA_TX_VALUES, DATA_TX_ADDRESSES, DATA_TX_HASHES, DATA_TX_DATES, DATA_TX_SYMBOLS}
+	keys := []string{"txfrom", "txto", "txval", "txaddr", "txhash", "txdate", "txsym"}
-	data := make(map[DataTyp]string)
+	data := make(map[string]string)
 
 	for _, key := range keys {
-		value, err := db.Get(ctx, ToBytes(key))
+		value, err := db.Get(ctx, []byte(key))
 		if err != nil {
-			return "", fmt.Errorf("failed to get %s: %v", ToBytes(key), err)
+			return "", fmt.Errorf("failed to get %s: %v", key, err)
 		}
 		data[key] = string(value)
 	}
 
 	// Split the data
-	senders := strings.Split(string(data[DATA_TX_SENDERS]), "\n")
+	senders := strings.Split(string(data["txfrom"]), "\n")
-	recipients := strings.Split(string(data[DATA_TX_RECIPIENTS]), "\n")
+	recipients := strings.Split(string(data["txto"]), "\n")
-	values := strings.Split(string(data[DATA_TX_VALUES]), "\n")
+	values := strings.Split(string(data["txval"]), "\n")
-	addresses := strings.Split(string(data[DATA_TX_ADDRESSES]), "\n")
+	addresses := strings.Split(string(data["txaddr"]), "\n")
-	hashes := strings.Split(string(data[DATA_TX_HASHES]), "\n")
+	hashes := strings.Split(string(data["txhash"]), "\n")
-	dates := strings.Split(string(data[DATA_TX_DATES]), "\n")
+	dates := strings.Split(string(data["txdate"]), "\n")
-	syms := strings.Split(string(data[DATA_TX_SYMBOLS]), "\n")
+	syms := strings.Split(string(data["txsym"]), "\n")
 
 	// Check if index is within range
 	if index < 1 || index > len(senders) {

common/user_store.go

@@ -19,6 +19,7 @@ type UserDataStore struct {
 // ReadEntry retrieves an entry to the userdata store.
 func (store *UserDataStore) ReadEntry(ctx context.Context, sessionId string, typ DataTyp) ([]byte, error) {
 	store.SetPrefix(db.DATATYPE_USERDATA)
+	store.SetSession(sessionId)
 	k := PackKey(typ, []byte(sessionId))
 	return store.Get(ctx, k)
 }
@@ -27,6 +28,7 @@ func (store *UserDataStore) ReadEntry(ctx context.Context, sessionId string, typ
 // BUG: this uses sessionId twice
 func (store *UserDataStore) WriteEntry(ctx context.Context, sessionId string, typ DataTyp, value []byte) error {
 	store.SetPrefix(db.DATATYPE_USERDATA)
+	store.SetSession(sessionId)
 	k := PackKey(typ, []byte(sessionId))
 	return store.Put(ctx, k, value)
 }

common/vouchers.go

@@ -64,23 +64,22 @@ func ScaleDownBalance(balance, decimals string) string {
 
 // GetVoucherData retrieves and matches voucher data
 func GetVoucherData(ctx context.Context, db storage.PrefixDb, input string) (*dataserviceapi.TokenHoldings, error) {
-	keys := []DataTyp{DATA_VOUCHER_SYMBOLS, DATA_VOUCHER_BALANCES, DATA_VOUCHER_DECIMALS, DATA_VOUCHER_ADDRESSES}
+	keys := []string{"sym", "bal", "deci", "addr"}
-	data := make(map[DataTyp]string)
+	data := make(map[string]string)
 
 	for _, key := range keys {
-		value, err := db.Get(ctx, ToBytes(key))
+		value, err := db.Get(ctx, []byte(key))
 		if err != nil {
-			return nil, fmt.Errorf("failed to get %s: %v", ToBytes(key), err)
+			return nil, fmt.Errorf("failed to get %s: %v", key, err)
 		}
 		data[key] = string(value)
 	}
 
 	symbol, balance, decimal, address := MatchVoucher(input,
-		data[DATA_VOUCHER_SYMBOLS],
+		data["sym"],
-		data[DATA_VOUCHER_BALANCES],
+		data["bal"],
-		data[DATA_VOUCHER_DECIMALS],
+		data["deci"],
-		data[DATA_VOUCHER_ADDRESSES],
+		data["addr"])
-	)
 
 	if symbol == "" {
 		return nil, nil
@@ -152,7 +151,7 @@ func GetTemporaryVoucherData(ctx context.Context, store DataStore, sessionId str
 	return data, nil
 }
 
-// UpdateVoucherData updates the active voucher data in the DataStore.
+// UpdateVoucherData sets the active voucher data in the DataStore.
 func UpdateVoucherData(ctx context.Context, store DataStore, sessionId string, data *dataserviceapi.TokenHoldings) error {
 	logg.TraceCtxf(ctx, "dtal", "data", data)
 	// Active voucher data entries

common/vouchers_test.go

@@ -8,9 +8,8 @@ import (
 	"github.com/alecthomas/assert/v2"
 	"github.com/stretchr/testify/require"
 
-	visedb "git.defalsify.org/vise.git/db"
-	memdb "git.defalsify.org/vise.git/db/mem"
 	"git.grassecon.net/urdt/ussd/internal/storage"
+	memdb "git.defalsify.org/vise.git/db/mem"
 	dataserviceapi "github.com/grassrootseconomics/ussd-data-service/pkg/api"
 )
 
@@ -84,21 +83,19 @@ func TestGetVoucherData(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-
+	spdb := storage.NewSubPrefixDb(db, []byte("vouchers"))
-	prefix := ToBytes(visedb.DATATYPE_USERDATA)
-	spdb := storage.NewSubPrefixDb(db, prefix)
 
 	// Test voucher data
-	mockData := map[DataTyp][]byte{
+	mockData := map[string][]byte{
-		DATA_VOUCHER_SYMBOLS:   []byte("1:SRF\n2:MILO"),
+		"sym":  []byte("1:SRF\n2:MILO"),
-		DATA_VOUCHER_BALANCES:  []byte("1:100\n2:200"),
+		"bal":  []byte("1:100\n2:200"),
-		DATA_VOUCHER_DECIMALS:  []byte("1:6\n2:4"),
+		"deci": []byte("1:6\n2:4"),
-		DATA_VOUCHER_ADDRESSES: []byte("1:0xd4c288865Ce\n2:0x41c188d63Qa"),
+		"addr": []byte("1:0xd4c288865Ce\n2:0x41c188d63Qa"),
 	}
 
 	// Put the data
 	for key, value := range mockData {
-		err = spdb.Put(ctx, []byte(ToBytes(key)), []byte(value))
+		err = spdb.Put(ctx, []byte(key), []byte(value))
 		if err != nil {
 			t.Fatal(err)
 		}

internal/handlers/base.go

@@ -55,9 +55,6 @@ func(f *BaseSessionHandler) Process(rqs RequestSession) (RequestSession, error)
 	}
 
 	f.hn = f.hn.WithPersister(rqs.Storage.Persister)
-	defer func() {
-		f.hn.Exit()
-	}()
 	eni := f.GetEngine(rqs.Config, f.rs, rqs.Storage.Persister)
 	en, ok := eni.(*engine.DefaultEngine)
 	if !ok {

internal/handlers/handlerservice.go

@@ -121,8 +121,6 @@ func (ls *LocalHandlerService) GetHandler(accountService remote.AccountServiceIn
 	ls.DbRs.AddLocalFunc("check_transactions", ussdHandlers.CheckTransactions)
 	ls.DbRs.AddLocalFunc("get_transactions", ussdHandlers.GetTransactionsList)
 	ls.DbRs.AddLocalFunc("view_statement", ussdHandlers.ViewTransactionStatement)
-	ls.DbRs.AddLocalFunc("update_all_profile_items", ussdHandlers.UpdateAllProfileItems)
-	ls.DbRs.AddLocalFunc("set_back", ussdHandlers.SetBack)
 
 	return ussdHandlers, nil
 }

internal/handlers/ussd/menuhandler.go

@@ -10,6 +10,7 @@ import (
 	"strings"
 
 	"git.defalsify.org/vise.git/asm"
+	"github.com/grassrootseconomics/eth-custodial/pkg/api"
 
 	"git.defalsify.org/vise.git/cache"
 	"git.defalsify.org/vise.git/db"
@@ -20,18 +21,18 @@ import (
 	"git.defalsify.org/vise.git/state"
 	"git.grassecon.net/urdt/ussd/common"
 	"git.grassecon.net/urdt/ussd/internal/utils"
-	"git.grassecon.net/urdt/ussd/models"
 	"git.grassecon.net/urdt/ussd/remote"
 	"gopkg.in/leonelquinteros/gotext.v1"
 
 	"git.grassecon.net/urdt/ussd/internal/storage"
-	dataserviceapi "github.com/grassrootseconomics/ussd-data-service/pkg/api"
 )
 
 var (
 	logg           = logging.NewVanilla().WithDomain("ussdmenuhandler")
 	scriptDir      = path.Join("services", "registration")
 	translationDir = path.Join(scriptDir, "locale")
+	okResponse     *api.OKResponse
+	errResponse    *api.ErrResponse
 )
 
 // Define the regex patterns as constants
@@ -77,7 +78,6 @@ type Handlers struct {
 	flagManager    *asm.FlagParser
 	accountService remote.AccountServiceInterface
 	prefixDb       storage.PrefixDb
-	profile        *models.Profile
 }
 
 func NewHandlers(appFlags *asm.FlagParser, userdataStore db.Db, adminstore *utils.AdminStore, accountService remote.AccountServiceInterface) (*Handlers, error) {
@@ -87,10 +87,8 @@ func NewHandlers(appFlags *asm.FlagParser, userdataStore db.Db, adminstore *util
 	userDb := &common.UserDataStore{
 		Db: userdataStore,
 	}
-
+	// Instantiate the SubPrefixDb with "vouchers" prefix
-	// Instantiate the SubPrefixDb with "DATATYPE_USERDATA" prefix
+	prefixDb := storage.NewSubPrefixDb(userdataStore, []byte("vouchers"))
-	prefix := common.ToBytes(db.DATATYPE_USERDATA)
-	prefixDb := storage.NewSubPrefixDb(userdataStore, prefix)
 
 	h := &Handlers{
 		userdataStore:  userDb,
@@ -98,7 +96,6 @@ func NewHandlers(appFlags *asm.FlagParser, userdataStore db.Db, adminstore *util
 		adminstore:     adminstore,
 		accountService: accountService,
 		prefixDb:       prefixDb,
-		profile:        &models.Profile{Max: 6},
 	}
 	return h, nil
 }
@@ -117,9 +114,6 @@ func (h *Handlers) Init(ctx context.Context, sym string, input []byte) (resource
 		logg.WarnCtxf(ctx, "handler init called before it is ready or more than once", "state", h.st, "cache", h.ca)
 		return r, nil
 	}
-	defer func() {
-		h.Exit()
-	}()
 
 	h.st = h.pe.GetState()
 	h.ca = h.pe.GetMemory()
@@ -139,16 +133,13 @@ func (h *Handlers) Init(ctx context.Context, sym string, input []byte) (resource
 		logg.ErrorCtxf(ctx, "perister fail in handler", "state", h.st, "cache", h.ca)
 		return r, fmt.Errorf("cannot get state and memory for handler")
 	}
+	h.pe = nil
 
 	logg.DebugCtxf(ctx, "handler has been initialized", "state", h.st, "cache", h.ca)
 
 	return r, nil
 }
 
-func (h *Handlers) Exit() {
-	h.pe = nil
-}
-
 // SetLanguage sets the language across the menu
 func (h *Handlers) SetLanguage(ctx context.Context, sym string, input []byte) (resource.Result, error) {
 	var res resource.Result
@@ -157,8 +148,7 @@ func (h *Handlers) SetLanguage(ctx context.Context, sym string, input []byte) (r
 	code := strings.Split(symbol, "_")[1]
 
 	if !utils.IsValidISO639(code) {
-		//Fallback to english instead?
+		return res, nil
-		code = "eng"
 	}
 	res.FlagSet = append(res.FlagSet, state.FLAG_LANG)
 	res.Content = code
@@ -416,10 +406,7 @@ func (h *Handlers) SaveFirstname(ctx context.Context, sym string, input []byte)
 	firstName := string(input)
 	store := h.userdataStore
 	flag_allow_update, _ := h.flagManager.GetFlag("flag_allow_update")
-	flag_firstname_set, _ := h.flagManager.GetFlag("flag_firstname_set")
-
 	allowUpdate := h.st.MatchFlag(flag_allow_update, true)
-	firstNameSet := h.st.MatchFlag(flag_firstname_set, true)
 	if allowUpdate {
 		temporaryFirstName, _ := store.ReadEntry(ctx, sessionId, common.DATA_TEMPORARY_VALUE)
 		err = store.WriteEntry(ctx, sessionId, common.DATA_FIRST_NAME, []byte(temporaryFirstName))
@@ -427,16 +414,11 @@ func (h *Handlers) SaveFirstname(ctx context.Context, sym string, input []byte)
 			logg.ErrorCtxf(ctx, "failed to write firstName entry with", "key", common.DATA_FIRST_NAME, "value", temporaryFirstName, "error", err)
 			return res, err
 		}
-		res.FlagSet = append(res.FlagSet, flag_firstname_set)
 	} else {
-		if firstNameSet {
+		err = store.WriteEntry(ctx, sessionId, common.DATA_TEMPORARY_VALUE, []byte(firstName))
-			err = store.WriteEntry(ctx, sessionId, common.DATA_TEMPORARY_VALUE, []byte(firstName))
+		if err != nil {
-			if err != nil {
+			logg.ErrorCtxf(ctx, "failed to write temporaryFirstName entry with", "key", common.DATA_TEMPORARY_VALUE, "value", firstName, "error", err)
-				logg.ErrorCtxf(ctx, "failed to write temporaryFirstName entry with", "key", common.DATA_TEMPORARY_VALUE, "value", firstName, "error", err)
+			return res, err
-				return res, err
-			}
-		} else {
-			h.profile.InsertOrShift(0, firstName)
 		}
 	}
 
@@ -456,9 +438,7 @@ func (h *Handlers) SaveFamilyname(ctx context.Context, sym string, input []byte)
 	familyName := string(input)
 
 	flag_allow_update, _ := h.flagManager.GetFlag("flag_allow_update")
-	flag_familyname_set, _ := h.flagManager.GetFlag("flag_familyname_set")
 	allowUpdate := h.st.MatchFlag(flag_allow_update, true)
-	familyNameSet := h.st.MatchFlag(flag_familyname_set, true)
 
 	if allowUpdate {
 		temporaryFamilyName, _ := store.ReadEntry(ctx, sessionId, common.DATA_TEMPORARY_VALUE)
@@ -467,16 +447,11 @@ func (h *Handlers) SaveFamilyname(ctx context.Context, sym string, input []byte)
 			logg.ErrorCtxf(ctx, "failed to write familyName entry with", "key", common.DATA_FAMILY_NAME, "value", temporaryFamilyName, "error", err)
 			return res, err
 		}
-		res.FlagSet = append(res.FlagSet, flag_familyname_set)
 	} else {
-		if familyNameSet {
+		err = store.WriteEntry(ctx, sessionId, common.DATA_TEMPORARY_VALUE, []byte(familyName))
-			err = store.WriteEntry(ctx, sessionId, common.DATA_TEMPORARY_VALUE, []byte(familyName))
+		if err != nil {
-			if err != nil {
+			logg.ErrorCtxf(ctx, "failed to write temporaryFamilyName entry with", "key", common.DATA_TEMPORARY_VALUE, "value", familyName, "error", err)
-				logg.ErrorCtxf(ctx, "failed to write temporaryFamilyName entry with", "key", common.DATA_TEMPORARY_VALUE, "value", familyName, "error", err)
+			return res, err
-				return res, err
-			}
-		} else {
-			h.profile.InsertOrShift(1, familyName)
 		}
 	}
 
@@ -494,10 +469,7 @@ func (h *Handlers) SaveYob(ctx context.Context, sym string, input []byte) (resou
 	yob := string(input)
 	store := h.userdataStore
 	flag_allow_update, _ := h.flagManager.GetFlag("flag_allow_update")
-	flag_yob_set, _ := h.flagManager.GetFlag("flag_yob_set")
-
 	allowUpdate := h.st.MatchFlag(flag_allow_update, true)
-	yobSet := h.st.MatchFlag(flag_yob_set, true)
 
 	if allowUpdate {
 		temporaryYob, _ := store.ReadEntry(ctx, sessionId, common.DATA_TEMPORARY_VALUE)
@@ -506,16 +478,11 @@ func (h *Handlers) SaveYob(ctx context.Context, sym string, input []byte) (resou
 			logg.ErrorCtxf(ctx, "failed to write yob entry with", "key", common.DATA_TEMPORARY_VALUE, "value", temporaryYob, "error", err)
 			return res, err
 		}
-		res.FlagSet = append(res.FlagSet, flag_yob_set)
 	} else {
-		if yobSet {
+		err = store.WriteEntry(ctx, sessionId, common.DATA_TEMPORARY_VALUE, []byte(yob))
-			err = store.WriteEntry(ctx, sessionId, common.DATA_TEMPORARY_VALUE, []byte(yob))
+		if err != nil {
-			if err != nil {
+			logg.ErrorCtxf(ctx, "failed to write temporaryYob entry with", "key", common.DATA_TEMPORARY_VALUE, "value", yob, "error", err)
-				logg.ErrorCtxf(ctx, "failed to write temporaryYob entry with", "key", common.DATA_TEMPORARY_VALUE, "value", yob, "error", err)
+			return res, err
-				return res, err
-			}
-		} else {
-			h.profile.InsertOrShift(3, yob)
 		}
 	}
 
@@ -534,9 +501,7 @@ func (h *Handlers) SaveLocation(ctx context.Context, sym string, input []byte) (
 	store := h.userdataStore
 
 	flag_allow_update, _ := h.flagManager.GetFlag("flag_allow_update")
-	flag_location_set, _ := h.flagManager.GetFlag("flag_location_set")
 	allowUpdate := h.st.MatchFlag(flag_allow_update, true)
-	locationSet := h.st.MatchFlag(flag_location_set, true)
 
 	if allowUpdate {
 		temporaryLocation, _ := store.ReadEntry(ctx, sessionId, common.DATA_TEMPORARY_VALUE)
@@ -545,17 +510,11 @@ func (h *Handlers) SaveLocation(ctx context.Context, sym string, input []byte) (
 			logg.ErrorCtxf(ctx, "failed to write location entry with", "key", common.DATA_LOCATION, "value", temporaryLocation, "error", err)
 			return res, err
 		}
-		res.FlagSet = append(res.FlagSet, flag_location_set)
 	} else {
-		if locationSet {
+		err = store.WriteEntry(ctx, sessionId, common.DATA_TEMPORARY_VALUE, []byte(location))
-			err = store.WriteEntry(ctx, sessionId, common.DATA_TEMPORARY_VALUE, []byte(location))
+		if err != nil {
-			if err != nil {
+			logg.ErrorCtxf(ctx, "failed to write temporaryLocation entry with", "key", common.DATA_TEMPORARY_VALUE, "value", location, "error", err)
-				logg.ErrorCtxf(ctx, "failed to write temporaryLocation entry with", "key", common.DATA_TEMPORARY_VALUE, "value", location, "error", err)
+			return res, err
-				return res, err
-			}
-			res.FlagSet = append(res.FlagSet, flag_location_set)
-		} else {
-			h.profile.InsertOrShift(4, location)
 		}
 	}
 
@@ -574,10 +533,7 @@ func (h *Handlers) SaveGender(ctx context.Context, sym string, input []byte) (re
 	gender := strings.Split(symbol, "_")[1]
 	store := h.userdataStore
 	flag_allow_update, _ := h.flagManager.GetFlag("flag_allow_update")
-	flag_gender_set, _ := h.flagManager.GetFlag("flag_gender_set")
-
 	allowUpdate := h.st.MatchFlag(flag_allow_update, true)
-	genderSet := h.st.MatchFlag(flag_gender_set, true)
 
 	if allowUpdate {
 		temporaryGender, _ := store.ReadEntry(ctx, sessionId, common.DATA_TEMPORARY_VALUE)
@@ -586,16 +542,11 @@ func (h *Handlers) SaveGender(ctx context.Context, sym string, input []byte) (re
 			logg.ErrorCtxf(ctx, "failed to write gender entry with", "key", common.DATA_GENDER, "value", gender, "error", err)
 			return res, err
 		}
-		res.FlagSet = append(res.FlagSet, flag_gender_set)
 	} else {
-		if genderSet {
+		err = store.WriteEntry(ctx, sessionId, common.DATA_TEMPORARY_VALUE, []byte(gender))
-			err = store.WriteEntry(ctx, sessionId, common.DATA_TEMPORARY_VALUE, []byte(gender))
+		if err != nil {
-			if err != nil {
+			logg.ErrorCtxf(ctx, "failed to write temporaryGender entry with", "key", common.DATA_TEMPORARY_VALUE, "value", gender, "error", err)
-				logg.ErrorCtxf(ctx, "failed to write temporaryGender entry with", "key", common.DATA_TEMPORARY_VALUE, "value", gender, "error", err)
+			return res, err
-				return res, err
-			}
-		} else {
-			h.profile.InsertOrShift(2, gender)
 		}
 	}
 
@@ -615,10 +566,7 @@ func (h *Handlers) SaveOfferings(ctx context.Context, sym string, input []byte)
 	store := h.userdataStore
 
 	flag_allow_update, _ := h.flagManager.GetFlag("flag_allow_update")
-	flag_offerings_set, _ := h.flagManager.GetFlag("flag_offerings_set")
-
 	allowUpdate := h.st.MatchFlag(flag_allow_update, true)
-	offeringsSet := h.st.MatchFlag(flag_offerings_set, true)
 
 	if allowUpdate {
 		temporaryOfferings, _ := store.ReadEntry(ctx, sessionId, common.DATA_TEMPORARY_VALUE)
@@ -627,16 +575,11 @@ func (h *Handlers) SaveOfferings(ctx context.Context, sym string, input []byte)
 			logg.ErrorCtxf(ctx, "failed to write offerings entry with", "key", common.DATA_TEMPORARY_VALUE, "value", offerings, "error", err)
 			return res, err
 		}
-		res.FlagSet = append(res.FlagSet, flag_offerings_set)
 	} else {
-		if offeringsSet {
+		err = store.WriteEntry(ctx, sessionId, common.DATA_TEMPORARY_VALUE, []byte(offerings))
-			err = store.WriteEntry(ctx, sessionId, common.DATA_TEMPORARY_VALUE, []byte(offerings))
+		if err != nil {
-			if err != nil {
+			logg.ErrorCtxf(ctx, "failed to write temporaryOfferings entry with", "key", common.DATA_TEMPORARY_VALUE, "value", offerings, "error", err)
-				logg.ErrorCtxf(ctx, "failed to write temporaryOfferings entry with", "key", common.DATA_TEMPORARY_VALUE, "value", offerings, "error", err)
+			return res, err
-				return res, err
-			}
-		} else {
-			h.profile.InsertOrShift(5, offerings)
 		}
 	}
 
@@ -729,18 +672,6 @@ func (h *Handlers) ResetIncorrectPin(ctx context.Context, sym string, input []by
 	return res, nil
 }
 
-// Setback sets the flag_back_set flag when the navigation is back
-func (h *Handlers) SetBack(ctx context.Context, sym string, input []byte) (resource.Result, error) {
-	var res resource.Result
-	//TODO:
-	//Add check if the navigation is lateral nav instead of checking the input.
-	if string(input) == "0" {
-		flag_back_set, _ := h.flagManager.GetFlag("flag_back_set")
-		res.FlagSet = append(res.FlagSet, flag_back_set)
-	}
-	return res, nil
-}
-
 // CheckAccountStatus queries the API using the TrackingId and sets flags
 // based on the account status
 func (h *Handlers) CheckAccountStatus(ctx context.Context, sym string, input []byte) (resource.Result, error) {
@@ -826,11 +757,12 @@ func (h *Handlers) VerifyYob(ctx context.Context, sym string, input []byte) (res
 		return res, nil
 	}
 
-	if utils.IsValidYOb(date) {
+	if len(date) == 4 {
 		res.FlagReset = append(res.FlagReset, flag_incorrect_date_format)
 	} else {
 		res.FlagSet = append(res.FlagSet, flag_incorrect_date_format)
 	}
+
 	return res, nil
 }
 
@@ -879,17 +811,7 @@ func (h *Handlers) CheckBalance(ctx context.Context, sym string, input []byte) (
 		return res, err
 	}
 
-	// Convert activeBal from []byte to float64
+	res.Content = l.Get("Balance: %s\n", fmt.Sprintf("%s %s", activeBal, activeSym))
-	balFloat, err := strconv.ParseFloat(string(activeBal), 64)
-	if err != nil {
-		logg.ErrorCtxf(ctx, "failed to parse activeBal as float", "value", string(activeBal), "error", err)
-		return res, err
-	}
-
-	// Format to 2 decimal places
-	balStr := fmt.Sprintf("%.2f %s", balFloat, activeSym)
-
-	res.Content = l.Get("Balance: %s\n", balStr)
 
 	return res, nil
 }
@@ -1340,17 +1262,6 @@ func (h *Handlers) GetCurrentProfileInfo(ctx context.Context, sym string, input
 	var res resource.Result
 	var profileInfo []byte
 	var err error
-
-	flag_firstname_set, _ := h.flagManager.GetFlag("flag_firstname_set")
-	flag_familyname_set, _ := h.flagManager.GetFlag("flag_familyname_set")
-	flag_yob_set, _ := h.flagManager.GetFlag("flag_yob_set")
-	flag_gender_set, _ := h.flagManager.GetFlag("flag_gender_set")
-	flag_location_set, _ := h.flagManager.GetFlag("flag_location_set")
-	flag_offerings_set, _ := h.flagManager.GetFlag("flag_offerings_set")
-	flag_back_set, _ := h.flagManager.GetFlag("flag_back_set")
-
-	res.FlagReset = append(res.FlagReset, flag_back_set)
-
 	sessionId, ok := ctx.Value("SessionId").(string)
 	if !ok {
 		return res, fmt.Errorf("missing session")
@@ -1377,7 +1288,6 @@ func (h *Handlers) GetCurrentProfileInfo(ctx context.Context, sym string, input
 			logg.ErrorCtxf(ctx, "Failed to read first name entry with", "key", "error", common.DATA_FIRST_NAME, err)
 			return res, err
 		}
-		res.FlagSet = append(res.FlagSet, flag_firstname_set)
 		res.Content = string(profileInfo)
 	case common.DATA_FAMILY_NAME:
 		profileInfo, err = store.ReadEntry(ctx, sessionId, common.DATA_FAMILY_NAME)
@@ -1389,7 +1299,6 @@ func (h *Handlers) GetCurrentProfileInfo(ctx context.Context, sym string, input
 			logg.ErrorCtxf(ctx, "Failed to read family name entry with", "key", "error", common.DATA_FAMILY_NAME, err)
 			return res, err
 		}
-		res.FlagSet = append(res.FlagSet, flag_familyname_set)
 		res.Content = string(profileInfo)
 
 	case common.DATA_GENDER:
@@ -1402,7 +1311,6 @@ func (h *Handlers) GetCurrentProfileInfo(ctx context.Context, sym string, input
 			logg.ErrorCtxf(ctx, "Failed to read gender entry with", "key", "error", common.DATA_GENDER, err)
 			return res, err
 		}
-		res.FlagSet = append(res.FlagSet, flag_gender_set)
 		res.Content = string(profileInfo)
 	case common.DATA_YOB:
 		profileInfo, err = store.ReadEntry(ctx, sessionId, common.DATA_YOB)
@@ -1414,8 +1322,8 @@ func (h *Handlers) GetCurrentProfileInfo(ctx context.Context, sym string, input
 			logg.ErrorCtxf(ctx, "Failed to read year of birth(yob) entry with", "key", "error", common.DATA_YOB, err)
 			return res, err
 		}
-		res.FlagSet = append(res.FlagSet, flag_yob_set)
 		res.Content = string(profileInfo)
+
 	case common.DATA_LOCATION:
 		profileInfo, err = store.ReadEntry(ctx, sessionId, common.DATA_LOCATION)
 		if err != nil {
@@ -1426,7 +1334,6 @@ func (h *Handlers) GetCurrentProfileInfo(ctx context.Context, sym string, input
 			logg.ErrorCtxf(ctx, "Failed to read location entry with", "key", "error", common.DATA_LOCATION, err)
 			return res, err
 		}
-		res.FlagSet = append(res.FlagSet, flag_location_set)
 		res.Content = string(profileInfo)
 	case common.DATA_OFFERINGS:
 		profileInfo, err = store.ReadEntry(ctx, sessionId, common.DATA_OFFERINGS)
@@ -1438,7 +1345,6 @@ func (h *Handlers) GetCurrentProfileInfo(ctx context.Context, sym string, input
 			logg.ErrorCtxf(ctx, "Failed to read offerings entry with", "key", "error", common.DATA_OFFERINGS, err)
 			return res, err
 		}
-		res.FlagSet = append(res.FlagSet, flag_offerings_set)
 		res.Content = string(profileInfo)
 	default:
 		break
@@ -1482,7 +1388,14 @@ func (h *Handlers) GetProfileInfo(ctx context.Context, sym string, input []byte)
 	offerings := getEntryOrDefault(store.ReadEntry(ctx, sessionId, common.DATA_OFFERINGS))
 
 	// Construct the full name
-	name := utils.ConstructName(firstName, familyName, defaultValue)
+	name := defaultValue
+	if familyName != defaultValue {
+		if firstName == defaultValue {
+			name = familyName
+		} else {
+			name = firstName + " " + familyName
+		}
+	}
 
 	// Calculate age from year of birth
 	age := defaultValue
@@ -1621,50 +1534,18 @@ func (h *Handlers) CheckVouchers(ctx context.Context, sym string, input []byte)
 		return res, nil
 	}
 
-	// check the current active sym and update the data
-	activeSym, _ := store.ReadEntry(ctx, sessionId, common.DATA_ACTIVE_SYM)
-	if activeSym != nil {
-		activeSymStr := string(activeSym)
-
-		// Find the matching voucher data
-		var activeData *dataserviceapi.TokenHoldings
-		for _, voucher := range vouchersResp {
-			if voucher.TokenSymbol == activeSymStr {
-				activeData = &voucher
-				break
-			}
-		}
-
-		if activeData == nil {
-			logg.ErrorCtxf(ctx, "activeSym not found in vouchers", "activeSym", activeSymStr)
-			return res, fmt.Errorf("activeSym %s not found in vouchers", activeSymStr)
-		}
-
-		// Scale down the balance
-		scaledBalance := common.ScaleDownBalance(activeData.Balance, activeData.TokenDecimals)
-
-		// Update the balance field with the scaled value
-		activeData.Balance = scaledBalance
-
-		// Pass the matching voucher data to UpdateVoucherData
-		if err := common.UpdateVoucherData(ctx, h.userdataStore, sessionId, activeData); err != nil {
-			logg.ErrorCtxf(ctx, "failed on UpdateVoucherData", "error", err)
-			return res, err
-		}
-	}
-
 	data := common.ProcessVouchers(vouchersResp)
 
 	// Store all voucher data
-	dataMap := map[common.DataTyp]string{
+	dataMap := map[string]string{
-		common.DATA_VOUCHER_SYMBOLS:   data.Symbols,
+		"sym":  data.Symbols,
-		common.DATA_VOUCHER_BALANCES:  data.Balances,
+		"bal":  data.Balances,
-		common.DATA_VOUCHER_DECIMALS:  data.Decimals,
+		"deci": data.Decimals,
-		common.DATA_VOUCHER_ADDRESSES: data.Addresses,
+		"addr": data.Addresses,
 	}
 
 	for key, value := range dataMap {
-		if err := h.prefixDb.Put(ctx, []byte(common.ToBytes(key)), []byte(value)); err != nil {
+		if err := h.prefixDb.Put(ctx, []byte(key), []byte(value)); err != nil {
 			return res, nil
 		}
 	}
@@ -1677,7 +1558,7 @@ func (h *Handlers) GetVoucherList(ctx context.Context, sym string, input []byte)
 	var res resource.Result
 
 	// Read vouchers from the store
-	voucherData, err := h.prefixDb.Get(ctx, common.ToBytes(common.DATA_VOUCHER_SYMBOLS))
+	voucherData, err := h.prefixDb.Get(ctx, []byte("sym"))
 	if err != nil {
 		logg.ErrorCtxf(ctx, "Failed to read the voucherData from prefixDb", "error", err)
 		return res, err
@@ -1697,10 +1578,6 @@ func (h *Handlers) ViewVoucher(ctx context.Context, sym string, input []byte) (r
 		return res, fmt.Errorf("missing session")
 	}
 
-	code := codeFromCtx(ctx)
-	l := gotext.NewLocale(translationDir, code)
-	l.AddDomain("default")
-
 	flag_incorrect_voucher, _ := h.flagManager.GetFlag("flag_incorrect_voucher")
 
 	inputStr := string(input)
@@ -1725,7 +1602,7 @@ func (h *Handlers) ViewVoucher(ctx context.Context, sym string, input []byte) (r
 	}
 
 	res.FlagReset = append(res.FlagReset, flag_incorrect_voucher)
-	res.Content = l.Get("Symbol: %s\nBalance: %s", metadata.TokenSymbol, metadata.Balance)
+	res.Content = fmt.Sprintf("%s\n%s", metadata.TokenSymbol, metadata.Balance)
 
 	return res, nil
 }
@@ -1781,9 +1658,10 @@ func (h *Handlers) GetVoucherDetails(ctx context.Context, sym string, input []by
 		return res, nil
 	}
 
-	res.Content = fmt.Sprintf(
+	tokenSymbol := voucherData.TokenSymbol
-		"Name: %s\nSymbol: %s\nCommodity: %s\nLocation: %s", voucherData.TokenName, voucherData.TokenSymbol, voucherData.TokenCommodity, voucherData.TokenLocation,
+	tokenName := voucherData.TokenName
-	)
+
+	res.Content = fmt.Sprintf("%s %s", tokenSymbol, tokenName)
 
 	return res, nil
 }
@@ -1823,19 +1701,19 @@ func (h *Handlers) CheckTransactions(ctx context.Context, sym string, input []by
 	data := common.ProcessTransfers(transactionsResp)
 
 	// Store all transaction data
-	dataMap := map[common.DataTyp]string{
+	dataMap := map[string]string{
-		common.DATA_TX_SENDERS:    data.Senders,
+		"txfrom": data.Senders,
-		common.DATA_TX_RECIPIENTS: data.Recipients,
+		"txto":   data.Recipients,
-		common.DATA_TX_VALUES:     data.TransferValues,
+		"txval":  data.TransferValues,
-		common.DATA_TX_ADDRESSES:  data.Addresses,
+		"txaddr": data.Addresses,
-		common.DATA_TX_HASHES:     data.TxHashes,
+		"txhash": data.TxHashes,
-		common.DATA_TX_DATES:      data.Dates,
+		"txdate": data.Dates,
-		common.DATA_TX_SYMBOLS:    data.Symbols,
+		"txsym":  data.Symbols,
-		common.DATA_TX_DECIMALS:   data.Decimals,
+		"txdeci": data.Decimals,
 	}
 
 	for key, value := range dataMap {
-		if err := h.prefixDb.Put(ctx, []byte(common.ToBytes(key)), []byte(value)); err != nil {
+		if err := h.prefixDb.Put(ctx, []byte(key), []byte(value)); err != nil {
 			logg.ErrorCtxf(ctx, "failed to write to prefixDb", "error", err)
 			return res, err
 		}
@@ -1861,22 +1739,22 @@ func (h *Handlers) GetTransactionsList(ctx context.Context, sym string, input []
 	}
 
 	// Read transactions from the store and format them
-	TransactionSenders, err := h.prefixDb.Get(ctx, common.ToBytes(common.DATA_TX_SENDERS))
+	TransactionSenders, err := h.prefixDb.Get(ctx, []byte("txfrom"))
 	if err != nil {
 		logg.ErrorCtxf(ctx, "Failed to read the TransactionSenders from prefixDb", "error", err)
 		return res, err
 	}
-	TransactionSyms, err := h.prefixDb.Get(ctx, common.ToBytes(common.DATA_TX_SYMBOLS))
+	TransactionSyms, err := h.prefixDb.Get(ctx, []byte("txsym"))
 	if err != nil {
 		logg.ErrorCtxf(ctx, "Failed to read the TransactionSyms from prefixDb", "error", err)
 		return res, err
 	}
-	TransactionValues, err := h.prefixDb.Get(ctx, common.ToBytes(common.DATA_TX_VALUES))
+	TransactionValues, err := h.prefixDb.Get(ctx, []byte("txval"))
 	if err != nil {
 		logg.ErrorCtxf(ctx, "Failed to read the TransactionValues from prefixDb", "error", err)
 		return res, err
 	}
-	TransactionDates, err := h.prefixDb.Get(ctx, common.ToBytes(common.DATA_TX_DATES))
+	TransactionDates, err := h.prefixDb.Get(ctx, []byte("txdate"))
 	if err != nil {
 		logg.ErrorCtxf(ctx, "Failed to read the TransactionDates from prefixDb", "error", err)
 		return res, err
@@ -1956,53 +1834,3 @@ func (h *Handlers) ViewTransactionStatement(ctx context.Context, sym string, inp
 
 	return res, nil
 }
-
-func (h *Handlers) insertProfileItems(ctx context.Context, sessionId string, res *resource.Result) error {
-	var err error
-	store := h.userdataStore
-	profileFlagNames := []string{
-		"flag_firstname_set",
-		"flag_familyname_set",
-		"flag_yob_set",
-		"flag_gender_set",
-		"flag_location_set",
-		"flag_offerings_set",
-	}
-	profileDataKeys := []common.DataTyp{
-		common.DATA_FIRST_NAME,
-		common.DATA_FAMILY_NAME,
-		common.DATA_GENDER,
-		common.DATA_YOB,
-		common.DATA_LOCATION,
-		common.DATA_OFFERINGS,
-	}
-	for index, profileItem := range h.profile.ProfileItems {
-		// Ensure the profileItem is not "0"(is set)
-		if profileItem != "0" {
-			err = store.WriteEntry(ctx, sessionId, profileDataKeys[index], []byte(profileItem))
-			if err != nil {
-				logg.ErrorCtxf(ctx, "failed to write profile entry with", "key", profileDataKeys[index], "value", profileItem, "error", err)
-				return err
-			}
-
-			// Get the flag for the current index
-			flag, _ := h.flagManager.GetFlag(profileFlagNames[index])
-			res.FlagSet = append(res.FlagSet, flag)
-		}
-	}
-	return nil
-}
-
-// UpdateAllProfileItems  is used to persist all the  new profile information and setup  the required profile flags
-func (h *Handlers) UpdateAllProfileItems(ctx context.Context, sym string, input []byte) (resource.Result, error) {
-	var res resource.Result
-	sessionId, ok := ctx.Value("SessionId").(string)
-	if !ok {
-		return res, fmt.Errorf("missing session")
-	}
-	err := h.insertProfileItems(ctx, sessionId, &res)
-	if err != nil {
-		return res, err
-	}
-	return res, nil
-}

internal/handlers/ussd/menuhandler_test.go

@@ -22,7 +22,6 @@ import (
 	testdataloader "github.com/peteole/testdata-loader"
 	"github.com/stretchr/testify/require"
 
-	visedb "git.defalsify.org/vise.git/db"
 	memdb "git.defalsify.org/vise.git/db/mem"
 	dataserviceapi "github.com/grassrootseconomics/ussd-data-service/pkg/api"
 )
@@ -57,8 +56,7 @@ func InitializeTestSubPrefixDb(t *testing.T, ctx context.Context) *storage.SubPr
 	if err != nil {
 		t.Fatal(err)
 	}
-	prefix := common.ToBytes(visedb.DATATYPE_USERDATA)
+	spdb := storage.NewSubPrefixDb(db, []byte("vouchers"))
-	spdb := storage.NewSubPrefixDb(db, prefix)
 
 	return spdb
 }
@@ -181,14 +179,11 @@ func TestSaveFirstname(t *testing.T) {
 	fm, _ := NewFlagManager(flagsPath)
 
 	flag_allow_update, _ := fm.GetFlag("flag_allow_update")
-	flag_firstname_set, _ := fm.GetFlag("flag_firstname_set")
 
 	// Set the flag in the State
-	mockState := state.NewState(128)
+	mockState := state.NewState(16)
 	mockState.SetFlag(flag_allow_update)
 
-	expectedResult := resource.Result{}
-
 	// Define test data
 	firstName := "John"
 
@@ -196,8 +191,6 @@ func TestSaveFirstname(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	expectedResult.FlagSet = []uint32{flag_firstname_set}
-
 	// Create the Handlers instance with the mock store
 	h := &Handlers{
 		userdataStore: store,
@@ -210,7 +203,7 @@ func TestSaveFirstname(t *testing.T) {
 
 	// Assert results
 	assert.NoError(t, err)
-	assert.Equal(t, expectedResult, res)
+	assert.Equal(t, resource.Result{}, res)
 
 	// Verify that the DATA_FIRST_NAME entry has been updated with the temporary value
 	storedFirstName, _ := store.ReadEntry(ctx, sessionId, common.DATA_FIRST_NAME)
@@ -225,16 +218,11 @@ func TestSaveFamilyname(t *testing.T) {
 	fm, _ := NewFlagManager(flagsPath)
 
 	flag_allow_update, _ := fm.GetFlag("flag_allow_update")
-	flag_firstname_set, _ := fm.GetFlag("flag_familyname_set")
 
 	// Set the flag in the State
-	mockState := state.NewState(128)
+	mockState := state.NewState(16)
 	mockState.SetFlag(flag_allow_update)
 
-	expectedResult := resource.Result{}
-
-	expectedResult.FlagSet = []uint32{flag_firstname_set}
-
 	// Define test data
 	familyName := "Doeee"
 
@@ -254,7 +242,7 @@ func TestSaveFamilyname(t *testing.T) {
 
 	// Assert results
 	assert.NoError(t, err)
-	assert.Equal(t, expectedResult, res)
+	assert.Equal(t, resource.Result{}, res)
 
 	// Verify that the DATA_FAMILY_NAME entry has been updated with the temporary value
 	storedFamilyName, _ := store.ReadEntry(ctx, sessionId, common.DATA_FAMILY_NAME)
@@ -269,14 +257,11 @@ func TestSaveYoB(t *testing.T) {
 	fm, _ := NewFlagManager(flagsPath)
 
 	flag_allow_update, _ := fm.GetFlag("flag_allow_update")
-	flag_yob_set, _ := fm.GetFlag("flag_yob_set")
 
 	// Set the flag in the State
-	mockState := state.NewState(108)
+	mockState := state.NewState(16)
 	mockState.SetFlag(flag_allow_update)
 
-	expectedResult := resource.Result{}
-
 	// Define test data
 	yob := "1980"
 
@@ -284,8 +269,6 @@ func TestSaveYoB(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	expectedResult.FlagSet = []uint32{flag_yob_set}
-
 	// Create the Handlers instance with the mock store
 	h := &Handlers{
 		userdataStore: store,
@@ -298,7 +281,7 @@ func TestSaveYoB(t *testing.T) {
 
 	// Assert results
 	assert.NoError(t, err)
-	assert.Equal(t, expectedResult, res)
+	assert.Equal(t, resource.Result{}, res)
 
 	// Verify that the DATA_YOB entry has been updated with the temporary value
 	storedYob, _ := store.ReadEntry(ctx, sessionId, common.DATA_YOB)
@@ -313,14 +296,11 @@ func TestSaveLocation(t *testing.T) {
 	fm, _ := NewFlagManager(flagsPath)
 
 	flag_allow_update, _ := fm.GetFlag("flag_allow_update")
-	flag_location_set, _ := fm.GetFlag("flag_location_set")
 
 	// Set the flag in the State
-	mockState := state.NewState(108)
+	mockState := state.NewState(16)
 	mockState.SetFlag(flag_allow_update)
 
-	expectedResult := resource.Result{}
-
 	// Define test data
 	location := "Kilifi"
 
@@ -328,8 +308,6 @@ func TestSaveLocation(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	expectedResult.FlagSet = []uint32{flag_location_set}
-
 	// Create the Handlers instance with the mock store
 	h := &Handlers{
 		userdataStore: store,
@@ -342,7 +320,7 @@ func TestSaveLocation(t *testing.T) {
 
 	// Assert results
 	assert.NoError(t, err)
-	assert.Equal(t, expectedResult, res)
+	assert.Equal(t, resource.Result{}, res)
 
 	// Verify that the DATA_LOCATION entry has been updated with the temporary value
 	storedLocation, _ := store.ReadEntry(ctx, sessionId, common.DATA_LOCATION)
@@ -357,14 +335,11 @@ func TestSaveOfferings(t *testing.T) {
 	fm, _ := NewFlagManager(flagsPath)
 
 	flag_allow_update, _ := fm.GetFlag("flag_allow_update")
-	flag_offerings_set, _ := fm.GetFlag("flag_offerings_set")
 
 	// Set the flag in the State
-	mockState := state.NewState(108)
+	mockState := state.NewState(16)
 	mockState.SetFlag(flag_allow_update)
 
-	expectedResult := resource.Result{}
-
 	// Define test data
 	offerings := "Bananas"
 
@@ -372,8 +347,6 @@ func TestSaveOfferings(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	expectedResult.FlagSet = []uint32{flag_offerings_set}
-
 	// Create the Handlers instance with the mock store
 	h := &Handlers{
 		userdataStore: store,
@@ -386,7 +359,7 @@ func TestSaveOfferings(t *testing.T) {
 
 	// Assert results
 	assert.NoError(t, err)
-	assert.Equal(t, expectedResult, res)
+	assert.Equal(t, resource.Result{}, res)
 
 	// Verify that the DATA_OFFERINGS entry has been updated with the temporary value
 	storedOfferings, _ := store.ReadEntry(ctx, sessionId, common.DATA_OFFERINGS)
@@ -401,10 +374,9 @@ func TestSaveGender(t *testing.T) {
 	fm, _ := NewFlagManager(flagsPath)
 
 	flag_allow_update, _ := fm.GetFlag("flag_allow_update")
-	flag_gender_set, _ := fm.GetFlag("flag_gender_set")
 
 	// Set the flag in the State
-	mockState := state.NewState(108)
+	mockState := state.NewState(16)
 	mockState.SetFlag(flag_allow_update)
 
 	// Define test cases
@@ -448,16 +420,12 @@ func TestSaveGender(t *testing.T) {
 				flagManager:   fm.parser,
 			}
 
-			expectedResult := resource.Result{}
-
 			// Call the method
 			res, err := h.SaveGender(ctx, "save_gender", tt.input)
 
-			expectedResult.FlagSet = []uint32{flag_gender_set}
-
 			// Assert results
 			assert.NoError(t, err)
-			assert.Equal(t, expectedResult, res)
+			assert.Equal(t, resource.Result{}, res)
 
 			// Verify that the DATA_GENDER entry has been updated with the temporary value
 			storedGender, _ := store.ReadEntry(ctx, sessionId, common.DATA_GENDER)
@@ -1530,10 +1498,10 @@ func TestValidateRecipient(t *testing.T) {
 	}{
 		{
 			name:  "Test with invalid recepient",
-			input: []byte("7?1234"),
+			input: []byte("9234adf5"),
 			expectedResult: resource.Result{
 				FlagSet: []uint32{flag_invalid_recipient},
-				Content: "7?1234",
+				Content: "9234adf5",
 			},
 		},
 		{
@@ -1549,40 +1517,22 @@ func TestValidateRecipient(t *testing.T) {
 			input:          []byte("0711223344"),
 			expectedResult: resource.Result{},
 		},
-		{
-			name:           "Test with address",
-			input:          []byte("0xd4c288865Ce0985a481Eef3be02443dF5E2e4Ea9"),
-			expectedResult: resource.Result{},
-		},
-		{
-			name:           "Test with alias recepient",
-			input:          []byte("alias123"),
-			expectedResult: resource.Result{},
-		},
 	}
 
 	// store a public key for the valid recipient
-	err = store.WriteEntry(ctx, "+254711223344", common.DATA_PUBLIC_KEY, []byte(publicKey))
+	err = store.WriteEntry(ctx, "0711223344", common.DATA_PUBLIC_KEY, []byte(publicKey))
 	if err != nil {
 		t.Fatal(err)
 	}
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			mockAccountService := new(mocks.MockAccountService)
 			// Create the Handlers instance
 			h := &Handlers{
-				flagManager:    fm.parser,
+				flagManager:   fm.parser,
-				userdataStore:  store,
+				userdataStore: store,
-				accountService: mockAccountService,
 			}
 
-			aliasResponse := &dataserviceapi.AliasAddress{
-				Address: "0xd4c288865Ce0985a481Eef3be02443dF5E2e4Ea9",
-			}
-
-			mockAccountService.On("CheckAliasAddress", string(tt.input)).Return(aliasResponse, nil)
-
 			// Call the method
 			res, err := h.ValidateRecipient(ctx, "validate_recepient", tt.input)
 
@@ -1614,7 +1564,7 @@ func TestCheckBalance(t *testing.T) {
 			publicKey:      "0X98765432109",
 			activeSym:      "ETH",
 			activeBal:      "1.5",
-			expectedResult: resource.Result{Content: "Balance: 1.50 ETH\n"},
+			expectedResult: resource.Result{Content: "Balance: 1.5 ETH\n"},
 			expectError:    false,
 		},
 	}
@@ -1969,7 +1919,7 @@ func TestCheckVouchers(t *testing.T) {
 	assert.NoError(t, err)
 
 	// Read voucher sym data from the store
-	voucherData, err := spdb.Get(ctx, common.ToBytes(common.DATA_VOUCHER_SYMBOLS))
+	voucherData, err := spdb.Get(ctx, []byte("sym"))
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -1993,7 +1943,7 @@ func TestGetVoucherList(t *testing.T) {
 	expectedSym := []byte("1:SRF\n2:MILO")
 
 	// Put voucher sym data from the store
-	err := spdb.Put(ctx, common.ToBytes(common.DATA_VOUCHER_SYMBOLS), expectedSym)
+	err := spdb.Put(ctx, []byte("sym"), expectedSym)
 	if err != nil {
 		t.Fatal(err)
 	}
@@ -2023,16 +1973,16 @@ func TestViewVoucher(t *testing.T) {
 	}
 
 	// Define mock voucher data
-	mockData := map[common.DataTyp][]byte{
+	mockData := map[string][]byte{
-		common.DATA_VOUCHER_SYMBOLS:   []byte("1:SRF\n2:MILO"),
+		"sym":  []byte("1:SRF\n2:MILO"),
-		common.DATA_VOUCHER_BALANCES:  []byte("1:100\n2:200"),
+		"bal":  []byte("1:100\n2:200"),
-		common.DATA_VOUCHER_DECIMALS:  []byte("1:6\n2:4"),
+		"deci": []byte("1:6\n2:4"),
-		common.DATA_VOUCHER_ADDRESSES: []byte("1:0xd4c288865Ce\n2:0x41c188d63Qa"),
+		"addr": []byte("1:0xd4c288865Ce\n2:0x41c188d63Qa"),
 	}
 
 	// Put the data
 	for key, value := range mockData {
-		err = spdb.Put(ctx, []byte(common.ToBytes(key)), []byte(value))
+		err = spdb.Put(ctx, []byte(key), []byte(value))
 		if err != nil {
 			t.Fatal(err)
 		}
@@ -2040,7 +1990,7 @@ func TestViewVoucher(t *testing.T) {
 
 	res, err := h.ViewVoucher(ctx, "view_voucher", []byte("1"))
 	assert.NoError(t, err)
-	assert.Equal(t, res.Content, "Symbol: SRF\nBalance: 100")
+	assert.Equal(t, res.Content, "SRF\n100")
 }
 
 func TestSetVoucher(t *testing.T) {
@@ -2074,42 +2024,3 @@ func TestSetVoucher(t *testing.T) {
 
 	assert.Equal(t, string(tempData.TokenSymbol), res.Content)
 }
-
-func TestGetVoucherDetails(t *testing.T) {
-	ctx, store := InitializeTestStore(t)
-	fm, err := NewFlagManager(flagsPath)
-	if err != nil {
-		t.Logf(err.Error())
-	}
-	mockAccountService := new(mocks.MockAccountService)
-
-	sessionId := "session123"
-	ctx = context.WithValue(ctx, "SessionId", sessionId)
-	expectedResult := resource.Result{}
-
-	tokA_AAddress := "0x0000000000000000000000000000000000000000"
-
-	h := &Handlers{
-		userdataStore:  store,
-		flagManager:    fm.parser,
-		accountService: mockAccountService,
-	}
-	err = store.WriteEntry(ctx, sessionId, common.DATA_ACTIVE_ADDRESS, []byte(tokA_AAddress))
-	if err != nil {
-		t.Fatal(err)
-	}
-	tokenDetails := &models.VoucherDataResult{
-		TokenName:      "Token A",
-		TokenSymbol:    "TOKA",
-		TokenLocation:  "Kilifi,Kenya",
-		TokenCommodity: "Farming",
-	}
-	expectedResult.Content = fmt.Sprintf(
-		"Name: %s\nSymbol: %s\nCommodity: %s\nLocation: %s", tokenDetails.TokenName, tokenDetails.TokenSymbol, tokenDetails.TokenCommodity, tokenDetails.TokenLocation,
-	)
-	mockAccountService.On("VoucherData", string(tokA_AAddress)).Return(tokenDetails, nil)
-
-	res, err := h.GetVoucherDetails(ctx, "SessionId", []byte(""))
-	assert.NoError(t, err)
-	assert.Equal(t, expectedResult, res)
-}

internal/storage/db.go

@@ -6,6 +6,10 @@ import (
 	"git.defalsify.org/vise.git/db"
 )
 
+const (
+	DATATYPE_USERSUB = 64
+)
+
 // PrefixDb interface abstracts the database operations.
 type PrefixDb interface {
 	Get(ctx context.Context, key []byte) ([]byte, error)
@@ -31,13 +35,13 @@ func (s *SubPrefixDb) toKey(k []byte) []byte {
 }
 
 func (s *SubPrefixDb) Get(ctx context.Context, key []byte) ([]byte, error) {
-	s.store.SetPrefix(db.DATATYPE_USERDATA)
+	s.store.SetPrefix(DATATYPE_USERSUB)
 	key = s.toKey(key)
 	return s.store.Get(ctx, key)
 }
 
 func (s *SubPrefixDb) Put(ctx context.Context, key []byte, val []byte) error {
-	s.store.SetPrefix(db.DATATYPE_USERDATA)
+	s.store.SetPrefix(DATATYPE_USERSUB)
 	key = s.toKey(key)
 	return s.store.Put(ctx, key, val)
 }

internal/testutil/mocks/servicemock.go

@@ -49,6 +49,6 @@ func (m *MockAccountService) TokenTransfer(ctx context.Context, amount, from, to
 }
 
 func (m *MockAccountService) CheckAliasAddress(ctx context.Context, alias string) (*dataserviceapi.AliasAddress, error) {
-	args := m.Called(alias)
+	args := m.Called()
 	return args.Get(0).(*dataserviceapi.AliasAddress), args.Error(1)
 }

internal/utils/age.go

@@ -1,9 +1,6 @@
 package utils
 
-import (
+import "time"
-	"strconv"
-	"time"
-)
 
 // CalculateAge calculates the age based on a given birthdate and the current date in the format dd/mm/yy
 // It adjusts for cases where the current date is before the birthday in the current year.
@@ -28,29 +25,11 @@ func CalculateAge(birthdate, today time.Time) int {
 // It subtracts the YOB from the current year to determine the age.
 //
 // Parameters:
-//
+//   yob: The year of birth as an integer.
-//	yob: The year of birth as an integer.
 //
 // Returns:
-//
+//   The calculated age as an integer.
-//	The calculated age as an integer.
 func CalculateAgeWithYOB(yob int) int {
-	currentYear := time.Now().Year()
+    currentYear := time.Now().Year()
-	return currentYear - yob
+    return currentYear - yob
-}
+}
-
-
-//IsValidYob checks if the provided yob can be considered valid 
-func IsValidYOb(yob string) bool {
-	currentYear := time.Now().Year()
-	yearOfBirth, err := strconv.ParseInt(yob, 10, 64)
-	if err != nil {
-		return false
-	}
-	if yearOfBirth >= 1900 && int(yearOfBirth) <= currentYear {
-		return true
-	} else {
-		return false
-	}
-
-}

internal/utils/name.go

@@ -1,17 +0,0 @@
-package utils
-
-func ConstructName(firstName, familyName, defaultValue string) string {
-	name := defaultValue
-	if familyName != defaultValue {
-		if firstName != defaultValue {
-			name = firstName + " " + familyName
-		} else {
-			name = familyName
-		}
-	} else {
-		if firstName != defaultValue {
-			name = firstName
-		}
-	}
-	return name
-}

menutraversal_test/group_test.json

@@ -54,7 +54,7 @@
                 },
                 {
                     "input": "1235",
-                    "expectedContent": "Incorrect PIN\n1:Retry\n9:Quit"
+                    "expectedContent": "Incorrect pin\n1:Retry\n9:Quit"
                 },
                 {
                     "input": "1",
@@ -62,7 +62,7 @@
                 },
                 {
                     "input": "1234",
-                    "expectedContent": "Select language:\n0:English\n1:Kiswahili"
+                    "expectedContent": "Select language:\n0:english\n1:kiswahili"
                 },
                 {
                     "input": "0",
@@ -95,7 +95,7 @@
                 },
                 {
                     "input": "1235",
-                    "expectedContent": "Incorrect PIN\n1:Retry\n9:Quit"
+                    "expectedContent": "Incorrect pin\n1:Retry\n9:Quit"
                 },
                 {
                     "input": "1",
@@ -141,7 +141,7 @@
                 },
                 {
                     "input": "1235",
-                    "expectedContent": "Incorrect PIN\n1:Retry\n9:Quit"
+                    "expectedContent": "Incorrect pin\n1:Retry\n9:Quit"
                 },
                 {
                     "input": "1",
@@ -167,7 +167,7 @@
             ]
         },
         {
-            "name": "menu_my_account_edit_all_account_details_starting_from_firstname",
+            "name": "menu_my_account_edit_firstname",
             "steps": [
                 {
                     "input": "",
@@ -187,26 +187,6 @@
                 },
                 {
                     "input": "foo",
-                    "expectedContent": "Enter family name:\n0:Back"
-                },
-                {
-                    "input": "bar",
-                    "expectedContent": "Select gender: \n1:Male\n2:Female\n3:Unspecified\n0:Back"
-                },
-                {
-                    "input": "1",
-                    "expectedContent":  "Enter your year of birth\n0:Back"
-                },
-                {
-                    "input": "1940",
-                    "expectedContent": "Enter your location:\n0:Back"
-                },
-                {
-                    "input": "Kilifi",
-                    "expectedContent": "Enter the services or goods you offer: \n0:Back"
-                },
-                {
-                    "input": "Bananas",
                     "expectedContent": "Please enter your PIN:"
                 },
                 {
@@ -217,6 +197,10 @@
                     "input": "0",
                     "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
                 },
+                {
+                    "input": "0",
+                    "expectedContent": "My Account\n1:Profile\n2:Change language\n3:Check balances\n4:Check statement\n5:PIN options\n6:My Address\n0:Back"
+                },
                 {
                     "input": "0",
                     "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
@@ -224,7 +208,7 @@
             ]
         },
         {
-            "name": "menu_my_account_edit_familyname_when_all_account__details_have_been_set",
+            "name": "menu_my_account_edit_familyname",
             "steps": [
                 {
                     "input": "",
@@ -254,6 +238,10 @@
                     "input": "0",
                     "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
                 },
+                {
+                    "input": "0",
+                    "expectedContent": "My Account\n1:Profile\n2:Change language\n3:Check balances\n4:Check statement\n5:PIN options\n6:My Address\n0:Back"
+                },
                 {
                     "input": "0",
                     "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
@@ -262,7 +250,7 @@
             ]
         },
         {
-            "name": "menu_my_account_edit_gender_when_all_account__details_have_been_set",
+            "name": "menu_my_account_edit_gender",
             "steps": [
                 {
                     "input": "",
@@ -292,6 +280,10 @@
                     "input": "0",
                     "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
                 },
+                {
+                    "input": "0",
+                    "expectedContent": "My Account\n1:Profile\n2:Change language\n3:Check balances\n4:Check statement\n5:PIN options\n6:My Address\n0:Back"
+                },
                 {
                     "input": "0",
                     "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
@@ -299,7 +291,7 @@
             ]
         },
         {
-            "name": "menu_my_account_edit_yob_when_all_account__details_have_been_set",
+            "name": "menu_my_account_edit_yob",
             "steps": [
                 {
                     "input": "",
@@ -329,6 +321,10 @@
                     "input": "0",
                     "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
                 },
+                {
+                    "input": "0",
+                    "expectedContent": "My Account\n1:Profile\n2:Change language\n3:Check balances\n4:Check statement\n5:PIN options\n6:My Address\n0:Back"
+                },
                 {
                     "input": "0",
                     "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
@@ -336,7 +332,7 @@
             ]
         },
         {
-            "name": "menu_my_account_edit_location_when_all_account_details_have_been_set",
+            "name": "menu_my_account_edit_location",
             "steps": [
                 {
                     "input": "",
@@ -366,6 +362,10 @@
                     "input": "0",
                     "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
                 },
+                {
+                    "input": "0",
+                    "expectedContent": "My Account\n1:Profile\n2:Change language\n3:Check balances\n4:Check statement\n5:PIN options\n6:My Address\n0:Back"
+                },
                 {
                     "input": "0",
                     "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
@@ -373,7 +373,7 @@
             ]
         },
         {
-            "name": "menu_my_account_edit_offerings_when_all_account__details_have_been_set",
+            "name": "menu_my_account_edit_offerings",
             "steps": [
                 {
                     "input": "",
@@ -403,6 +403,10 @@
                     "input": "0",
                     "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
                 },
+                {
+                    "input": "0",
+                    "expectedContent": "My Account\n1:Profile\n2:Change language\n3:Check balances\n4:Check statement\n5:PIN options\n6:My Address\n0:Back"
+                },
                 {
                     "input": "0",
                     "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
@@ -430,12 +434,16 @@
                 },
                 {
                     "input": "1234",
-                    "expectedContent": "My profile:\nName: foo bar\nGender: male\nAge: 84\nLocation: Kilifi\nYou provide: Bananas\n\n0:Back"
+                    "expectedContent": "My profile:\nName: foo bar\nGender: male\nAge: 79\nLocation: Kilifi\nYou provide: Bananas\n\n0:Back"
                 },
                 {
                     "input": "0",
                     "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
                 },
+                {
+                    "input": "0",
+                    "expectedContent": "My Account\n1:Profile\n2:Change language\n3:Check balances\n4:Check statement\n5:PIN options\n6:My Address\n0:Back"
+                },
                 {
                     "input": "0",
                     "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"

menutraversal_test/menu_traversal_test.go

@@ -3,7 +3,6 @@ package menutraversaltest
 import (
 	"bytes"
 	"context"
-	"flag"
 	"log"
 	"math/rand"
 	"os"
@@ -16,15 +15,14 @@ import (
 )
 
 var (
-	testData  = driver.ReadData()
+	testData      = driver.ReadData()
-	testStore = ".test_state"
+	testStore     = ".test_state"
-	sessionID string
+	groupTestFile = "group_test.json"
-	src       = rand.NewSource(42)
+	sessionID     string
-	g         = rand.New(src)
+	src           = rand.NewSource(42)
+	g             = rand.New(src)
 )
 
-var groupTestFile = flag.String("test-file", "group_test.json", "The test file to use for running the group tests")
-
 func GenerateSessionId() string {
 	uu := uuid.NewGenWithOptions(uuid.WithRandomReader(g))
 	v, err := uu.NewV4()
@@ -339,7 +337,7 @@ func TestMainMenuSend(t *testing.T) {
 }
 
 func TestGroups(t *testing.T) {
-	groups, err := driver.LoadTestGroups(*groupTestFile)
+	groups, err := driver.LoadTestGroups(groupTestFile)
 	if err != nil {
 		log.Fatalf("Failed to load test groups: %v", err)
 	}

menutraversal_test/profile_edit_start_familyname.json

@@ -1,68 +0,0 @@
-{
-    "groups": [
-        { 
-                "name": "menu_my_account_edit_all_account_details_starting_from_family_name",
-                "steps": [
-                    {
-                        "input": "",
-                        "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
-                    },
-                    {
-                        "input": "3",
-                        "expectedContent": "My Account\n1:Profile\n2:Change language\n3:Check balances\n4:Check statement\n5:PIN options\n6:My Address\n0:Back"
-                    },
-                    {
-                        "input": "1",
-                        "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
-                    },
-                    {
-                        "input": "2",
-                        "expectedContent": "Enter family name:\n0:Back"
-                    },
-                    {
-                        "input": "bar",
-                        "expectedContent": "Select gender: \n1:Male\n2:Female\n3:Unspecified\n0:Back"
-                    },
-                    {
-                        "input": "1",
-                        "expectedContent":  "Enter your year of birth\n0:Back"
-                    },
-                    {
-                        "input": "1940",
-                        "expectedContent": "Enter your location:\n0:Back"
-                    },
-                    {
-                        "input": "Kilifi",
-                        "expectedContent": "Enter the services or goods you offer: \n0:Back"
-                    },
-                    {
-                        "input": "Bananas",
-                        "expectedContent": "Please enter your PIN:"
-                    },
-                    {
-                        "input": "1234",
-                        "expectedContent": "Profile updated successfully\n\n0:Back\n9:Quit"
-                    },
-                    {
-                        "input": "0",
-                        "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
-                    },
-                    {
-                        "input": "0",
-                        "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
-                    }
-                ]
-            }
-    ]
-}
-      
-        
-       
-        
-    
-
-
-    
-
-
-    

menutraversal_test/profile_edit_start_firstname.json

@@ -1,61 +0,0 @@
-{
-    "groups": [
-        { 
-            "name": "menu_my_account_edit_all_account_details_starting_from_firstname",
-            "steps": [
-                {
-                    "input": "",
-                    "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
-                },
-                {
-                    "input": "3",
-                    "expectedContent": "My Account\n1:Profile\n2:Change language\n3:Check balances\n4:Check statement\n5:PIN options\n6:My Address\n0:Back"
-                },
-                {
-                    "input": "1",
-                    "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
-                },
-                {
-                    "input": "1",
-                    "expectedContent": "Enter your first names:\n0:Back"
-                },
-                {
-                    "input": "foo",
-                    "expectedContent": "Enter family name:\n0:Back"
-                },
-                {
-                    "input": "bar",
-                    "expectedContent": "Select gender: \n1:Male\n2:Female\n3:Unspecified\n0:Back"
-                },
-                {
-                    "input": "1",
-                    "expectedContent":  "Enter your year of birth\n0:Back"
-                },
-                {
-                    "input": "1940",
-                    "expectedContent": "Enter your location:\n0:Back"
-                },
-                {
-                    "input": "Kilifi",
-                    "expectedContent": "Enter the services or goods you offer: \n0:Back"
-                },
-                {
-                    "input": "Bananas",
-                    "expectedContent": "Please enter your PIN:"
-                },
-                {
-                    "input": "1234",
-                    "expectedContent": "Profile updated successfully\n\n0:Back\n9:Quit"
-                },
-                {
-                    "input": "0",
-                    "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
-                },
-                {
-                    "input": "0",
-                    "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
-                }
-            ]
-        }
-    ]
-}

menutraversal_test/profile_edit_start_gender.json

@@ -1,55 +0,0 @@
-{
-    "groups": [
-        { 
-                "name": "menu_my_account_edit_all_account_details_starting_from_gender",
-                "steps": [
-                    {
-                        "input": "",
-                        "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
-                    },
-                    {
-                        "input": "3",
-                        "expectedContent": "My Account\n1:Profile\n2:Change language\n3:Check balances\n4:Check statement\n5:PIN options\n6:My Address\n0:Back"
-                    },
-                    {
-                        "input": "1",
-                        "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
-                    },
-                    {
-                        "input": "3",
-                        "expectedContent": "Select gender: \n1:Male\n2:Female\n3:Unspecified\n0:Back"
-                    },
-                    {
-                        "input": "1",
-                        "expectedContent":  "Enter your year of birth\n0:Back"
-                    },
-                    {
-                        "input": "1940",
-                        "expectedContent": "Enter your location:\n0:Back"
-                    },
-                    {
-                        "input": "Kilifi",
-                        "expectedContent": "Enter the services or goods you offer: \n0:Back"
-                    },
-                    {
-                        "input": "Bananas",
-                        "expectedContent": "Please enter your PIN:"
-                    },
-                    {
-                        "input": "1234",
-                        "expectedContent": "Profile updated successfully\n\n0:Back\n9:Quit"
-                    },
-                    {
-                        "input": "0",
-                        "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
-                    },
-                    {
-                        "input": "0",
-                        "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
-                    }
-                ]
-            }
-    ]
-}
-      
-      

menutraversal_test/profile_edit_start_location.json

@@ -1,46 +0,0 @@
-{
-    "groups": [
-        { 
-                "name": "menu_my_account_edit_all_account_details_starting_from_location",
-                "steps": [
-                    {
-                        "input": "",
-                        "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
-                    },
-                    {
-                        "input": "3",
-                        "expectedContent": "My Account\n1:Profile\n2:Change language\n3:Check balances\n4:Check statement\n5:PIN options\n6:My Address\n0:Back"
-                    },
-                    {
-                        "input": "1",
-                        "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
-                    },  
-                    {
-                        "input": "5",
-                        "expectedContent": "Enter your location:\n0:Back"
-                    },
-                    {
-                        "input": "Kilifi",
-                        "expectedContent": "Enter the services or goods you offer: \n0:Back"
-                    },
-                    {
-                        "input": "Bananas",
-                        "expectedContent": "Please enter your PIN:"
-                    },
-                    {
-                        "input": "1234",
-                        "expectedContent": "Profile updated successfully\n\n0:Back\n9:Quit"
-                    },
-                    {
-                        "input": "0",
-                        "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
-                    },
-                    {
-                        "input": "0",
-                        "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
-                    }
-                ]
-            }
-    ]
-}
-     

menutraversal_test/profile_edit_start_offerings.json

@@ -1,42 +0,0 @@
-{
-    "groups": [
-        { 
-                "name": "menu_my_account_edit_all_account_details_starting_from_offerings",
-                "steps": [
-                    {
-                        "input": "",
-                        "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
-                    },
-                    {
-                        "input": "3",
-                        "expectedContent": "My Account\n1:Profile\n2:Change language\n3:Check balances\n4:Check statement\n5:PIN options\n6:My Address\n0:Back"
-                    },
-                    {
-                        "input": "1",
-                        "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
-                    },
-                    {
-                        "input": "6",
-                        "expectedContent": "Enter the services or goods you offer: \n0:Back"
-                    },
-                    {
-                        "input": "Bananas",
-                        "expectedContent": "Please enter your PIN:"
-                    },
-                    {
-                        "input": "1234",
-                        "expectedContent": "Profile updated successfully\n\n0:Back\n9:Quit"
-                    },
-                    {
-                        "input": "0",
-                        "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
-                    },
-                    {
-                        "input": "0",
-                        "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
-                    }
-                ]
-            }
-    ]
-}
-     

menutraversal_test/profile_edit_start_yob.json

@@ -1,50 +0,0 @@
-{
-    "groups": [
-        { 
-                "name": "menu_my_account_edit_all_account_details_starting_from_yob",
-                "steps": [
-                    {
-                        "input": "",
-                        "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
-                    },
-                    {
-                        "input": "3",
-                        "expectedContent": "My Account\n1:Profile\n2:Change language\n3:Check balances\n4:Check statement\n5:PIN options\n6:My Address\n0:Back"
-                    },
-                    {
-                        "input": "1",
-                        "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
-                    },
-                    {
-                        "input": "4",
-                        "expectedContent":  "Enter your year of birth\n0:Back"
-                    },
-                    {
-                        "input": "1940",
-                        "expectedContent": "Enter your location:\n0:Back"
-                    },
-                    {
-                        "input": "Kilifi",
-                        "expectedContent": "Enter the services or goods you offer: \n0:Back"
-                    },
-                    {
-                        "input": "Bananas",
-                        "expectedContent": "Please enter your PIN:"
-                    },
-                    {
-                        "input": "1234",
-                        "expectedContent": "Profile updated successfully\n\n0:Back\n9:Quit"
-                    },
-                    {
-                        "input": "0",
-                        "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
-                    },
-                    {
-                        "input": "0",
-                        "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
-                    }
-                ]
-            }
-    ]
-}
-     

menutraversal_test/profile_edit_when_adjacent_item_set.json

@@ -1,70 +0,0 @@
-{
-    "groups": [
-        { 
-                "name": "menu_my_account_edit_familyname_when_adjacent_profile_information_set",
-                "steps": [
-                    {
-                        "input": "",
-                        "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
-                    },
-                    {
-                        "input": "3",
-                        "expectedContent": "My Account\n1:Profile\n2:Change language\n3:Check balances\n4:Check statement\n5:PIN options\n6:My Address\n0:Back"
-                    },
-                    {
-                        "input": "1",
-                        "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
-                    },
-                    {
-                        "input": "3",
-                        "expectedContent": "Select gender: \n1:Male\n2:Female\n3:Unspecified\n0:Back"
-                    },
-                    {
-                        "input": "1",
-                        "expectedContent":  "Enter your year of birth\n0:Back"
-                    },
-                    {
-                        "input": "1940",
-                        "expectedContent": "Enter your location:\n0:Back"
-                    },
-                    {
-                        "input": "Kilifi",
-                        "expectedContent": "Enter the services or goods you offer: \n0:Back"
-                    },
-                    {
-                        "input": "Bananas",
-                        "expectedContent": "Please enter your PIN:"
-                    },
-                    {
-                        "input": "1234",
-                        "expectedContent": "Profile updated successfully\n\n0:Back\n9:Quit"
-                    },
-                    {
-                        "input": "0",
-                        "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
-                    },
-                    {
-                        "input": "2",
-                        "expectedContent": "Enter family name:\n0:Back"
-                    },
-                    {
-                        "input": "foo2",
-                        "expectedContent": "Please enter your PIN:"
-                    },
-                    {
-                        "input": "1234",
-                        "expectedContent": "Profile updated successfully\n\n0:Back\n9:Quit"
-                    },
-                    {
-                       "input": "0",
-                       "expectedContent": "My profile\n1:Edit name\n2:Edit family name\n3:Edit gender\n4:Edit year of birth\n5:Edit location\n6:Edit offerings\n7:View profile\n0:Back"
-                    },
-                    {
-                        "input": "0",
-                        "expectedContent": "{balance}\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit"
-                    }
-                ]
-            }
-    ]
-}
-    

menutraversal_test/test_setup.json

@@ -7,11 +7,11 @@
                 "steps": [
                     {
                         "input": "",
-                        "expectedContent": "Welcome to Sarafu Network\nPlease select a language\n0:English\n1:Kiswahili"
+                        "expectedContent": "Welcome to Sarafu Network\nPlease select a language\n0:english\n1:kiswahili"
                     },
                     {
                         "input": "0",
-                        "expectedContent": "Do you agree to terms and conditions?\n0:Yes\n1:No"
+                        "expectedContent": "Do you agree to terms and conditions?\n0:yes\n1:no"
                     },
                     {
                         "input": "0",
@@ -40,11 +40,11 @@
                 "steps": [
                     {
                         "input": "",
-                        "expectedContent": "Welcome to Sarafu Network\nPlease select a language\n0:English\n1:Kiswahili"
+                        "expectedContent": "Welcome to Sarafu Network\nPlease select a language\n0:english\n1:kiswahili"
                     },
                     {
                         "input": "0",
-                        "expectedContent": "Do you agree to terms and conditions?\n0:Yes\n1:No"
+                        "expectedContent": "Do you agree to terms and conditions?\n0:yes\n1:no"
                     },
                     {
                         "input": "1",

models/profile.go

@@ -1,18 +0,0 @@
-package models
-
-type Profile struct {
-	ProfileItems []string
-	Max          int
-}
-
-func (p *Profile) InsertOrShift(index int, value string) {
-	if index < len(p.ProfileItems) {
-		p.ProfileItems = append(p.ProfileItems[:index], value)
-	} else {
-		for len(p.ProfileItems) < index {
-			p.ProfileItems = append(p.ProfileItems, "0")
-		}
-		p.ProfileItems = append(p.ProfileItems, "0") 
-		p.ProfileItems[index] = value
-	}
-}

models/voucher_data_result.go

@@ -1,10 +1,8 @@
 package models
 
 type VoucherDataResult struct {
-	TokenName      string `json:"tokenName"`
+	TokenName     string `json:"tokenName"`
-	TokenSymbol    string `json:"tokenSymbol"`
+	TokenSymbol   string `json:"tokenSymbol"`
-	TokenDecimals  int    `json:"tokenDecimals"`
+	TokenDecimals int    `json:"tokenDecimals"`
-	SinkAddress    string `json:"sinkAddress"`
+	SinkAddress   string `json:"sinkAddress"`
-	TokenCommodity string `json:"tokenCommodity"`
-	TokenLocation  string `json:"tokenLocation"`
 }

services/registration/_catch_swa

@@ -1 +0,0 @@
-Tatizo la kimtambo limetokea,tafadhali jaribu tena baadaye.

services/registration/edit_family_name.vis

@@ -2,17 +2,9 @@ CATCH incorrect_pin flag_incorrect_pin 1
 CATCH update_familyname flag_allow_update 1
 LOAD get_current_profile_info 0
 RELOAD get_current_profile_info
-MAP get_current_profile_info
 MOUT back 0
 HALT
-RELOAD set_back 
+LOAD save_familyname 0
-CATCH _ flag_back_set 1
-LOAD save_familyname 64
 RELOAD save_familyname
-CATCH pin_entry flag_familyname_set 1
+INCMP _ 0
-CATCH select_gender flag_gender_set 0
+INCMP pin_entry *
-CATCH edit_yob flag_yob_set 0
-CATCH edit_location flag_location_set 0
-CATCH edit_offerings flag_offerings_set 0
-CATCH pin_entry flag_familyname_set 0
-INCMP select_gender *

services/registration/edit_first_name.vis

@@ -5,14 +5,7 @@ RELOAD get_current_profile_info
 MAP get_current_profile_info
 MOUT back 0
 HALT
-RELOAD set_back 
+LOAD save_firstname 0
-CATCH _ flag_back_set 1
-LOAD save_firstname 128
 RELOAD save_firstname
-CATCH pin_entry flag_firstname_set 1
+INCMP _ 0
-CATCH edit_family_name flag_familyname_set 0
+INCMP pin_entry *
-CATCH edit_gender flag_gender_set 0
-CATCH edit_yob flag_yob_set 0
-CATCH edit_location flag_location_set 0
-CATCH edit_offerings flag_offerings_set 0
-CATCH pin_entry flag_firstname_set 0

services/registration/edit_location.vis

@@ -2,14 +2,9 @@ CATCH incorrect_pin flag_incorrect_pin 1
 CATCH update_location flag_allow_update 1
 LOAD get_current_profile_info 0
 RELOAD get_current_profile_info
-LOAD save_location 16
 MOUT back 0
 HALT
-RELOAD set_back 
+LOAD save_location 0
-CATCH _ flag_back_set 1
 RELOAD save_location
 INCMP _ 0
-CATCH pin_entry flag_location_set 1
+INCMP pin_entry *
-CATCH edit_offerings flag_offerings_set 0
-CATCH pin_entry flag_location_set 0
-INCMP edit_offerings *

services/registration/edit_offerings.vis

@@ -2,13 +2,9 @@ CATCH incorrect_pin flag_incorrect_pin 1
 CATCH update_offerings flag_allow_update 1
 LOAD get_current_profile_info 0
 RELOAD get_current_profile_info
-LOAD save_offerings 8
+LOAD save_offerings 0
 MOUT back 0
 HALT
-RELOAD set_back 
-CATCH _ flag_back_set 1
 RELOAD save_offerings
 INCMP _ 0
-CATCH pin_entry flag_offerings_set 1
+INCMP pin_entry *
-CATCH pin_entry flag_offerings_set 0
-INCMP update_profile_items *

services/registration/edit_profile.vis

@@ -11,8 +11,7 @@ MOUT edit_offerings 6
 MOUT view 7
 MOUT back 0
 HALT
-LOAD set_back 6
+INCMP my_account 0
-INCMP ^ 0
 INCMP edit_first_name 1
 INCMP edit_family_name 2
 INCMP select_gender 3

services/registration/edit_yob.vis

@@ -5,15 +5,10 @@ RELOAD get_current_profile_info
 MAP get_current_profile_info
 MOUT back 0
 HALT
-RELOAD set_back 
-CATCH _ flag_back_set 1
 LOAD verify_yob 6
 RELOAD verify_yob
 CATCH incorrect_date_format flag_incorrect_date_format 1
-LOAD save_yob 32
+LOAD save_yob 0
 RELOAD save_yob
-CATCH pin_entry flag_yob_set 1
+INCMP _ 0
-CATCH edit_location flag_location_set 0
+INCMP pin_entry *
-CATCH edit_offerings flag_offerings_set 0
-CATCH pin_entry flag_yob_set 0
-INCMP edit_location *

services/registration/english_menu

@@ -1 +0,0 @@
-English

services/registration/incorrect_pin

@@ -1 +1 @@
-Incorrect PIN
+Incorrect pin

services/registration/invalid_pin_swa

@@ -1 +1 @@
-PIN mpya na udhibitisho wa PIN mpya hazilingani.Tafadhali jaribu tena.Kwa usaidizi piga simu +254757628885.
+PIN mpya na udhibitisho wa pin mpya hazilingani.Tafadhali jaribu tena.Kwa usaidizi piga simu +254757628885.

services/registration/kiswahili_menu

@@ -1 +0,0 @@
-Kiswahili

services/registration/locale/swa/default.po

@@ -13,7 +13,7 @@ msgstr "Kwa usaidizi zaidi,piga: 0757628885"
 msgid "Balance: %s\n"
 msgstr "Salio: %s\n"
 
-msgid "Your invite request for %s to Sarafu Network failed. Please try again later."
+msid "Your invite request for %s to Sarafu Network failed. Please try again later."
 msgstr "Ombi lako la kumwalika %s kwa matandao wa Sarafu halikufaulu. Tafadhali jaribu tena baadaye."
 
 msgid "Your invitation to %s to join Sarafu Network has been sent."
@@ -23,7 +23,4 @@ msgid "Your request failed. Please try again later."
 msgstr "Ombi lako halikufaulu. Tafadhali jaribu tena baadaye."
 
 msgid "Community Balance: 0.00"
-msgstr "Salio la Kikundi: 0.00"
+msgid "Salio la Kikundi: 0.00"
-
-msgid "Symbol: %s\nBalance: %s"
-msgstr "Sarafu: %s\nSalio: %s"

services/registration/main.vis

@@ -1,10 +1,10 @@
 LOAD set_default_voucher 8
 RELOAD set_default_voucher
+LOAD check_balance 64
+RELOAD check_balance
 LOAD check_vouchers 10
 RELOAD check_vouchers
-LOAD check_balance 128
+CATCH api_failure  flag_api_call_error  1
-RELOAD check_balance
-CATCH api_failure flag_api_call_error 1
 MAP check_balance
 MOUT send 1
 MOUT vouchers 2

services/registration/my_balance_swa

@@ -1 +1 @@
-{{.check_balance}}
+Salio lako ni: 0.00 SRF

services/registration/next_menu

@@ -1 +0,0 @@
-Next

services/registration/next_menu_swa

@@ -1 +0,0 @@
-Mbele

services/registration/no_menu

@@ -1 +1 @@
-No
+no

services/registration/no_menu_swa

@@ -1 +1 @@
-La
+la

services/registration/pp.csv

@@ -21,10 +21,3 @@ flag,flag_admin_privilege,27,this is set when a user has admin privileges.
 flag,flag_unregistered_number,28,this is set when an unregistered phonenumber tries to perform an action
 flag,flag_no_transfers,29,this is set when a user does not have any transactions
 flag,flag_incorrect_statement,30,this is set when the selected statement is invalid
-flag,flag_firstname_set,31,this is set when the first name of the profile is set
-flag,flag_familyname_set,32,this is set when the family name of the profile is set
-flag,flag_yob_set,33,this is set when the yob of the profile is set
-flag,flag_gender_set,34,this is set when the gender of the profile is set
-flag,flag_location_set,35,this is set when the location of the profile is set
-flag,flag_offerings_set,36,this is set when the offerings of the profile is set
-flag,flag_back_set,37,this is set when it is a back navigation

services/registration/prev_menu

@@ -1 +0,0 @@
-Prev

services/registration/prev_menu_swa

@@ -1 +0,0 @@
-Nyuma

services/registration/profile_update_success.vis

@@ -1,5 +1,3 @@
-LOAD update_all_profile_items 0
-RELOAD update_all_profile_items
 MOUT back 0
 MOUT quit 9
 HALT

services/registration/set_eng.vis

@@ -1,4 +1,3 @@
 LOAD set_language 6
-RELOAD set_language
 CATCH terms flag_account_created 0
 MOVE language_changed

services/registration/set_female.vis

@@ -1,10 +1,4 @@
-LOAD save_gender 32
+LOAD save_gender 0
-RELOAD save_gender
 CATCH incorrect_pin flag_incorrect_pin 1
 CATCH update_gender flag_allow_update 1
-CATCH pin_entry flag_gender_set 1
+MOVE pin_entry
-CATCH edit_yob flag_yob_set 0
-CATCH edit_location flag_location_set 0
-CATCH edit_offerings flag_offerings_set 0
-CATCH pin_entry flag_gender_set 0
-MOVE edit_yob

services/registration/set_male.vis

@@ -1,10 +1,4 @@
-LOAD save_gender 16
+LOAD save_gender 0
-RELOAD save_gender
 CATCH incorrect_pin flag_incorrect_pin 1
 CATCH update_gender flag_allow_update 1
-CATCH pin_entry flag_gender_set 1
+MOVE pin_entry
-CATCH edit_yob flag_yob_set 0
-CATCH edit_location flag_location_set 0
-CATCH edit_offerings flag_offerings_set 0
-CATCH pin_entry flag_gender_set 0
-MOVE edit_yob

services/registration/set_swa.vis

@@ -1,4 +1,3 @@
 LOAD set_language 6
-RELOAD set_language
 CATCH terms flag_account_created 0
 MOVE language_changed

services/registration/set_unspecified.vis

@@ -1,10 +1,4 @@
-LOAD save_gender 8
+LOAD save_gender 0
-RELOAD save_gender
 CATCH incorrect_pin flag_incorrect_pin 1
 CATCH update_gender flag_allow_update 1
-CATCH pin_entry flag_gender_set 1
+MOVE pin_entry
-CATCH edit_yob flag_yob_set 0
-CATCH edit_location flag_location_set 0
-CATCH edit_offerings flag_offerings_set 0
-CATCH pin_entry flag_gender_set 0
-MOVE edit_yob

services/registration/update_profile_items.vis

@@ -1,3 +0,0 @@
-CATCH incorrect_pin flag_incorrect_pin 1
-CATCH profile_update_success flag_allow_update 1
-MOVE pin_entry

services/registration/yes_menu

@@ -1 +1 @@
-Yes
+yes

services/registration/yes_menu_swa

@@ -1 +1 @@
-Ndio
+ndio