lash
0 Followers · 0 Following
  • Joined on 2021-10-26
Repositories
1
 Projects Packages Public Activity Starred Repositories
lash commented on pull request urdt/ussd#101 2024-10-14 14:38:52 +02:00
menu-voucherlist

Is this in use? Looks like test code?

lash suggested changes for urdt/ussd#101 2024-10-14 14:38:52 +02:00
menu-voucherlist
lash opened issue urdt/ussd#111 2024-10-11 17:27:44 +02:00
Pass context to all API caller methods
lash opened issue urdt/ussd#110 2024-10-11 15:33:55 +02:00
Implement postgres db alternative
lash commented on pull request urdt/ussd#109 2024-10-10 14:56:32 +02:00
menu-traversal-refactor

My intuition tells me that having an abstraction of the account service TestAccountService that includes a method WaitForAccount would be easier to understand down the road.

lash suggested changes for urdt/ussd#109 2024-10-10 14:56:32 +02:00
menu-traversal-refactor
lash commented on pull request urdt/ussd#109 2024-10-08 15:15:02 +02:00
menu-traversal-refactor

please remove space in filename

lash commented on pull request urdt/ussd#109 2024-10-08 15:15:02 +02:00
menu-traversal-refactor

aren't these structs more or less the same as in the groupdriver.go

lash commented on pull request urdt/ussd#109 2024-10-08 15:15:02 +02:00
menu-traversal-refactor

Can we please use regex here, match start of string

lash commented on pull request urdt/ussd#109 2024-10-08 15:15:02 +02:00
menu-traversal-refactor

can we hide all of this under internal/testutil or something?

lash commented on pull request urdt/ussd#109 2024-10-08 15:15:02 +02:00
menu-traversal-refactor

I would just define the accountservice as a global directly here, instead of the detour of defining a variable

lash commented on pull request urdt/ussd#109 2024-10-08 15:15:02 +02:00
menu-traversal-refactor

no visible change. stray non-printable char?

lash commented on pull request urdt/ussd#109 2024-10-08 15:15:02 +02:00
menu-traversal-refactor

remove all blank lines please

lash commented on pull request urdt/ussd#109 2024-10-08 15:15:02 +02:00
menu-traversal-refactor

Can you please implement the check as a function of the step struct (in reality, any struct that has ExpectedContent), and use regex for the match check instead?

lash commented on pull request urdt/ussd#109 2024-10-08 15:15:02 +02:00
menu-traversal-refactor

Only if run online right?

lash commented on pull request urdt/ussd#109 2024-10-08 15:15:02 +02:00
menu-traversal-refactor

I prefer typedef instead of inline structs, the latter is hard to read.

lash suggested changes for urdt/ussd#109 2024-10-08 15:15:02 +02:00
menu-traversal-refactor
lash commented on issue urdt/ussd#5 2024-10-07 16:13:47 +02:00
Remove menu selector based switch statement in SetLanguage

done

lash closed issue urdt/ussd#5 2024-10-07 16:13:47 +02:00
Remove menu selector based switch statement in SetLanguage
lash opened issue urdt/ussd#107 2024-10-03 16:12:19 +02:00
Add pluggable session id validator