• Joined on 2021-10-26
lash opened issue urdt/ussd#5 2024-08-29 16:24:31 +02:00
Remove menu selector based switch statement in SetLanguage
lash commented on pull request urdt/ussd#4 2024-08-29 16:19:53 +02:00
wip-account-creation

I see this still isn't resolved.

I will make an issue of this, and mark it priority. We will handle it after merge.

lash commented on pull request urdt/ussd#4 2024-08-29 16:18:02 +02:00
wip-account-creation

were we using gettext here too?

lash commented on pull request urdt/ussd#4 2024-08-29 16:18:02 +02:00
wip-account-creation

should not be necessary to set the flag when it already has been set and persisted. That will reduce one file access call each run.

lash commented on pull request urdt/ussd#4 2024-08-29 16:18:02 +02:00
wip-account-creation

I prefer putting regexes like this on top of the file as a const.

lash commented on pull request urdt/ussd#4 2024-08-29 16:18:02 +02:00
wip-account-creation

Please change to "Unspecified"

lash commented on pull request urdt/ussd#4 2024-08-29 16:18:02 +02:00
wip-account-creation

"unlocked" risks being an ambiguous term when we introduce account blocking due to direct action or incorrect pin attempts. can we rename it please?

lash suggested changes for urdt/ussd#4 2024-08-29 16:18:02 +02:00
wip-account-creation

A few small things to sort, then we are good.

lash commented on pull request urdt/ussd#4 2024-08-26 04:59:48 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:59:26 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:59:13 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:59:07 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:59:01 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:58:51 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:58:41 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:58:33 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:58:19 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:58:09 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:56:50 +02:00
wip-account-creation

This stops and gets stuck on correct pin put:

lash commented on pull request urdt/ussd#4 2024-08-26 04:56:50 +02:00
wip-account-creation

Please complete this list