lash - Grassroots Economics

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

Please add a documentation line on each.

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

age needs to be calculated.

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

please rename this flag to USERFLAG_PINMISMATCH to avoid ambiguity.

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

should error?

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

this shouldnt switch on the input string; that requires manual syncing between here and the menu code.

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

could clients of this reuse the pinentry used for unlock instead?

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

It's 14

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

can this (and all its methods) be moved to a separate package please?

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

The page says four digit PIN, so the input must be checked here.

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

Since the balance is already available, should check that input is not more than balance.

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

Please can we have all the http stuff in a separate package?

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

perhaps check this input, 2 or 4 digits, numeric

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

is this a choice in the current ussd?

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

This code is repeated many times. Could we please abstract the json fs part of the get and set to a module implementing an interface with Get and Put?

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

This can be MOVE _ ?

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

This is not caught

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

if quit is chosen, next time the vm is started, the pin creation is never resumed, it just goes directly to main menu. It should prompt for setting pin again.

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

not implemented, and state gets stuck if its chosen. At a minimum please add an immediate quit in such cases.

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

Is this how it works on the USSD now? This has you fill out the entire profile at once.

lash commented on pull request urdt/ussd#4

2024-08-26 04:56:50 +02:00

wip-account-creation

See https://git.grassecon.net/urdt/ussd/pulls/4/files#issuecomment-1194