From d94037d4998fb1f2a554297ec62ebafaaa86d219 Mon Sep 17 00:00:00 2001 From: alfred-mk Date: Thu, 3 Oct 2024 14:07:36 +0300 Subject: [PATCH] combine the invalid PIN case and remove unused tests --- test_engine/menu_traversal_test.go | 62 ------------------------------ test_engine/test_data.json | 58 ++++++---------------------- 2 files changed, 12 insertions(+), 108 deletions(-) diff --git a/test_engine/menu_traversal_test.go b/test_engine/menu_traversal_test.go index af7c329..81dfa8f 100644 --- a/test_engine/menu_traversal_test.go +++ b/test_engine/menu_traversal_test.go @@ -496,37 +496,6 @@ func TestMyAccount_Check_My_Balance(t *testing.T) { } } -func TestMyAccount_Check_My_Balance_IncorrectPin(t *testing.T) { - en, fn := enginetest.TestEngine("session1234112") - defer fn() - ctx := context.Background() - sessions := testData - for _, session := range sessions { - groups := driver.FilterGroupsByName(session.Groups, "menu_my_account_check_my_balance_incorrect_pin") - for _, group := range groups { - for index, step := range group.Steps { - t.Logf("step %v with input %v", index, step.Input) - cont, err := en.Exec(ctx, []byte(step.Input)) - if err != nil { - t.Errorf("Test case '%s' failed at input '%s': %v", group.Name, step.Input, err) - return - } - if !cont { - break - } - w := bytes.NewBuffer(nil) - if _, err := en.Flush(ctx, w); err != nil { - t.Errorf("Test case '%s' failed during Flush: %v", group.Name, err) - } - b := w.Bytes() - if !bytes.Equal(b, []byte(step.ExpectedContent)) { - t.Fatalf("expected:\n\t%s\ngot:\n\t%s\n", step.ExpectedContent, b) - } - } - } - } -} - func TestMyAccount_Check_Community_Balance(t *testing.T) { en, fn := enginetest.TestEngine("session1234112") defer fn() @@ -558,37 +527,6 @@ func TestMyAccount_Check_Community_Balance(t *testing.T) { } } -func TestMyAccount_Check_Community_Balance_IncorrectPin(t *testing.T) { - en, fn := enginetest.TestEngine("session1234112") - defer fn() - ctx := context.Background() - sessions := testData - for _, session := range sessions { - groups := driver.FilterGroupsByName(session.Groups, "menu_my_account_check_community_balance_incorrect_pin") - for _, group := range groups { - for index, step := range group.Steps { - t.Logf("step %v with input %v", index, step.Input) - cont, err := en.Exec(ctx, []byte(step.Input)) - if err != nil { - t.Errorf("Test case '%s' failed at input '%s': %v", group.Name, step.Input, err) - return - } - if !cont { - break - } - w := bytes.NewBuffer(nil) - if _, err := en.Flush(ctx, w); err != nil { - t.Errorf("Test case '%s' failed during Flush: %v", group.Name, err) - } - b := w.Bytes() - if !bytes.Equal(b, []byte(step.ExpectedContent)) { - t.Fatalf("expected:\n\t%s\ngot:\n\t%s\n", step.ExpectedContent, b) - } - } - } - } -} - func TestMyAccount_MyAddress(t *testing.T) { en, fn := enginetest.TestEngine("session1234112") defer fn() diff --git a/test_engine/test_data.json b/test_engine/test_data.json index 1d16cba..e31694d 100644 --- a/test_engine/test_data.json +++ b/test_engine/test_data.json @@ -459,6 +459,14 @@ "input": "1", "expectedContent": "Please enter your PIN:" }, + { + "input": "1235", + "expectedContent": "Incorrect pin\n1:retry\n9:Quit" + }, + { + "input": "1", + "expectedContent": "Please enter your PIN:" + }, { "input": "1234", "expectedContent": "Your balance is: 0.00 SRFYour account balance is 0.003 CELO" @@ -485,58 +493,16 @@ "expectedContent": "Please enter your PIN:" }, { - "input": "1234", - "expectedContent": "Your balance is: 0.00 SRFYour account balance is 0.003 CELO" - } - ] - }, - { - "name": "menu_my_account_check_my_balance_incorrect_pin", - "steps": [ - { - "input": "", - "expectedContent": "Balance: 0.003 CELO\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit" - }, - { - "input": "3", - "expectedContent": "My Account\n1:Profile\n2:Change language\n3:Check balances\n4:Check statement\n5:PIN options\n6:My Address\n0:Back" - }, - { - "input": "3", - "expectedContent": "Balances:\n1:My balance\n2:Community balance\n0:Back" + "input": "1235", + "expectedContent": "Incorrect pin\n1:retry\n9:Quit" }, { "input": "1", "expectedContent": "Please enter your PIN:" }, { - "input": "1235", - "expectedContent": "Incorrect pin\n1:retry\n9:Quit" - } - ] - }, - { - "name": "menu_my_account_check_community_balance_incorrect_pin", - "steps": [ - { - "input": "", - "expectedContent": "Balance: 0.003 CELO\n\n1:Send\n2:My Vouchers\n3:My Account\n4:Help\n9:Quit" - }, - { - "input": "3", - "expectedContent": "My Account\n1:Profile\n2:Change language\n3:Check balances\n4:Check statement\n5:PIN options\n6:My Address\n0:Back" - }, - { - "input": "3", - "expectedContent": "Balances:\n1:My balance\n2:Community balance\n0:Back" - }, - { - "input": "2", - "expectedContent": "Please enter your PIN:" - }, - { - "input": "1235", - "expectedContent": "Incorrect pin\n1:retry\n9:Quit" + "input": "1234", + "expectedContent": "Your balance is: 0.00 SRFYour account balance is 0.003 CELO" } ] },