remove

redundant catch on pin entry

internal/handlers/ussd/menuhandler.go

@@ -1986,17 +1986,18 @@ func (h *Handlers) insertProfileItems(ctx context.Context, sessionId string, res
 	for index, profileItem := range h.profile.ProfileItems {
 		// Ensure the profileItem is not "0"(is set)
 		if profileItem != "0" {
+			flag, _ := h.flagManager.GetFlag(profileFlagNames[index])
+			isProfileItemSet := h.st.MatchFlag(flag, true)
+			if !isProfileItemSet {
 				err = store.WriteEntry(ctx, sessionId, profileDataKeys[index], []byte(profileItem))
 				if err != nil {
 					logg.ErrorCtxf(ctx, "failed to write profile entry with", "key", profileDataKeys[index], "value", profileItem, "error", err)
 					return err
 				}
-
-			// Get the flag for the current index
-			flag, _ := h.flagManager.GetFlag(profileFlagNames[index])
 				res.FlagSet = append(res.FlagSet, flag)
 			}
 		}
+	}
 	return nil
 }
 

services/registration/edit_offerings.vis

@@ -10,5 +10,4 @@ CATCH _ flag_back_set 1
 RELOAD save_offerings
 INCMP _ 0
 CATCH pin_entry flag_offerings_set 1
-CATCH pin_entry flag_offerings_set 0
 INCMP update_profile_items *

services/registration/select_gender.vis

@@ -11,3 +11,4 @@ INCMP _ 0
 INCMP set_male 1
 INCMP set_female 2
 INCMP set_unspecified 3
+INCMP . *