internal/handlers/ussd/menuhandler.go

@@ -543,7 +543,6 @@ func (h *Handlers) SaveLocation(ctx context.Context, sym string, input []byte) (
 			logg.ErrorCtxf(ctx, "failed to write location entry with", "key", common.DATA_LOCATION, "value", temporaryLocation, "error", err)
 			return res, err
 		}
-		res.FlagSet = append(res.FlagSet, flag_location_set)
 	} else {
 		if locationSet {
 			err = store.WriteEntry(ctx, sessionId, common.DATA_TEMPORARY_VALUE, []byte(location))

internal/handlers/ussd/menuhandler_test.go

@@ -179,14 +179,11 @@ func TestSaveFirstname(t *testing.T) {
 	fm, _ := NewFlagManager(flagsPath)
 
 	flag_allow_update, _ := fm.GetFlag("flag_allow_update")
-	flag_firstname_set, _ := fm.GetFlag("flag_firstname_set")
 
 	// Set the flag in the State
-	mockState := state.NewState(128)
+	mockState := state.NewState(16)
 	mockState.SetFlag(flag_allow_update)
 
-	expectedResult := resource.Result{}
-
 	// Define test data
 	firstName := "John"
 
@@ -194,8 +191,6 @@ func TestSaveFirstname(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	expectedResult.FlagSet = []uint32{flag_firstname_set}
-
 	// Create the Handlers instance with the mock store
 	h := &Handlers{
 		userdataStore: store,
@@ -208,7 +203,7 @@ func TestSaveFirstname(t *testing.T) {
 
 	// Assert results
 	assert.NoError(t, err)
-	assert.Equal(t, expectedResult, res)
+	assert.Equal(t, resource.Result{}, res)
 
 	// Verify that the DATA_FIRST_NAME entry has been updated with the temporary value
 	storedFirstName, _ := store.ReadEntry(ctx, sessionId, common.DATA_FIRST_NAME)
@@ -223,16 +218,11 @@ func TestSaveFamilyname(t *testing.T) {
 	fm, _ := NewFlagManager(flagsPath)
 
 	flag_allow_update, _ := fm.GetFlag("flag_allow_update")
-	flag_firstname_set, _ := fm.GetFlag("flag_familyname_set")
 
 	// Set the flag in the State
-	mockState := state.NewState(128)
+	mockState := state.NewState(16)
 	mockState.SetFlag(flag_allow_update)
 
-	expectedResult := resource.Result{}
-
-	expectedResult.FlagSet = []uint32{flag_firstname_set}
-
 	// Define test data
 	familyName := "Doeee"
 
@@ -252,7 +242,7 @@ func TestSaveFamilyname(t *testing.T) {
 
 	// Assert results
 	assert.NoError(t, err)
-	assert.Equal(t, expectedResult, res)
+	assert.Equal(t, resource.Result{}, res)
 
 	// Verify that the DATA_FAMILY_NAME entry has been updated with the temporary value
 	storedFamilyName, _ := store.ReadEntry(ctx, sessionId, common.DATA_FAMILY_NAME)
@@ -267,14 +257,11 @@ func TestSaveYoB(t *testing.T) {
 	fm, _ := NewFlagManager(flagsPath)
 
 	flag_allow_update, _ := fm.GetFlag("flag_allow_update")
-	flag_yob_set, _ := fm.GetFlag("flag_yob_set")
 
 	// Set the flag in the State
-	mockState := state.NewState(108)
+	mockState := state.NewState(16)
 	mockState.SetFlag(flag_allow_update)
 
-	expectedResult := resource.Result{}
-
 	// Define test data
 	yob := "1980"
 
@@ -282,8 +269,6 @@ func TestSaveYoB(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	expectedResult.FlagSet = []uint32{flag_yob_set}
-
 	// Create the Handlers instance with the mock store
 	h := &Handlers{
 		userdataStore: store,
@@ -296,7 +281,7 @@ func TestSaveYoB(t *testing.T) {
 
 	// Assert results
 	assert.NoError(t, err)
-	assert.Equal(t, expectedResult, res)
+	assert.Equal(t, resource.Result{}, res)
 
 	// Verify that the DATA_YOB entry has been updated with the temporary value
 	storedYob, _ := store.ReadEntry(ctx, sessionId, common.DATA_YOB)
@@ -311,14 +296,11 @@ func TestSaveLocation(t *testing.T) {
 	fm, _ := NewFlagManager(flagsPath)
 
 	flag_allow_update, _ := fm.GetFlag("flag_allow_update")
-	flag_location_set, _ := fm.GetFlag("flag_location_set")
 
 	// Set the flag in the State
-	mockState := state.NewState(108)
+	mockState := state.NewState(16)
 	mockState.SetFlag(flag_allow_update)
 
-	expectedResult := resource.Result{}
-
 	// Define test data
 	location := "Kilifi"
 
@@ -326,8 +308,6 @@ func TestSaveLocation(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	expectedResult.FlagSet = []uint32{flag_location_set}
-
 	// Create the Handlers instance with the mock store
 	h := &Handlers{
 		userdataStore: store,
@@ -340,7 +320,7 @@ func TestSaveLocation(t *testing.T) {
 
 	// Assert results
 	assert.NoError(t, err)
-	assert.Equal(t, expectedResult, res)
+	assert.Equal(t, resource.Result{}, res)
 
 	// Verify that the DATA_LOCATION entry has been updated with the temporary value
 	storedLocation, _ := store.ReadEntry(ctx, sessionId, common.DATA_LOCATION)
@@ -355,14 +335,11 @@ func TestSaveOfferings(t *testing.T) {
 	fm, _ := NewFlagManager(flagsPath)
 
 	flag_allow_update, _ := fm.GetFlag("flag_allow_update")
-	flag_offerings_set, _ := fm.GetFlag("flag_offerings_set")
 
 	// Set the flag in the State
-	mockState := state.NewState(108)
+	mockState := state.NewState(16)
 	mockState.SetFlag(flag_allow_update)
 
-	expectedResult := resource.Result{}
-
 	// Define test data
 	offerings := "Bananas"
 
@@ -370,8 +347,6 @@ func TestSaveOfferings(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	expectedResult.FlagSet = []uint32{flag_offerings_set}
-
 	// Create the Handlers instance with the mock store
 	h := &Handlers{
 		userdataStore: store,
@@ -384,7 +359,7 @@ func TestSaveOfferings(t *testing.T) {
 
 	// Assert results
 	assert.NoError(t, err)
-	assert.Equal(t, expectedResult, res)
+	assert.Equal(t, resource.Result{}, res)
 
 	// Verify that the DATA_OFFERINGS entry has been updated with the temporary value
 	storedOfferings, _ := store.ReadEntry(ctx, sessionId, common.DATA_OFFERINGS)
@@ -399,10 +374,9 @@ func TestSaveGender(t *testing.T) {
 	fm, _ := NewFlagManager(flagsPath)
 
 	flag_allow_update, _ := fm.GetFlag("flag_allow_update")
-	flag_gender_set, _ := fm.GetFlag("flag_gender_set")
 
 	// Set the flag in the State
-	mockState := state.NewState(108)
+	mockState := state.NewState(16)
 	mockState.SetFlag(flag_allow_update)
 
 	// Define test cases
@@ -446,16 +420,12 @@ func TestSaveGender(t *testing.T) {
 				flagManager:   fm.parser,
 			}
 
-			expectedResult := resource.Result{}
-
 			// Call the method
 			res, err := h.SaveGender(ctx, "save_gender", tt.input)
 
-			expectedResult.FlagSet = []uint32{flag_gender_set}
-
 			// Assert results
 			assert.NoError(t, err)
-			assert.Equal(t, expectedResult, res)
+			assert.Equal(t, resource.Result{}, res)
 
 			// Verify that the DATA_GENDER entry has been updated with the temporary value
 			storedGender, _ := store.ReadEntry(ctx, sessionId, common.DATA_GENDER)