common/pin.go

@@ -6,13 +6,10 @@ import (
 	"golang.org/x/crypto/bcrypt"
 )
 
-const (
 // Define the regex pattern as a constant
+const (
 	pinPattern         = `^\d{4}$`
-
-	//Allowed incorrect  PIN attempts
 	AllowedPINAttempts = uint8(3)
-	
 )
 
 // checks whether the given input is a 4 digit number

internal/handlers/ussd/menuhandler.go

@@ -747,7 +747,7 @@ func (h *Handlers) Authorize(ctx context.Context, sym string, input []byte) (res
 				}
 			}
 		} else {
-			err := h.incrementIncorrectPINAttempts(ctx, sessionId)
+			err := h.countIncorrectPINAttempts(ctx, sessionId)
 			if err != nil {
 				return res, err
 			}
@@ -2124,8 +2124,8 @@ func (h *Handlers) UpdateAllProfileItems(ctx context.Context, sym string, input
 	return res, nil
 }
 
-// incrementIncorrectPINAttempts keeps track of the number of incorrect PIN attempts
-func (h *Handlers) incrementIncorrectPINAttempts(ctx context.Context, sessionId string) error {
+// countIncorrectPINAttempts keeps track of the number of incorrect PIN attempts
+func (h *Handlers) countIncorrectPINAttempts(ctx context.Context, sessionId string) error {
 	var pinAttemptsCount uint8
 	store := h.userdataStore
 
@@ -2163,8 +2163,8 @@ func (h *Handlers) resetIncorrectPINAttempts(ctx context.Context, sessionId stri
 		}
 		return err
 	}
-	currentWrongPinAttemptsCount, _ := strconv.ParseUint(string(currentWrongPinAttempts), 0, 64)
-	if currentWrongPinAttemptsCount <= uint64(common.AllowedPINAttempts) {
+	remainingPINAttempts, _ := strconv.ParseUint(string(currentWrongPinAttempts), 0, 64)
+	if remainingPINAttempts <= uint64(common.AllowedPINAttempts) {
 		err = store.WriteEntry(ctx, sessionId, common.DATA_INCORRECT_PIN_ATTEMPTS, []byte(string("0")))
 		if err != nil {
 			logg.ErrorCtxf(ctx, "failed to reset incorrect PIN attempts ", "key", common.DATA_INCORRECT_PIN_ATTEMPTS, "value", common.AllowedPINAttempts, "error", err)

internal/handlers/ussd/menuhandler_test.go

@@ -2247,7 +2247,7 @@ func TestCountIncorrectPINAttempts(t *testing.T) {
 	if err != nil {
 		t.Logf(err.Error())
 	}
-	err = h.incrementIncorrectPINAttempts(ctx, sessionId)
+	err = h.countIncorrectPINAttempts(ctx, sessionId)
 	if err != nil {
 		t.Logf(err.Error())
 	}